From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?Christian_K=c3=b6nig?= Subject: Re: [PATCH] drm/amdgpu: enable paging queue doorbell support v2 Date: Mon, 19 Nov 2018 12:24:26 +0100 Message-ID: <93f3ef85-337c-e527-dc1e-b54deebe7065@gmail.com> References: <20181115190936.19746-1-Philip.Yang@amd.com> Reply-To: christian.koenig-5C7GfCeVMHo@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20181115190936.19746-1-Philip.Yang-5C7GfCeVMHo@public.gmane.org> Content-Language: en-US List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: "Yang, Philip" , "amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org" QW0gMTUuMTEuMTggdW0gMjA6MTAgc2NocmllYiBZYW5nLCBQaGlsaXA6Cj4gcGFnaW5nIHF1ZXVl cyBkb29yYmVsbCBpbmRleCB1c2UgZXhpc3RpbmcgYXNzaWdubWVudCBzRE1BX0hJX1BSSV9FTkdJ TkUwLzEKPiBpbmRleCwgYW5kIGluY3JlYXNlIFNETUFfRE9PUkJFTExfUkFOR0Ugc2l6ZSBmcm9t IDIgZHdvcmRzIHRvIDQgZHdvcmRzIHRvCj4gZW5hYmxlIHRoZSBuZXcgZG9vcmJlbGwgaW5kZXgu Cj4KPiB2MjogZGlzYWJsZSBwYWdpbmcgcXVldWUgZG9vcmJlbGwgb24gVmVnYTEwIGFuZCBWZWdh MTIgd2l0aCBTUklPVgo+Cj4gQ2hhbmdlLUlkOiBJOWFkYjk2NWYxNmVlNDA4OWQyNjFkOWEyMjIz MTMzNzczOTE4NGU0OQo+IFNpZ25lZC1vZmYtYnk6IFBoaWxpcCBZYW5nIDxQaGlsaXAuWWFuZ0Bh bWQuY29tPgoKQWNrZWQtYnk6IENocmlzdGlhbiBLw7ZuaWcgPGNocmlzdGlhbi5rb2VuaWdAYW1k LmNvbT4KCj4gLS0tCj4gICBkcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9uYmlvX3Y2XzEuYyB8 ICAyICstCj4gICBkcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9uYmlvX3Y3XzQuYyB8ICAyICst Cj4gICBkcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9zZG1hX3Y0XzAuYyB8IDI2ICsrKysrKysr KysrKysrKysrKy0tLS0tLS0tCj4gICAzIGZpbGVzIGNoYW5nZWQsIDIwIGluc2VydGlvbnMoKyks IDEwIGRlbGV0aW9ucygtKQo+Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1k Z3B1L25iaW9fdjZfMS5jIGIvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvbmJpb192Nl8xLmMK PiBpbmRleCA2ZjljNTQ5NzhjYzEuLjBlYjQyYzI5ZWNhYyAxMDA2NDQKPiAtLS0gYS9kcml2ZXJz L2dwdS9kcm0vYW1kL2FtZGdwdS9uYmlvX3Y2XzEuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9h bWQvYW1kZ3B1L25iaW9fdjZfMS5jCj4gQEAgLTgwLDcgKzgwLDcgQEAgc3RhdGljIHZvaWQgbmJp b192Nl8xX3NkbWFfZG9vcmJlbGxfcmFuZ2Uoc3RydWN0IGFtZGdwdV9kZXZpY2UgKmFkZXYsIGlu dCBpbnN0YW4KPiAgIAo+ICAgCWlmICh1c2VfZG9vcmJlbGwpIHsKPiAgIAkJZG9vcmJlbGxfcmFu Z2UgPSBSRUdfU0VUX0ZJRUxEKGRvb3JiZWxsX3JhbmdlLCBCSUZfU0RNQTBfRE9PUkJFTExfUkFO R0UsIE9GRlNFVCwgZG9vcmJlbGxfaW5kZXgpOwo+IC0JCWRvb3JiZWxsX3JhbmdlID0gUkVHX1NF VF9GSUVMRChkb29yYmVsbF9yYW5nZSwgQklGX1NETUEwX0RPT1JCRUxMX1JBTkdFLCBTSVpFLCAy KTsKPiArCQlkb29yYmVsbF9yYW5nZSA9IFJFR19TRVRfRklFTEQoZG9vcmJlbGxfcmFuZ2UsIEJJ Rl9TRE1BMF9ET09SQkVMTF9SQU5HRSwgU0laRSwgNCk7Cj4gICAJfSBlbHNlCj4gICAJCWRvb3Ji ZWxsX3JhbmdlID0gUkVHX1NFVF9GSUVMRChkb29yYmVsbF9yYW5nZSwgQklGX1NETUEwX0RPT1JC RUxMX1JBTkdFLCBTSVpFLCAwKTsKPiAgIAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0v YW1kL2FtZGdwdS9uYmlvX3Y3XzQuYyBiL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L25iaW9f djdfNC5jCj4gaW5kZXggZjhjZWU5NWQ2MWNjLi45MzQyZWUwM2Q3ZDQgMTAwNjQ0Cj4gLS0tIGEv ZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvbmJpb192N180LmMKPiArKysgYi9kcml2ZXJzL2dw dS9kcm0vYW1kL2FtZGdwdS9uYmlvX3Y3XzQuYwo+IEBAIC03Niw3ICs3Niw3IEBAIHN0YXRpYyB2 b2lkIG5iaW9fdjdfNF9zZG1hX2Rvb3JiZWxsX3JhbmdlKHN0cnVjdCBhbWRncHVfZGV2aWNlICph ZGV2LCBpbnQgaW5zdGFuCj4gICAKPiAgIAlpZiAodXNlX2Rvb3JiZWxsKSB7Cj4gICAJCWRvb3Ji ZWxsX3JhbmdlID0gUkVHX1NFVF9GSUVMRChkb29yYmVsbF9yYW5nZSwgQklGX1NETUEwX0RPT1JC RUxMX1JBTkdFLCBPRkZTRVQsIGRvb3JiZWxsX2luZGV4KTsKPiAtCQlkb29yYmVsbF9yYW5nZSA9 IFJFR19TRVRfRklFTEQoZG9vcmJlbGxfcmFuZ2UsIEJJRl9TRE1BMF9ET09SQkVMTF9SQU5HRSwg U0laRSwgMik7Cj4gKwkJZG9vcmJlbGxfcmFuZ2UgPSBSRUdfU0VUX0ZJRUxEKGRvb3JiZWxsX3Jh bmdlLCBCSUZfU0RNQTBfRE9PUkJFTExfUkFOR0UsIFNJWkUsIDQpOwo+ICAgCX0gZWxzZQo+ICAg CQlkb29yYmVsbF9yYW5nZSA9IFJFR19TRVRfRklFTEQoZG9vcmJlbGxfcmFuZ2UsIEJJRl9TRE1B MF9ET09SQkVMTF9SQU5HRSwgU0laRSwgMCk7Cj4gICAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9n cHUvZHJtL2FtZC9hbWRncHUvc2RtYV92NF8wLmMgYi9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdw dS9zZG1hX3Y0XzAuYwo+IGluZGV4IGY0NDkwY2RkOTgwNC4uMWYxOWYxNWJiMTcxIDEwMDY0NAo+ IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L3NkbWFfdjRfMC5jCj4gKysrIGIvZHJp dmVycy9ncHUvZHJtL2FtZC9hbWRncHUvc2RtYV92NF8wLmMKPiBAQCAtOTI1LDExICs5MjUsOSBA QCBzdGF0aWMgdm9pZCBzZG1hX3Y0XzBfcGFnZV9yZXN1bWUoc3RydWN0IGFtZGdwdV9kZXZpY2Ug KmFkZXYsIHVuc2lnbmVkIGludCBpKQo+ICAgCQkJCQlPRkZTRVQsIHJpbmctPmRvb3JiZWxsX2lu ZGV4KTsKPiAgIAlXUkVHMzJfU0RNQShpLCBtbVNETUEwX1BBR0VfRE9PUkJFTEwsIGRvb3JiZWxs KTsKPiAgIAlXUkVHMzJfU0RNQShpLCBtbVNETUEwX1BBR0VfRE9PUkJFTExfT0ZGU0VULCBkb29y YmVsbF9vZmZzZXQpOwo+IC0JLyogVE9ETzogZW5hYmxlIGRvb3JiZWxsIHN1cHBvcnQgKi8KPiAt CS8qYWRldi0+bmJpb19mdW5jcy0+c2RtYV9kb29yYmVsbF9yYW5nZShhZGV2LCBpLCByaW5nLT51 c2VfZG9vcmJlbGwsCj4gLQkJCQkJICAgICAgcmluZy0+ZG9vcmJlbGxfaW5kZXgpOyovCj4gICAK PiAtCXNkbWFfdjRfMF9yaW5nX3NldF93cHRyKHJpbmcpOwo+ICsJLyogcGFnaW5nIHF1ZXVlIGRv b3JiZWxsIGluZGV4IGlzIGFscmVhZHkgZW5hYmxlZCBhdCBzZG1hX3Y0XzBfZ2Z4X3Jlc3VtZSAq Lwo+ICsJc2RtYV92NF8wX3BhZ2VfcmluZ19zZXRfd3B0cihyaW5nKTsKPiAgIAo+ICAgCS8qIHNl dCBtaW5vcl9wdHJfdXBkYXRlIHRvIDAgYWZ0ZXIgd3B0ciBwcm9ncmFtZWQgKi8KPiAgIAlXUkVH MzJfU0RNQShpLCBtbVNETUEwX1BBR0VfTUlOT1JfUFRSX1VQREFURSwgMCk7Cj4gQEAgLTE1MDQs OSArMTUwMiw2IEBAIHN0YXRpYyBpbnQgc2RtYV92NF8wX3N3X2luaXQodm9pZCAqaGFuZGxlKQo+ ICAgCQlyaW5nLT5yaW5nX29iaiA9IE5VTEw7Cj4gICAJCXJpbmctPnVzZV9kb29yYmVsbCA9IHRy dWU7Cj4gICAKPiAtCQlEUk1fSU5GTygidXNlX2Rvb3JiZWxsIGJlaW5nIHNldCB0bzogWyVzXVxu IiwKPiAtCQkJCXJpbmctPnVzZV9kb29yYmVsbD8idHJ1ZSI6ImZhbHNlIik7Cj4gLQo+ICAgCQlp ZiAoYWRldi0+YXNpY190eXBlID09IENISVBfVkVHQTEwKQo+ICAgCQkJcmluZy0+ZG9vcmJlbGxf aW5kZXggPSAoaSA9PSAwKSA/Cj4gICAJCQkJKEFNREdQVV9WRUdBMTBfRE9PUkJFTEw2NF9zRE1B X0VOR0lORTAgPDwgMSkgLy9nZXQgRFdPUkQgb2Zmc2V0Cj4gQEAgLTE1MTYsNiArMTUxMSw4IEBA IHN0YXRpYyBpbnQgc2RtYV92NF8wX3N3X2luaXQodm9pZCAqaGFuZGxlKQo+ICAgCQkJCShBTURH UFVfRE9PUkJFTEw2NF9zRE1BX0VOR0lORTAgPDwgMSkgLy9nZXQgRFdPUkQgb2Zmc2V0Cj4gICAJ CQkJOiAoQU1ER1BVX0RPT1JCRUxMNjRfc0RNQV9FTkdJTkUxIDw8IDEpOyAvLyBnZXQgRFdPUkQg b2Zmc2V0Cj4gICAKPiArCQlEUk1fREVCVUcoInVzZV9kb29yYmVsbCBiZWluZyBzZXQgdG86IFsl c10gZG9vcmJlbGwgaW5kZXggJWRcbiIsCj4gKwkJCXJpbmctPnVzZV9kb29yYmVsbD8idHJ1ZSI6 ImZhbHNlIiwgcmluZy0+ZG9vcmJlbGxfaW5kZXgpOwo+ICAgCj4gICAJCXNwcmludGYocmluZy0+ bmFtZSwgInNkbWElZCIsIGkpOwo+ICAgCQlyID0gYW1kZ3B1X3JpbmdfaW5pdChhZGV2LCByaW5n LCAxMDI0LAo+IEBAIC0xNTI5LDcgKzE1MjYsMjAgQEAgc3RhdGljIGludCBzZG1hX3Y0XzBfc3df aW5pdCh2b2lkICpoYW5kbGUpCj4gICAJCWlmIChhZGV2LT5zZG1hLmhhc19wYWdlX3F1ZXVlKSB7 Cj4gICAJCQlyaW5nID0gJmFkZXYtPnNkbWEuaW5zdGFuY2VbaV0ucGFnZTsKPiAgIAkJCXJpbmct PnJpbmdfb2JqID0gTlVMTDsKPiAtCQkJcmluZy0+dXNlX2Rvb3JiZWxsID0gZmFsc2U7Cj4gKwkJ CWlmICghYW1kZ3B1X3NyaW92X3ZmKGFkZXYpIHx8IGFkZXYtPmFzaWNfdHlwZSA9PSBDSElQX1ZF R0EyMCkKPiArCQkJCXJpbmctPnVzZV9kb29yYmVsbCA9IHRydWU7Cj4gKwo+ICsJCQlpZiAoYWRl di0+YXNpY190eXBlID09IENISVBfVkVHQTEwKQo+ICsJCQkJcmluZy0+ZG9vcmJlbGxfaW5kZXgg PSAoaSA9PSAwKSA/Cj4gKwkJCQkJKEFNREdQVV9WRUdBMTBfRE9PUkJFTEw2NF9zRE1BX0hJX1BS SV9FTkdJTkUwIDw8IDEpCj4gKwkJCQkJOiAoQU1ER1BVX1ZFR0ExMF9ET09SQkVMTDY0X3NETUFf SElfUFJJX0VOR0lORTEgPDwgMSk7Cj4gKwkJCWVsc2UKPiArCQkJCXJpbmctPmRvb3JiZWxsX2lu ZGV4ID0gKGkgPT0gMCkgPwo+ICsJCQkJCShBTURHUFVfRE9PUkJFTEw2NF9zRE1BX0hJX1BSSV9F TkdJTkUwIDw8IDEpCj4gKwkJCQkJOiAoQU1ER1BVX0RPT1JCRUxMNjRfc0RNQV9ISV9QUklfRU5H SU5FMSA8PCAxKTsKPiArCj4gKwkJCURSTV9ERUJVRygicGFnaW5nIHF1ZXVlIGRvb3JiZWxsIGJl aW5nIHNldCB0bzogWyVzXSBkb29yYmVsbCBpbmRleCAlZFxuIiwKPiArCQkJCXJpbmctPnVzZV9k b29yYmVsbD8idHJ1ZSI6ImZhbHNlIiwgcmluZy0+ZG9vcmJlbGxfaW5kZXgpOwo+ICAgCj4gICAJ CQlzcHJpbnRmKHJpbmctPm5hbWUsICJwYWdlJWQiLCBpKTsKPiAgIAkJCXIgPSBhbWRncHVfcmlu Z19pbml0KGFkZXYsIHJpbmcsIDEwMjQsCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fXwphbWQtZ2Z4IG1haWxpbmcgbGlzdAphbWQtZ2Z4QGxpc3RzLmZyZWVk ZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZv L2FtZC1nZngK