From: Segher Boessenkool <segher@kernel.crashing.org>
To: Scott Wood <scottwood@freescale.com>
Cc: linuxppc-dev@ozlabs.org, jgarzik@pobox.com, netdev@vger.kernel.org
Subject: Re: [PATCH v2] gianfar: Add I/O barriers when touching buffer descriptor ownership.
Date: Thu, 3 May 2007 01:42:06 +0200 [thread overview]
Message-ID: <9403063bda028d0dfe9e5a05ceea4d7a@kernel.crashing.org> (raw)
In-Reply-To: <4638F734.2040809@freescale.com>
>>> And the driver is already ppc-specific; it uses in/out_be32.
>>
>> True, but its hidden behind the gfar_read/write accessors.
>>
>> Your change is a bit more blatant.
>
> Well, Segher doesn't want me to use iobarrier (because it's not I/O).
> Andy doesn't want me to use wmb() (because it's sync).
You should use wmb(), but unfortunately too strong
semantics are required for that (ordering wrt I/O)
so it's a full sync on PowerPC. I don't believe
a priori that that would be notably slower, but if
actually is, you could use eieio() I suppose since
you say the driver is powerpc specific -- but please
put a comment in the source code then saying why you
don't use wmb() there.
Segher
next prev parent reply other threads:[~2007-05-02 23:42 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-02 19:57 [PATCH v2] gianfar: Add I/O barriers when touching buffer descriptor ownership Scott Wood
2007-05-02 20:09 ` Kumar Gala
2007-05-02 20:09 ` Kumar Gala
2007-05-02 20:12 ` Scott Wood
2007-05-02 20:12 ` Scott Wood
2007-05-02 20:20 ` Kumar Gala
2007-05-02 20:20 ` Kumar Gala
2007-05-02 20:40 ` Scott Wood
2007-05-02 20:40 ` Scott Wood
2007-05-02 21:23 ` Kumar Gala
2007-05-02 21:23 ` Kumar Gala
2007-05-02 21:30 ` Scott Wood
2007-05-02 21:30 ` Scott Wood
2007-05-03 2:10 ` Kumar Gala
2007-05-03 2:10 ` Kumar Gala
2007-05-03 16:00 ` Scott Wood
2007-05-03 16:38 ` Segher Boessenkool
2007-05-03 16:38 ` Segher Boessenkool
2007-05-02 23:42 ` Segher Boessenkool [this message]
2007-05-04 22:13 ` Linas Vepstas
2007-05-04 22:13 ` Linas Vepstas
2007-05-04 23:24 ` Olof Johansson
2007-05-05 0:41 ` Segher Boessenkool
2007-05-05 0:41 ` Segher Boessenkool
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9403063bda028d0dfe9e5a05ceea4d7a@kernel.crashing.org \
--to=segher@kernel.crashing.org \
--cc=jgarzik@pobox.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=netdev@vger.kernel.org \
--cc=scottwood@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.