Re: [PATCH] drm/xe: Fix build with DRM_XE=y and CONFIGFS_FS=m

[Jani Nikula <jani.nikula@linux.intel.com>]

On Fri, 16 Oct 2026, Rodrigo Vivi <rodrigo.vivi@intel.com> wrote:
> When xe is built-in but configfs is a module, xe_configfs.o is not
> linked into xe, while IS_ENABLED(CONFIG_CONFIGFS_FS) in xe_configfs.h
> still exposes the real declarations, leading to undefined references.
>
> Use IS_REACHABLE() so this case falls back to the stubs, the same as
> CONFIGFS_FS=n.

I think using IS_REACHABLE() is almost always a mistake. It's a hack to
avoid link errors when something in a module needs something that is
built-in. It's a combo that should be handled at Kconfig level, not at
build level.

BR,
Jani.


>
> Fixes: 16280ded45fb ("drm/xe: Add configfs to enable survivability mode")
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202610160935.Qk4ZxBxY-lkp@intel.com/
> Suggested-by: Matt Roper <matthew.d.roper@intel.com>
> Assisted-by: LLM
> Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> ---
>  drivers/gpu/drm/xe/xe_configfs.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/xe/xe_configfs.h b/drivers/gpu/drm/xe/xe_configfs.h
> index 10a00d6bbf8f..327b648944ff 100644
> --- a/drivers/gpu/drm/xe/xe_configfs.h
> +++ b/drivers/gpu/drm/xe/xe_configfs.h
> @@ -14,7 +14,7 @@
>  
>  struct pci_dev;
>  
> -#if IS_ENABLED(CONFIG_CONFIGFS_FS)
> +#if IS_REACHABLE(CONFIG_CONFIGFS_FS)
>  int xe_configfs_init(void);
>  void xe_configfs_exit(void);
>  void xe_configfs_check_device(struct pci_dev *pdev);

-- 
Jani Nikula, Intel