All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Miloslav Trmač" <mitr@redhat.com>
To: Richard Guy Briggs <rgb@redhat.com>
Cc: Linux-Audit Mailing List <linux-audit@redhat.com>
Subject: Re: pam_tty_audit icanon log switch
Date: Mon, 29 Apr 2013 17:02:09 -0400 (EDT)	[thread overview]
Message-ID: <942759204.3807556.1367269329209.JavaMail.root@redhat.com> (raw)
In-Reply-To: <20130426173726.GD6907@madcap2.tricolour.ca>

----- Original Message -----
> On Thu, Apr 18, 2013 at 03:31:36PM -0400, Miloslav Trmač wrote:
> > ----- Original Message -----
> > I'm still convinced that icanon is not the correct condition, see
> > https://www.redhat.com/archives/linux-audit/2013-March/msg00052.html .
> 
> As I indicated in a previous email, from my testing, you are correct.
> This patch appended should address that.  Comments?

Thanks, this seems fine to me (but I didn't actually test it).

Please rename the field from log_icanon, I don't think it matters whether it's to log_pw, log_passwords or something similar.
    Mirek

--
Linux-audit mailing list
Linux-audit@redhat.com
https://www.redhat.com/mailman/listinfo/linux-audit

      reply	other threads:[~2013-04-29 21:02 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-22  5:46 pam_tty_audit icanon log switch Richard Guy Briggs
2013-03-22  7:19 ` Tomas Mraz
2013-04-26 17:42   ` Richard Guy Briggs
2013-04-29  7:14     ` Tomas Mraz
2013-03-22 16:05 ` Miloslav Trmac
2013-04-11 20:43 ` Eric Paris
2013-04-18 19:14   ` Richard Guy Briggs
2013-04-18 19:31     ` Miloslav Trmač
2013-04-18 20:07       ` Richard Guy Briggs
2013-04-22 17:16         ` Richard Guy Briggs
2013-04-22 17:28           ` Miloslav Trmač
2013-04-22 18:29             ` Richard Guy Briggs
2013-04-26 17:23               ` Richard Guy Briggs
2013-04-26 17:37       ` Richard Guy Briggs
2013-04-29 21:02         ` Miloslav Trmač [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=942759204.3807556.1367269329209.JavaMail.root@redhat.com \
    --to=mitr@redhat.com \
    --cc=linux-audit@redhat.com \
    --cc=rgb@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.