From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Howells Subject: Questions about exportfs Date: Thu, 27 Nov 2008 14:51:40 +0000 Message-ID: <9428.1227797500@redhat.com> Cc: dhowells@redhat.com, viro@ZenIV.linux.org.uk, linux-fsdevel@vger.kernel.org To: Christoph Hellwig Return-path: Received: from mx2.redhat.com ([66.187.237.31]:51464 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751841AbYK0Ovp (ORCPT ); Thu, 27 Nov 2008 09:51:45 -0500 Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Hi Christoph, Can you answer some questions about exportfs please? (1) In linux/exportfs.h, the description of the encode_fh() op says that "encode_fh() should return the number of bytes stored or a negative error code such as %-ENOSPC". This, however, contradicts export_encode_fh(), which returns a member of enum fid_type instead. I presume the docs are wrong, or at least, unclear. (2) Why does exportfs_encode_fh() return the type of the FID? Why not embed it in the fid struct? It seems that the value has to be handed back to the decode routine. (3) Is fat_encode_fh() allowed to return a value not in the fid_type enum? David