From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E1F57CA0EE4 for ; Mon, 18 Aug 2025 08:28:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type:Cc: Reply-To:From:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Subject:In-Reply-To:References:To:MIME-Version:Date: Message-ID:Sender:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=XWp/tBmysKmJq2o3vb/BDDTaTOz3eDMCpDBzyZvqYnc=; b=ikPreoO1VFUcSYjUglCZjja3++ 1XA3rwsgpKdPVnRkkHvp7DmvOmoQRK8VFVCYJIDy0JAo206ijnYlkuRuYGoWNbiWREjwE/awO0o2p AGpaHQijVS5cd6gNjfD7SjkKXx+Th0eo2la40iFk6k3mmqZjGKDoHn0PLOwkl0Vtblm4=; Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1unvEN-00026f-73; Mon, 18 Aug 2025 08:28:39 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1unvEL-00026Y-Kg for linux-f2fs-devel@lists.sourceforge.net; Mon, 18 Aug 2025 08:28:37 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: From:References:To:Subject:Cc:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Or9ok1Sr6rUNuJj4WcUHHvV6v12gvIDrEfnwreqvPRU=; b=j4XasCZkrPqkCOhJ70W9gWXRw5 L5Yk5FKAin8L5RgcZV2MSRqkuvHxiYK505ZckwUNtpl4leb+0NiRYtvoRBjzQK3x7PtOJxyJdPE8O bWQJUt50cNc9fNsrvzCZ7mTZ6lM2ITKlCAKYQYXFr/KZxQCwLDpqv78oMpA2M+lx9q/o=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:References:To: Subject:Cc:MIME-Version:Date:Message-ID:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=Or9ok1Sr6rUNuJj4WcUHHvV6v12gvIDrEfnwreqvPRU=; b=dyKjT9fGR/09K3q6aQKb7GdxMc 9GeKwDwdkxz4VRJ2Xd4skWBGyIUAq7+k824NE3iLIRutafVZ+QNZy+B/cyUmZ3lLcVq1TwKsQwYYM u2kAQPjkL5gokmvMjffSfzjpI6Wi8PamBH81excTXUSmd+f6x6ofw5vXvgEKLHPSd1Fw=; Received: from dfw.source.kernel.org ([139.178.84.217]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1unvEL-0006Zp-5H for linux-f2fs-devel@lists.sourceforge.net; Mon, 18 Aug 2025 08:28:37 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id C2AFD5C5B3F; Mon, 18 Aug 2025 08:28:26 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 35468C4CEEB; Mon, 18 Aug 2025 08:28:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1755505706; bh=Icogg28ZLs91H1WXJDPU4qMKH1v2aWHOOdl1Ix8d2I4=; h=Date:Cc:Subject:To:References:From:In-Reply-To:From; b=eARKmdTcKCTa1s7Bc4eoFK3Y4UKf9bn5vlz8oM6nMwIa7fhi3m1prdiM/3X2/0k0r vgvJ9c6VkUmsCOMMnk5YUHl3ccV9E7U845apbUTitYEn81sAbGX7wLWuDV9e16EMiH 4MkgAap41+2V1cX9P0ewqoZVPdbNJr7KfT/iGPqrmL1LeRkE/4v8TEsTaNmgAga8rK zzgpcPijSardkKlCpUXzaSyD2ufYOeheNtX9AYSLEGIFbDqej3MUYtKLWYw+YNyu59 kVpt1CLJA7VN0waIuwD5LTOi4vBVpiZAg4hV3c9ZdN199W8ik4nwySDTvo0u/214/p tlTODkNSDEimw== Message-ID: <943041c7-5eb2-4ddc-b54e-192b61de4bf7@kernel.org> Date: Mon, 18 Aug 2025 16:28:22 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Hongbo Li , jaegeuk@kernel.org References: <20250818020939.3529802-1-chao@kernel.org> <20250818020939.3529802-2-chao@kernel.org> Content-Language: en-US In-Reply-To: X-Headers-End: 1unvEL-0006Zp-5H Subject: Re: [f2fs-dev] [PATCH 2/2] f2fs: fix to allow removing qf_name X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Chao Yu via Linux-f2fs-devel Reply-To: Chao Yu Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net T24gOC8xOC8yNSAxNjowNiwgSG9uZ2JvIExpIHdyb3RlOgo+IEhpIENoYW8sCj4gCj4gT24gMjAy NS84LzE4IDEwOjA5LCBDaGFvIFl1IHdyb3RlOgo+PiBUaGUgbW91bnQgYmVoYXZpb3IgY2hhbmdl ZCBhZnRlciBjb21taXQgZDE4NTM1MTMyNTIzICgiZjJmczogc2VwYXJhdGUgdGhlCj4+IG9wdGlv bnMgcGFyc2luZyBhbmQgb3B0aW9ucyBjaGVja2luZyIpLCBsZXQncyBmaXggaXQuCj4+Cj4+IFtT Y3JpcHRzXQo+PiBta2ZzLmYyZnMgLWYgL2Rldi92ZGIKPj4gbW91bnQgLXQgZjJmcyAtbyB1c3Jx dW90YSAvZGV2L3ZkYiAvbW50L2YyZnMKPj4gcXVvdGFjaGVjayAtdWMgL21udC9mMmZzCj4+IHVt b3VudCAvbW50L2YyZnMKPj4gbW91bnQgLXQgZjJmcyAtbyB1c3JqcXVvdGE9YXF1b3RhLnVzZXIs anFmbXQ9dmZzb2xkIC9kZXYvdmRiIC9tbnQvZjJmcwo+PiBtb3VudHxncmVwIGYyZnMKPj4gbW91 bnQgLXQgZjJmcyAtbyByZW1vdW50LHVzcmpxdW90YT0sanFmbXQ9dmZzb2xkIC9kZXYvdmRiIC9t bnQvZjJmcwo+PiBtb3VudHxncmVwIGYyZnMKPj4gZG1lc2cKPj4KPj4gW0JlZm9yZSBjb21taXRd Cj4+IG1vdW50IzE6IC4uLixxdW90YSxqcWZtdD12ZnNvbGQsdXNyanF1b3RhPWFxdW90YS51c2Vy LC4uLgo+PiBtb3VudCMyOiAuLi4scXVvdGEsanFmbXQ9dmZzb2xkLC4uLgo+PiBrbXNnOiBubyBv dXRwdXQKPj4KPj4gW0FmdGVyIGNvbW1pdF0KPj4gbW91bnQjMTogLi4uLHF1b3RhLGpxZm10PXZm c29sZCx1c3JqcXVvdGE9YXF1b3RhLnVzZXIsLi4uCj4+IG1vdW50IzI6IC4uLixxdW90YSxqcWZt dD12ZnNvbGQsdXNyanF1b3RhPWFxdW90YS51c2VyLC4uLgo+PiBrbXNnOiAidXNlciBxdW90YSBm aWxlIGFscmVhZHkgc3BlY2lmaWVkIgo+Pgo+PiBbQWZ0ZXIgcGF0Y2hdCj4+IG1vdW50IzE6IC4u LixxdW90YSxqcWZtdD12ZnNvbGQsdXNyanF1b3RhPWFxdW90YS51c2VyLC4uLgo+PiBtb3VudCMy OiAuLi4scXVvdGEsanFmbXQ9dmZzb2xkLC4uLgo+PiBrbXNnOiAicmVtb3ZlIHFmX25hbWUgYXF1 b3RhLnVzZXIiCj4+Cj4+IEZpeGVzOiBkMTg1MzUxMzI1MjMgKCJmMmZzOiBzZXBhcmF0ZSB0aGUg b3B0aW9ucyBwYXJzaW5nIGFuZCBvcHRpb25zIGNoZWNraW5nIikKPj4gQ2M6IEhvbmdibyBMaSA8 bGlob25nYm8yMkBodWF3ZWkuY29tPgo+PiBTaWduZWQtb2ZmLWJ5OiBDaGFvIFl1IDxjaGFvQGtl cm5lbC5vcmc+Cj4+IC0tLQo+PiDCoCBmcy9mMmZzL3N1cGVyLmMgfCA3ICsrKysrLS0KPj4gwqAg MSBmaWxlIGNoYW5nZWQsIDUgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKPj4KPj4gZGlm ZiAtLWdpdCBhL2ZzL2YyZnMvc3VwZXIuYyBiL2ZzL2YyZnMvc3VwZXIuYwo+PiBpbmRleCA0NjU2 MDRmZGM1ZGQuLjA3ZjZjOGNhYzA3YSAxMDA2NDQKPj4gLS0tIGEvZnMvZjJmcy9zdXBlci5jCj4+ ICsrKyBiL2ZzL2YyZnMvc3VwZXIuYwo+PiBAQCAtMTIxOSw4ICsxMjE5LDExIEBAIHN0YXRpYyBp bnQgZjJmc19jaGVja19xdW90YV9jb25zaXN0ZW5jeShzdHJ1Y3QgZnNfY29udGV4dCAqZmMsCj4+ IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgZ290byBlcnJfanF1b3RhX2NoYW5n ZTsKPj4gwqAgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgaWYgKG9sZF9xbmFtZSkgewo+PiAt wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIGlmIChuZXdfcW5hbWUgJiYKPj4gLcKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHN0cmNtcChvbGRfcW5hbWUsIG5ld19x bmFtZSkgPT0gMCkgewo+PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIGlmICghbmV3 X3FuYW1lKSB7Cj4gCj4gVGhhbmtzIGZvciBjYXRjaGluZyB0aGlzLiBEbyB3ZSBhbHNvIG5lZWQg dGhlIHBhdGNoIDEvMiA/IEl0IHNlZW1zIHRoaXMgcGF0Y2ggYWxzbyBzb2x2ZSB0aGUgc3l6Ym90 IHByb2JsZW1zLgoKSSBwcmVmZXIgdG8gc3BsaXQgaXQsIHNpbmNlIGl0J2QgYmV0dGVyIHRvIHVz ZSBvbmUgcGF0Y2ggdG8gcmVzb2x2ZSBvbmUKcHJvYmxlbS4gOikKClRoYW5rcywKCj4gCj4gVGhh bmtzLAo+IEhvbmdibwo+IAo+PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqAgZjJmc19pbmZvKHNiaSwgInJlbW92ZSBxZl9uYW1lICVzIiwKPj4gK8KgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIG9sZF9xbmFt ZSk7Cj4+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBjb250aW51ZTsK Pj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCB9IGVsc2UgaWYgKHN0cmNtcChvbGRf cW5hbWUsIG5ld19xbmFtZSkgPT0gMCkgewo+PiDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqAgY3R4LT5xbmFtZV9tYXNrICY9IH4oMSA8PCBpKTsKPj4gwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIGNvbnRpbnVlOwo+PiDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIH0KCgoKX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX18KTGludXgtZjJmcy1kZXZlbCBtYWlsaW5nIGxpc3QKTGludXgt ZjJmcy1kZXZlbEBsaXN0cy5zb3VyY2Vmb3JnZS5uZXQKaHR0cHM6Ly9saXN0cy5zb3VyY2Vmb3Jn ZS5uZXQvbGlzdHMvbGlzdGluZm8vbGludXgtZjJmcy1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D88BA2FFDEC for ; Mon, 18 Aug 2025 08:28:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755505706; cv=none; b=i6vXV5/NxQ4mGKLg/NZClL0MLgDo+cpjVHxkBa4+CHRPT6gqKAIbaHITSlUkxgTBAnNuryZeWRF5r7K1G08Rx3FOkFDH0Es4V3PDQycDnazmdJfYVDSOR73vtWiuaigPFZAKsSJAPxdRP84ZAWAwfV1fmaomv+FY130XAkNywlM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755505706; c=relaxed/simple; bh=Icogg28ZLs91H1WXJDPU4qMKH1v2aWHOOdl1Ix8d2I4=; h=Message-ID:Date:MIME-Version:Cc:Subject:To:References:From: In-Reply-To:Content-Type; b=TgufsXFhKJ9ouXvEbRlQOYuTPf5lWWp68E+lE96jQky00rZk/paPjncZq1izm44YBmXbiYUGBrTlmJbF/a9qrmXX9//qLnlWT+0WC2Cq6O2Cwxi0NX5+EZ5mgsjmfdYVqGwSloTFY2CBRiZJUa7GVlKfHH8xAFFgHOYAhezsE2E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=eARKmdTc; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="eARKmdTc" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 35468C4CEEB; Mon, 18 Aug 2025 08:28:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1755505706; bh=Icogg28ZLs91H1WXJDPU4qMKH1v2aWHOOdl1Ix8d2I4=; h=Date:Cc:Subject:To:References:From:In-Reply-To:From; b=eARKmdTcKCTa1s7Bc4eoFK3Y4UKf9bn5vlz8oM6nMwIa7fhi3m1prdiM/3X2/0k0r vgvJ9c6VkUmsCOMMnk5YUHl3ccV9E7U845apbUTitYEn81sAbGX7wLWuDV9e16EMiH 4MkgAap41+2V1cX9P0ewqoZVPdbNJr7KfT/iGPqrmL1LeRkE/4v8TEsTaNmgAga8rK zzgpcPijSardkKlCpUXzaSyD2ufYOeheNtX9AYSLEGIFbDqej3MUYtKLWYw+YNyu59 kVpt1CLJA7VN0waIuwD5LTOi4vBVpiZAg4hV3c9ZdN199W8ik4nwySDTvo0u/214/p tlTODkNSDEimw== Message-ID: <943041c7-5eb2-4ddc-b54e-192b61de4bf7@kernel.org> Date: Mon, 18 Aug 2025 16:28:22 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: chao@kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] f2fs: fix to allow removing qf_name To: Hongbo Li , jaegeuk@kernel.org References: <20250818020939.3529802-1-chao@kernel.org> <20250818020939.3529802-2-chao@kernel.org> Content-Language: en-US From: Chao Yu In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 8/18/25 16:06, Hongbo Li wrote: > Hi Chao, > > On 2025/8/18 10:09, Chao Yu wrote: >> The mount behavior changed after commit d18535132523 ("f2fs: separate the >> options parsing and options checking"), let's fix it. >> >> [Scripts] >> mkfs.f2fs -f /dev/vdb >> mount -t f2fs -o usrquota /dev/vdb /mnt/f2fs >> quotacheck -uc /mnt/f2fs >> umount /mnt/f2fs >> mount -t f2fs -o usrjquota=aquota.user,jqfmt=vfsold /dev/vdb /mnt/f2fs >> mount|grep f2fs >> mount -t f2fs -o remount,usrjquota=,jqfmt=vfsold /dev/vdb /mnt/f2fs >> mount|grep f2fs >> dmesg >> >> [Before commit] >> mount#1: ...,quota,jqfmt=vfsold,usrjquota=aquota.user,... >> mount#2: ...,quota,jqfmt=vfsold,... >> kmsg: no output >> >> [After commit] >> mount#1: ...,quota,jqfmt=vfsold,usrjquota=aquota.user,... >> mount#2: ...,quota,jqfmt=vfsold,usrjquota=aquota.user,... >> kmsg: "user quota file already specified" >> >> [After patch] >> mount#1: ...,quota,jqfmt=vfsold,usrjquota=aquota.user,... >> mount#2: ...,quota,jqfmt=vfsold,... >> kmsg: "remove qf_name aquota.user" >> >> Fixes: d18535132523 ("f2fs: separate the options parsing and options checking") >> Cc: Hongbo Li >> Signed-off-by: Chao Yu >> --- >>   fs/f2fs/super.c | 7 +++++-- >>   1 file changed, 5 insertions(+), 2 deletions(-) >> >> diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c >> index 465604fdc5dd..07f6c8cac07a 100644 >> --- a/fs/f2fs/super.c >> +++ b/fs/f2fs/super.c >> @@ -1219,8 +1219,11 @@ static int f2fs_check_quota_consistency(struct fs_context *fc, >>                   goto err_jquota_change; >>                 if (old_qname) { >> -                if (new_qname && >> -                    strcmp(old_qname, new_qname) == 0) { >> +                if (!new_qname) { > > Thanks for catching this. Do we also need the patch 1/2 ? It seems this patch also solve the syzbot problems. I prefer to split it, since it'd better to use one patch to resolve one problem. :) Thanks, > > Thanks, > Hongbo > >> +                    f2fs_info(sbi, "remove qf_name %s", >> +                                old_qname); >> +                    continue; >> +                } else if (strcmp(old_qname, new_qname) == 0) { >>                       ctx->qname_mask &= ~(1 << i); >>                       continue; >>                   }