From: Jan Beulich <jbeulich@suse.com>
To: Oleksii Kurochko <oleksii.kurochko@gmail.com>
Cc: "Alistair Francis" <alistair.francis@wdc.com>,
"Bob Eshleman" <bobbyeshleman@gmail.com>,
"Connor Davis" <connojdavis@gmail.com>,
"Andrew Cooper" <andrew.cooper3@citrix.com>,
"Anthony PERARD" <anthony.perard@vates.tech>,
"Michal Orzel" <michal.orzel@amd.com>,
"Julien Grall" <julien@xen.org>,
"Roger Pau Monné" <roger.pau@citrix.com>,
"Stefano Stabellini" <sstabellini@kernel.org>,
xen-devel@lists.xenproject.org
Subject: Re: [PATCH v2 1/7] xen/riscv: update layout table in config.h
Date: Mon, 16 Dec 2024 12:09:48 +0100 [thread overview]
Message-ID: <943d356f-e1cc-4e42-94c5-fa6d7fc157a3@suse.com> (raw)
In-Reply-To: <c305ae5003da25d7ea4d4aa5602c4b22f83df4a8.1733937787.git.oleksii.kurochko@gmail.com>
On 11.12.2024 18:27, Oleksii Kurochko wrote:
> Make all upper bounds (end addresses) for areas inclusive to align
> with the corresponding definitions.
>
> Signed-off-by: Oleksii Kurochko <oleksii.kurochko@gmail.com>
I expected this would be straightforward to ack, but ...
> --- a/xen/arch/riscv/include/asm/config.h
> +++ b/xen/arch/riscv/include/asm/config.h
> @@ -41,17 +41,17 @@
> * Start addr | End addr | Slot | area description
> * ============================================================================
> * ..... L2 511 Unused
> - * 0xffffffffc0a00000 0xffffffffc0c00000 L2 511 Fixmap
> + * 0xffffffffc0a00000 0xffffffffc0bfffff L2 511 Fixmap
> * ..... ( 2 MB gap )
> - * 0xffffffffc0400000 0xffffffffc0800000 L2 511 FDT
> + * 0xffffffffc0400000 0xffffffffc07fffff L2 511 FDT
> * ..... ( 2 MB gap )
> - * 0xffffffffc0000000 0xffffffffc0200000 L2 511 Xen
> + * 0xffffffffc0000000 0xffffffffc01fffff L2 511 Xen
> * ..... L2 510 Unused
> - * 0x3200000000 0x7f40000000 L2 200-509 Direct map
> + * 0x3200000000 0x7f7fffffff L2 200-509 Direct map
... this isn't just an adjustment by -1. If the old table entry was wrong,
the description wants to say so. Else an adjustment to the number is needed
here.
Jan
next prev parent reply other threads:[~2024-12-16 11:10 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-11 17:27 [PATCH v2 0/7] Unflattening and relocation of host device tree Oleksii Kurochko
2024-12-11 17:27 ` [PATCH v2 1/7] xen/riscv: update layout table in config.h Oleksii Kurochko
2024-12-16 11:09 ` Jan Beulich [this message]
2024-12-11 17:27 ` [PATCH v2 2/7] xen/riscv: add destroy_xen_mappings() to remove mappings in Xen page tables Oleksii Kurochko
2024-12-12 11:43 ` Jan Beulich
2024-12-13 12:54 ` Oleksii Kurochko
2024-12-11 17:27 ` [PATCH v2 3/7] xen/riscv: reorder includes in asm/page.h alphabetically Oleksii Kurochko
2024-12-11 17:27 ` [PATCH v2 4/7] xen/riscv: add {set,clear}_fixmap() functions for managing fixmap entries Oleksii Kurochko
2024-12-12 11:48 ` Jan Beulich
2024-12-11 17:27 ` [PATCH v2 5/7] xen/riscv: implement data and instruction cache operations Oleksii Kurochko
2024-12-16 14:23 ` Jan Beulich
2024-12-16 17:40 ` Oleksii Kurochko
2024-12-17 8:32 ` Jan Beulich
2024-12-17 10:37 ` Oleksii Kurochko
2024-12-17 11:08 ` Jan Beulich
2024-12-11 17:27 ` [PATCH v2 6/7] xen/riscv: implement prereq for DTB relocation Oleksii Kurochko
2024-12-16 14:30 ` Jan Beulich
2024-12-11 17:27 ` [PATCH v2 7/7] xen/riscv: relocating and unflattening host device tree Oleksii Kurochko
2024-12-16 14:31 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=943d356f-e1cc-4e42-94c5-fa6d7fc157a3@suse.com \
--to=jbeulich@suse.com \
--cc=alistair.francis@wdc.com \
--cc=andrew.cooper3@citrix.com \
--cc=anthony.perard@vates.tech \
--cc=bobbyeshleman@gmail.com \
--cc=connojdavis@gmail.com \
--cc=julien@xen.org \
--cc=michal.orzel@amd.com \
--cc=oleksii.kurochko@gmail.com \
--cc=roger.pau@citrix.com \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.