From: David Howells <dhowells@redhat.com>
To: Mimi Zohar <zohar@linux.ibm.com>
Cc: dhowells@redhat.com, Randy Dunlap <rdunlap@infradead.org>,
Stephen Rothwell <sfr@canb.auug.org.au>,
Linux Next Mailing List <linux-next@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-integrity@vger.kernel.org,
Dmitry Kasatkin <dmitry.kasatkin@gmail.com>,
linux-security-module <linux-security-module@vger.kernel.org>
Subject: Re: linux-next: Tree for Jun 26 (security/integrity/ima/)
Date: Thu, 27 Jun 2019 14:29:05 +0100 [thread overview]
Message-ID: <9446.1561642145@warthog.procyon.org.uk> (raw)
In-Reply-To: <1561640534.4101.124.camel@linux.ibm.com>
Mimi Zohar <zohar@linux.ibm.com> wrote:
> > CC security/integrity/ima/ima_fs.o
> > In file included from ../security/integrity/ima/ima.h:25:0,
> > from ../security/integrity/ima/ima_fs.c:26:
> > ../security/integrity/ima/../integrity.h:170:18: warning: ‘struct key_acl’ declared inside parameter list [enabled by default]
> > struct key_acl *acl)
> > ^
> > ../security/integrity/ima/../integrity.h:170:18: warning: its scope is only this definition or declaration, which is probably not what you want [enabled by default]
>
> David, CONFIG_INTEGRITY_SIGNATURE is dependent on KEYS being enabled,
> but the stub functions are not. There's now a dependency on
> key_acl().
I added a forward declaration for struct key_acl into
security/integrity/integrity.h as you can see here:
https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git/diff/security/integrity/integrity.h?h=keys-acl&id=75ce113a1d56880e5abd37fa664ea9af399d2bcd
which might not have made it into linux-next before you used it.
David
next prev parent reply other threads:[~2019-06-27 13:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-26 13:16 linux-next: Tree for Jun 26 Stephen Rothwell
2019-06-26 16:01 ` linux-next: Tree for Jun 26 (task_struct: cached_requested_key) Randy Dunlap
2019-06-26 19:59 ` David Howells
2019-06-26 18:35 ` linux-next: Tree for Jun 26 (security/integrity/ima/) Randy Dunlap
2019-06-27 13:02 ` Mimi Zohar
2019-06-27 13:29 ` David Howells [this message]
2019-06-27 15:08 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9446.1561642145@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=dmitry.kasatkin@gmail.com \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=sfr@canb.auug.org.au \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.