From: Lukasz Luba <lukasz.luba@arm.com>
To: gregkh@linuxfoundation.org
Cc: ye.zhang@rock-chips.com, d-gole@ti.com,
rafael.j.wysocki@intel.com, stable@vger.kernel.org
Subject: Re: FAILED: patch "[PATCH] thermal: devfreq_cooling: Fix perf state when calculate dfc" failed to apply to 5.15-stable tree
Date: Tue, 2 Apr 2024 09:29:56 +0100 [thread overview]
Message-ID: <945689b3-445d-4915-857e-dda84cc8352c@arm.com> (raw)
In-Reply-To: <2024033050-imitation-unmixed-ef53@gregkh>
Hi Greg,
On 3/30/24 09:46, gregkh@linuxfoundation.org wrote:
>
> The patch below does not apply to the 5.15-stable tree.
> If someone wants it applied there, or to any other stable or longterm
> tree, then please email the backport, including the original git commit
> id to <stable@vger.kernel.org>.
Would you like my help? I can create a backport to v5.15.y and send
to the list.
Regards,
Lukasz
>
> To reproduce the conflict and resubmit, you may use the following commands:
>
> git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-5.15.y
> git checkout FETCH_HEAD
> git cherry-pick -x a26de34b3c77ae3a969654d94be49e433c947e3b
> # <resolve conflicts, build, test, etc.>
> git commit -s
> git send-email --to '<stable@vger.kernel.org>' --in-reply-to '2024033050-imitation-unmixed-ef53@gregkh' --subject-prefix 'PATCH 5.15.y' HEAD^..
>
> Possible dependencies:
>
>
>
> thanks,
>
> greg k-h
>
> ------------------ original commit in Linus's tree ------------------
>
> From a26de34b3c77ae3a969654d94be49e433c947e3b Mon Sep 17 00:00:00 2001
> From: Ye Zhang <ye.zhang@rock-chips.com>
> Date: Thu, 21 Mar 2024 18:21:00 +0800
> Subject: [PATCH] thermal: devfreq_cooling: Fix perf state when calculate dfc
> res_util
> MIME-Version: 1.0
> Content-Type: text/plain; charset=UTF-8
> Content-Transfer-Encoding: 8bit
>
> The issue occurs when the devfreq cooling device uses the EM power model
> and the get_real_power() callback is provided by the driver.
>
> The EM power table is sorted ascending,can't index the table by cooling
> device state,so convert cooling state to performance state by
> dfc->max_state - dfc->capped_state.
>
> Fixes: 615510fe13bd ("thermal: devfreq_cooling: remove old power model and use EM")
> Cc: 5.11+ <stable@vger.kernel.org> # 5.11+
> Signed-off-by: Ye Zhang <ye.zhang@rock-chips.com>
> Reviewed-by: Dhruva Gole <d-gole@ti.com>
> Reviewed-by: Lukasz Luba <lukasz.luba@arm.com>
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
>
> diff --git a/drivers/thermal/devfreq_cooling.c b/drivers/thermal/devfreq_cooling.c
> index 50dec24e967a..8fd7cf1932cd 100644
> --- a/drivers/thermal/devfreq_cooling.c
> +++ b/drivers/thermal/devfreq_cooling.c
> @@ -214,7 +214,7 @@ static int devfreq_cooling_get_requested_power(struct thermal_cooling_device *cd
>
> res = dfc->power_ops->get_real_power(df, power, freq, voltage);
> if (!res) {
> - state = dfc->capped_state;
> + state = dfc->max_state - dfc->capped_state;
>
> /* Convert EM power into milli-Watts first */
> rcu_read_lock();
>
next prev parent reply other threads:[~2024-04-02 8:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-30 9:46 FAILED: patch "[PATCH] thermal: devfreq_cooling: Fix perf state when calculate dfc" failed to apply to 5.15-stable tree gregkh
2024-04-02 8:29 ` Lukasz Luba [this message]
2024-04-02 12:18 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=945689b3-445d-4915-857e-dda84cc8352c@arm.com \
--to=lukasz.luba@arm.com \
--cc=d-gole@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=rafael.j.wysocki@intel.com \
--cc=stable@vger.kernel.org \
--cc=ye.zhang@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.