Re: [PATCH] media: uvcvideo: drop useless assignment in uvc_parse_format()

[Sergey Shtylyov <s.shtylyov@auroraos.dev>]

On 9/29/26 12:16 PM, Hans de Goede wrote:

[...]

>>>> Close to the end of uvc_parse_format(), the parameter buflen is decremented
>>>> (again) but that statement seems pointless as buflen isn't used afterwards.
>>>> Drop the useless assignment (gcc doesn't generate any code for it anyways).
>>>
>>> The patch is correct, although I do not see a great benefit in
>>> removing it. As you say, the compiler will remove it anyway. If we
>>> modify the function to add logging or continue parsing the left over
>>> buffer, it is going to come back to haunt us....
>>>
>>> I leave it to Laurent or HansG to decide if they want to merge it.
>>
>> I'd rather keep the buflen update in place for the reasons explained by
>> Ricardo.
>>
>> /me wishes for std::span<> in C
> 
> Ack, I've dropped this patch from patchwork.

   OK, but why "Not Applicable" and not "Rejected"? :-)

> Regards,
> 
> Hans
[...]

MBR, Sergey