From: Thomas Monjalon <thomas@monjalon.net>
To: Jianbo Liu <jianbo.liu@linaro.org>,
Jerin Jacob <jerin.jacob@caviumnetworks.com>
Cc: dev@dpdk.org, Jan Viktorin <viktorin@rehivetech.com>
Subject: Re: [PATCH] eal/armv7: emulate vaddvq u16 variant
Date: Mon, 10 Jul 2017 09:32:27 +0200 [thread overview]
Message-ID: <9464025.1hzSdOLmaj@xps> (raw)
In-Reply-To: <1577823.H7hr8NYHfM@xps>
10/07/2017 09:28, Thomas Monjalon:
> 10/07/2017 05:51, Jianbo Liu:
> > On 9 July 2017 at 01:08, Thomas Monjalon <thomas@monjalon.net> wrote:
> > > 07/07/2017 18:26, Jerin Jacob:
> > >> vaddvq_u16() is not available for armv7.
> > >> Emulate the vaddvq_u16() using armv7 NEON intrinsics.
> > >
> > > After implementing this function, another missing function appears:
> > >
> > > lib/librte_sched/rte_sched.c:1747:7: error:
> > > implicit declaration of function ‘vminvq_u32’
> >
> > But sched_vector is disabled in defconfig_arm-armv7a-linuxapp-gcc:
> > CONFIG_RTE_SCHED_VECTOR=n
>
> Yes, I really need to fix test-build.sh which is enabling SCHED_VECTOR.
>
> So with this patch, the error remains:
> examples/l3fwd/l3fwd_neon.h:113:6: error:
> implicit declaration of function ‘vaddvq_u16’
> v = vaddvq_u16(dp1);
> ^~~~~~~~~~
>
> We need to include rte_vect.h.
Forget it, I mixed up my branches :/
So the patch is OK, compilation is fixed.
next prev parent reply other threads:[~2017-07-10 7:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-07 16:26 [PATCH] eal/armv7: emulate vaddvq u16 variant Jerin Jacob
2017-07-08 17:08 ` Thomas Monjalon
2017-07-10 3:51 ` Jianbo Liu
2017-07-10 7:28 ` Thomas Monjalon
2017-07-10 7:32 ` Thomas Monjalon [this message]
2017-07-10 3:34 ` Jianbo Liu
2017-07-10 7:35 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9464025.1hzSdOLmaj@xps \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=jerin.jacob@caviumnetworks.com \
--cc=jianbo.liu@linaro.org \
--cc=viktorin@rehivetech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.