From: Thomas Monjalon <thomas@monjalon.net>
To: "Min Hu (Connor)" <humin29@huawei.com>
Cc: dev@dpdk.org, ferruh.yigit@intel.com, erik.g.carrillo@intel.com,
rsanford@akamai.com
Subject: Re: [dpdk-dev] [PATCH v2] test/timer: fix memzone reserve failure check
Date: Mon, 10 May 2021 16:13:35 +0200 [thread overview]
Message-ID: <9479806.yrmItbF8Ka@thomas> (raw)
In-Reply-To: <1620090469-30484-1-git-send-email-humin29@huawei.com>
04/05/2021 03:07, Min Hu (Connor):
> Segmentation fault may occur without checking if memzone
> reserves succeed or not.
The sentence is confusing. Please try to make it more logical.
Something like "It was potentially dereferencing a null pointer.
It is fixed by checking the pointer before dereferencing."
>
> This patch fixed it.
>
> Fixes: 50247fe03fe0 ("test/timer: exercise new APIs in secondary process")
> Cc: stable@dpdk.org
>
> Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
[...]
> - test_info = mz->addr;
> - TEST_ASSERT_NOT_NULL(test_info, "Couldn't allocate memory for "
> + TEST_ASSERT_NOT_NULL(mz, "Couldn't allocate memory for "
> "test data");
Error messages should not be split. I makes search difficult.
Please fix it in this patch while touching this line.
next prev parent reply other threads:[~2021-05-10 14:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-22 9:18 [dpdk-dev] [PATCH] test/timer: fix memzone reserve failure check Min Hu (Connor)
2021-05-01 20:00 ` Carrillo, Erik G
2021-05-04 1:08 ` Min Hu (Connor)
2021-05-04 1:07 ` [dpdk-dev] [PATCH v2] " Min Hu (Connor)
2021-05-04 1:18 ` Carrillo, Erik G
2021-05-10 14:13 ` Thomas Monjalon [this message]
2021-05-11 0:53 ` Min Hu (Connor)
2021-05-11 0:53 ` [dpdk-dev] [PATCH v3] " Min Hu (Connor)
2021-05-12 14:36 ` Thomas Monjalon
2021-05-13 0:19 ` Min Hu (Connor)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9479806.yrmItbF8Ka@thomas \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=erik.g.carrillo@intel.com \
--cc=ferruh.yigit@intel.com \
--cc=humin29@huawei.com \
--cc=rsanford@akamai.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.