From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6E9A5C28B30 for ; Thu, 20 Mar 2025 07:32:53 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.921338.1325194 (Exim 4.92) (envelope-from ) id 1tvAON-0001BE-CB; Thu, 20 Mar 2025 07:32:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 921338.1325194; Thu, 20 Mar 2025 07:32:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1tvAON-0001B7-9Y; Thu, 20 Mar 2025 07:32:39 +0000 Received: by outflank-mailman (input) for mailman id 921338; Thu, 20 Mar 2025 07:32:38 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1tvAOM-0001B1-09 for xen-devel@lists.xenproject.org; Thu, 20 Mar 2025 07:32:38 +0000 Received: from mail-wr1-x434.google.com (mail-wr1-x434.google.com [2a00:1450:4864:20::434]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 7f063e0d-055d-11f0-9ea0-5ba50f476ded; Thu, 20 Mar 2025 08:32:37 +0100 (CET) Received: by mail-wr1-x434.google.com with SMTP id ffacd0b85a97d-390cf7458f5so291874f8f.2 for ; Thu, 20 Mar 2025 00:32:37 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-395c7df3419sm22546668f8f.9.2025.03.20.00.32.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 20 Mar 2025 00:32:36 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7f063e0d-055d-11f0-9ea0-5ba50f476ded DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1742455956; x=1743060756; darn=lists.xenproject.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=0PrpLYKtG2eN6Fux3I0VfD6QJYz5CFN2HjNxawIJ8v4=; b=T4q97mkAVVQL4DHxkYRQlAyY8lK1CAVt5Cvp2ZZKIOdd3BXgk3u8Q0rl1VcNwPbrWh RLHJ9/dyC5lE2rsWsqiGhlT4/7oK6NwnOZu1AzHjpB+WEWOVHbfLbqsYCcW9jX3wTp4L 2XR5JFJBLoVrBKbxAde3R/KjRA4L+LZm49Cy5xxrAnQbG8EKEWOEdXQmtrnVk2c+EwIU LJnhpI1wGrj47k9Smce0mS4SkL4+SYaTUW5/zAqRsasNzJ3KxBsHfkoiTGoXqFU2R7tH OFshm/u5MwZGhiBNiyzcFVeBNEG23OAoQMNhN+4oOKUCnErLaIJS+Ioyw3UEU0VXEgQ+ HOkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742455956; x=1743060756; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=0PrpLYKtG2eN6Fux3I0VfD6QJYz5CFN2HjNxawIJ8v4=; b=hLv9l//REgS9Ky2ZDefa/npL6Bgz4TyA4FzHHSivMKptWt1iHnnKHpZ2VwCc+37l2q TgjMbP2GZYWvGI7oQEx5xmIIbu3A7C5uG9pU3BxyqF3ZD82yZd1NN4mQZtJyzQ7X4xky KITat1zAumqiSCeXQQ38iIhJX2Q3VkjTg7blNtjb7vxulAf97Jgluuwb/c1B8vThD0MX LRy3QOvWbHqLBD7bg3r4Qxne14tM4D3l4tPkLQKElKJ3eD5oBsn2rzKFs/mME9KDO/t2 uoCfLj+HQPUiEs5/0xe/vQwovX0giPzNjEOy3mu3YCc7buFCYGGqDywlu8TlpbifO67y quAg== X-Forwarded-Encrypted: i=1; AJvYcCXUGDH+guOdfkO+zGKbY+auaSZ1fO9XujP7ftEu+0NtSwdxIq+k4BaAUakzEi31vi1njZqxamOtvtg=@lists.xenproject.org X-Gm-Message-State: AOJu0YxMnau3PBQWdp8O0HmtB/BHSOb/TB2rJnEu8YVdk8rqEvkjehH8 hN4yla4OvJJh3mwumNaJzDIa0DsMfWyMg/8imeBexNx8Omz2q9+xaS/qsncpUg== X-Gm-Gg: ASbGncui3zLKWVqgQzcKzNiMcmxwr0aJPtEUksqF/rFfyB4J1H+mLaVG5JDzX4PS2cm ckL7kiRaJCEes4BSDUqmEjGI/DSlB4PdLmPoGuOmyZq4hfBosns1/13En9I5rZ7vJXNm+KDhC+Y PhG/0EyLdF0U5+FiuiFb6fF9bAOjAMdOAu3VtUf64hxrNm4fKxkm2gu4P7SSUW7gc/AdTkJxuQU lKvbQs4jBF0DwIF9Yn3+r0IqOUJVyrswecdP04Sby1f9UorTuw4C/5M8hB4qzY0bN59sh6n6XdR f9PE5Llkv+gC8f1q5HY5aIQ1/e8f1W67IMQ8N053aCJWJu2b74CdqZEjqUV6oCluPNKghfXsia+ 6UgTG3Cu7xz0ZNIzs6a3e7X43pMxTyQ== X-Google-Smtp-Source: AGHT+IGhWDutLodgpgY51XxhYzp2g+zVBRqkXJCnrrEeuC88U6XQaN9OJD/81i5q7lD/H988k32v0Q== X-Received: by 2002:a05:6000:1565:b0:391:2c67:798f with SMTP id ffacd0b85a97d-39973afad05mr5699618f8f.41.1742455956459; Thu, 20 Mar 2025 00:32:36 -0700 (PDT) Message-ID: <94865aea-043b-4f52-adb8-d2d78dba293b@suse.com> Date: Thu, 20 Mar 2025 08:32:35 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 6/7] xen: introduce Kconfig ARCH_PAGING_MEMPOOL To: Oleksii Kurochko , Luca Fancellu Cc: Penny Zheng , Stefano Stabellini , Julien Grall , Bertrand Marquis , Michal Orzel , Volodymyr Babchuk , Andrew Cooper , Anthony PERARD , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Alistair Francis , Bob Eshleman , Connor Davis , Wei Chen , xen-devel@lists.xenproject.org References: <20250317200727.798696-1-luca.fancellu@arm.com> <20250317200727.798696-7-luca.fancellu@arm.com> <85ba02a9-f9f9-4141-85be-a9a2d431e450@gmail.com> <26583ecf-4057-46b1-8f87-f4589d7bec17@suse.com> <136cf1c5-d1e5-471d-b560-51632b444e41@gmail.com> Content-Language: en-US From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <136cf1c5-d1e5-471d-b560-51632b444e41@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 19.03.2025 17:31, Oleksii Kurochko wrote: > > On 3/19/25 12:35 PM, Jan Beulich wrote: >> On 18.03.2025 14:05, Oleksii Kurochko wrote: >>> On 3/17/25 9:07 PM, Luca Fancellu wrote: >>>> From: Penny Zheng >>>> >>>> ARM MPU system doesn't need to use paging memory pool, as MPU memory >>>> mapping table at most takes only one 4KB page, which is enough to >>>> manage the maximum 255 MPU memory regions, for all EL2 stage 1 >>>> translation and EL1 stage 2 translation. >>>> >>>> Introduce ARCH_PAGING_MEMPOOL Kconfig common symbol, selected for Arm >>>> MMU systems, x86 and RISC-V. >>>> >>>> Wrap the code inside 'construct_domU' that deal with p2m paging >>>> allocation in a new function 'domain_p2m_set_allocation', protected >>>> by ARCH_PAGING_MEMPOOL, this is done in this way to prevent polluting >>>> the former function with #ifdefs and improve readability >>>> >>>> Introduce arch_{get,set}_paging_mempool_size stubs for architecture >>>> with !ARCH_PAGING_MEMPOOL. >>>> >>>> Remove 'struct paging_domain' from Arm 'struct arch_domain' when the >>>> field is not required. >>>> >>>> Signed-off-by: Penny Zheng >>>> Signed-off-by: Wei Chen >>>> Signed-off-by: Luca Fancellu >>>> --- >>>> v3 changes: >>>> - Introduced ARCH_PAGING_MEMPOOL instead of HAS_PAGING_MEMPOOL >>>> v2 changes: >>>> - make Kconfig HAS_PAGING_MEMPOOL common >>>> - protect also "xen,domain-p2m-mem-mb" reading with HAS_PAGING_MEMPOOL >>>> - do not define p2m_teardown{_allocation} in this patch >>>> - change commit message >>>> --- >>>> xen/arch/arm/Kconfig | 1 + >>>> xen/arch/arm/dom0less-build.c | 74 ++++++++++++++++++++----------- >>>> xen/arch/arm/include/asm/domain.h | 2 + >>>> xen/arch/riscv/Kconfig | 1 + >>>> xen/arch/x86/Kconfig | 1 + >>>> xen/common/Kconfig | 3 ++ >>>> xen/include/xen/domain.h | 17 +++++++ >>>> 7 files changed, 73 insertions(+), 26 deletions(-) >>> For RISC-V: >>> Reviewed-by: Oleksii Kurochko >> Mind me asking then why RISC-V needs this at this point? The stubs surely >> were added to address some build issue, not because they are actively >> meaningful? > > Only because we have stubs and not to have redefinition compilation > error. And, yes, they are not actively meaningful now, at least. I am > okay with not enabling of this config for RISC-V but then seems to me we > have to drop stubs in riscv/stubs.c. ~ Oleksii Well, I don't think it's "have to", but I agree that dropping them would make sense then (and be desirable). Jan