From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3E9F2C282EC for ; Thu, 6 Mar 2025 13:23:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=v/XrhxrzkyQZXJfvMWSUH1AqsqEsdJ0k+ihu3RUjd+Y=; b=d0sDyamAHyjoF9 tUVJI/sEASFCFgdiWb1rmvwk1V59Zs9ktNlK8Y4HOs3/Fok4Z3kRmvz7ujxyC7T40I9ivFKUMX+KY xQfXxvICArSbTze6iLZTOGiQCaP5+M+X8qSqNbfr2yXSvKiAg0rTLPlQFAvyYwn/i6fLB8bevFtN8 bpW3zHHzoyjD/DvEIiDShXcMfu3vR8FKJ0tQAP+rVGNejnARVs9gPN8MhnGWpcjxc7d98c4ipbHAj HfKLadT8A5G5XNZDJF513NnPCH1lbmuNmtir+8MATklZRzeJxiAS+reb2Ordy2TSgy59sZqAitk8F zkfGsFOwcCjprrgnoZSg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tqBC1-0000000B2db-3pXi; Thu, 06 Mar 2025 13:23:19 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tqAwE-0000000B07P-2Yjv for linux-rockchip@bombadil.infradead.org; Thu, 06 Mar 2025 13:06:58 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Type:Content-Transfer-Encoding :MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Sender:Reply-To:Content-ID:Content-Description; bh=mfBuDbSuVwW4tPY5y3ejNrFbP51Lhqr440UyYLTygs4=; b=Hp0hvMl18ufnFZv6o8VqW08eLQ fVF28vrCef/FK3ctlGLUdy1RFQ3b5tjZYCNdd53EEgFYLCCx4ANsmCGdSc6qwDerA0L1Ybrlyz+Nm xs/S3fXG6Y3H3dwVc4zzDu0le4sD0f/uAg7LMJc73vedxmdZ5fI/p9+xc4RVEKph7a8KMX1syOUIP gG0tt4dbEae5VlEaEhGxkFniviLNUIKMiXrwFg/nZJlhiVTSWn2vcnsKuJthKgc5Qn3F5F0YJS/oj ty6+lxBwX+6t7O+vufrZ8TFDWDhgbMj8zIn7eSt5rfq6Kutw5wYxTihHbwJSqek0rjYuonhQo82d6 9cX9lHUA==; Received: from gloria.sntech.de ([185.11.138.130]) by desiato.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tqAwB-000000015MW-3UVD for linux-rockchip@lists.infradead.org; Thu, 06 Mar 2025 13:06:57 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sntech.de; s=gloria202408; h=Content-Type:Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=mfBuDbSuVwW4tPY5y3ejNrFbP51Lhqr440UyYLTygs4=; b=HW4ePAFdm0EXJK81MA9j0l1Ngf N3QPXF+BbJlJPc0SOGcLA1ibPPtby/R5nL4YwQC/BR0BgoiuSNlTA2Wnl5QT20X/yqs0ydptuWQms /FB8hhqJhXACRIer/jCk/qeyBtlsjzCB3R7/2OoH1WkR+Ctpp1sOFoFx/8dcCuY2+0v27H+LN6wqA VSqBTpJ3Noa58ge6W0gtqOyW39+UNE6CG19l1hASFfHGtOlwrWYfKGobuQIfyFU1GuAa1jjLIC4/l MjxDgwLGbSjM+hKtV9Pn+8TYKHGLC4AEjZF2EKiX7nqK5mQbgm1k20cfFD3QdcGmKinmPOe+WLv+R 6XWmSdHQ==; Received: from i53875a38.versanet.de ([83.135.90.56] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tqAvx-00039x-W9; Thu, 06 Mar 2025 14:06:42 +0100 From: Heiko =?UTF-8?B?U3TDvGJuZXI=?= To: Shreeya Patel , Mauro Carvalho Chehab , Hans Verkuil , Rob Herring , Krzysztof Kozlowski , Conor Dooley , jose.abreu@synopsys.com, nelson.costa@synopsys.com, shawn.wen@rock-chips.com, nicolas.dufresne@collabora.com, Sebastian Reichel , Dmitry Osipenko Cc: kernel@collabora.com, linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, Tim Surber , Christophe JAILLET , Diederik de Haas Subject: Re: [PATCH v14 1/3] arm64: dts: rockchip: Add device tree support for HDMI RX Controller Date: Thu, 06 Mar 2025 14:06:40 +0100 Message-ID: <9489391.T7Z3S40VBb@diego> In-Reply-To: <20250306072842.287142-2-dmitry.osipenko@collabora.com> References: <20250306072842.287142-1-dmitry.osipenko@collabora.com> <20250306072842.287142-2-dmitry.osipenko@collabora.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250306_130656_086887_02533F8B X-CRM114-Status: GOOD ( 15.85 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org SGkgRG1pdHJ5LAoKQW0gRG9ubmVyc3RhZywgNi4gTcOkcnogMjAyNSwgMDg6Mjg6NDAgTUVaIHNj aHJpZWIgRG1pdHJ5IE9zaXBlbmtvOgo+IEZyb206IFNocmVleWEgUGF0ZWwgPHNocmVleWEucGF0 ZWxAY29sbGFib3JhLmNvbT4KPiAKPiBBZGQgZGV2aWNlIHRyZWUgc3VwcG9ydCBmb3IgU3lub3Bz eXMgRGVzaWduV2FyZSBIRE1JIFJYCj4gQ29udHJvbGxlci4KPiAKPiBSZXZpZXdlZC1ieTogRG1p dHJ5IE9zaXBlbmtvIDxkbWl0cnkub3NpcGVua29AY29sbGFib3JhLmNvbT4KPiBUZXN0ZWQtYnk6 IERtaXRyeSBPc2lwZW5rbyA8ZG1pdHJ5Lm9zaXBlbmtvQGNvbGxhYm9yYS5jb20+Cj4gQ28tZGV2 ZWxvcGVkLWJ5OiBEaW5neGlhbiBXZW4gPHNoYXduLndlbkByb2NrLWNoaXBzLmNvbT4KPiBTaWdu ZWQtb2ZmLWJ5OiBEaW5neGlhbiBXZW4gPHNoYXduLndlbkByb2NrLWNoaXBzLmNvbT4KPiBTaWdu ZWQtb2ZmLWJ5OiBTaHJlZXlhIFBhdGVsIDxzaHJlZXlhLnBhdGVsQGNvbGxhYm9yYS5jb20+Cj4g U2lnbmVkLW9mZi1ieTogRG1pdHJ5IE9zaXBlbmtvIDxkbWl0cnkub3NpcGVua29AY29sbGFib3Jh LmNvbT4KPiAtLS0KPiAgLi4uL2R0cy9yb2NrY2hpcC9yazM1ODgtYmFzZS1waW5jdHJsLmR0c2kg ICAgIHwgMTQgKysrKysKPiAgLi4uL2FybTY0L2Jvb3QvZHRzL3JvY2tjaGlwL3JrMzU4OC1leHRy YS5kdHNpIHwgNTcgKysrKysrKysrKysrKysrKysrKwo+ICAyIGZpbGVzIGNoYW5nZWQsIDcxIGlu c2VydGlvbnMoKykKPiAKPiBkaWZmIC0tZ2l0IGEvYXJjaC9hcm02NC9ib290L2R0cy9yb2NrY2hp cC9yazM1ODgtYmFzZS1waW5jdHJsLmR0c2kgYi9hcmNoL2FybTY0L2Jvb3QvZHRzL3JvY2tjaGlw L3JrMzU4OC1iYXNlLXBpbmN0cmwuZHRzaQo+IGluZGV4IDdmODc0Yzc3NDEwYy4uMmQ0Yjk5ODZh MTc3IDEwMDY0NAo+IC0tLSBhL2FyY2gvYXJtNjQvYm9vdC9kdHMvcm9ja2NoaXAvcmszNTg4LWJh c2UtcGluY3RybC5kdHNpCj4gKysrIGIvYXJjaC9hcm02NC9ib290L2R0cy9yb2NrY2hpcC9yazM1 ODgtYmFzZS1waW5jdHJsLmR0c2kKPiBAQCAtNTk0LDYgKzU5NCwyMCBAQCBoZG1pbTBfdHgxX2hw ZDogaGRtaW0wLXR4MS1ocGQgewo+ICAJCQkJLyogaGRtaW0wX3R4MV9ocGQgKi8KPiAgCQkJCTwx IFJLX1BBNiA1ICZwY2ZnX3B1bGxfbm9uZT47Cj4gIAkJfTsKPiArCj4gKwkJL29taXQtaWYtbm8t cmVmLwo+ICsJCWhkbWltMV9yeDogaGRtaW0xLXJ4IHsKPiArCQkJcm9ja2NoaXAscGlucyA9Cj4g KwkJCQkvKiBoZG1pbTFfcnhfY2VjICovCj4gKwkJCQk8MyBSS19QRDEgNSAmcGNmZ19wdWxsX25v bmU+LAo+ICsJCQkJLyogaGRtaW0xX3J4X3NjbCAqLwo+ICsJCQkJPDMgUktfUEQyIDUgJnBjZmdf cHVsbF9ub25lX3NtdD4sCj4gKwkJCQkvKiBoZG1pbTFfcnhfc2RhICovCj4gKwkJCQk8MyBSS19Q RDMgNSAmcGNmZ19wdWxsX25vbmVfc210PiwKPiArCQkJCS8qIGhkbWltMV9yeF9ocGRpbiAqLwo+ ICsJCQkJPDMgUktfUEQ0IDUgJnBjZmdfcHVsbF9ub25lPjsKPiArCQl9Owo+ICsKCndoYXQncyB0 aGUgcmVhc29uIGZvciBkdXBsaWNhdGluZyB0aGVzZSBwaW5jdHJsIGVudHJpZXM/CgpUaGUgYmFz ZS1waW5jdHJsIGFscmVhZHkgY29udGFpbnMgYSBzZXBhcmF0ZSBzZXQgb2YgcGlucyAoYW5kIGFs c28gYQp2YXJpYW50IGZvciB0aGUgbTAgc2V0IG9mIHBpbnMpLCBzbyB3aHkgbm90IGNoZWNrIGFu ZCB1c2UgdGhlIGFscmVhZHkKZXhpc3Rpbmcgb25lczoKCiAgICAgICAgICAgICAgICBoZG1pbTFf cnhfY2VjOiBoZG1pbTEtcngtY2VjIHsKICAgICAgICAgICAgICAgICAgICAgICAgcm9ja2NoaXAs cGlucyA9CiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgLyogaGRtaW0xX3J4X2NlYyAq LwogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIDwzIFJLX1BEMSA1ICZwY2ZnX3B1bGxf bm9uZT47CiAgICAgICAgICAgICAgICB9OwoKICAgICAgICAgICAgICAgIGhkbWltMV9yeF9ocGRp bjogaGRtaW0xLXJ4LWhwZGluIHsKICAgICAgICAgICAgICAgICAgICAgICAgcm9ja2NoaXAscGlu cyA9CiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgLyogaGRtaW0xX3J4X2hwZGluICov CiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgPDMgUktfUEQ0IDUgJnBjZmdfcHVsbF9u b25lPjsKICAgICAgICAgICAgICAgIH07CgogICAgICAgICAgICAgICAgaGRtaW0xX3J4X3NjbDog aGRtaW0xLXJ4LXNjbCB7CiAgICAgICAgICAgICAgICAgICAgICAgIHJvY2tjaGlwLHBpbnMgPQog ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIC8qIGhkbWltMV9yeF9zY2wgKi8KICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICA8MyBSS19QRDIgNSAmcGNmZ19wdWxsX25vbmU+Owog ICAgICAgICAgICAgICAgfTsKCiAgICAgICAgICAgICAgICBoZG1pbTFfcnhfc2RhOiBoZG1pbTEt cngtc2RhIHsKICAgICAgICAgICAgICAgICAgICAgICAgcm9ja2NoaXAscGlucyA9CiAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgLyogaGRtaW0xX3J4X3NkYSAqLwogICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgIDwzIFJLX1BEMyA1ICZwY2ZnX3B1bGxfbm9uZT47CiAgICAgICAg ICAgICAgICB9OwoKCkhhdmluZyBtdWx0aXBsZSBzZXRzIChldmVuIHdpdGggZGlmZmVyZWluZyBz ZXR0aW5ncykgd2lsbCBjYXVzZSBjb25mdXNpb24KbGF0ZXIgb24uCgoKPiAgCQkvb21pdC1pZi1u by1yZWYvCj4gIAkJaGRtaW0xX3J4X2NlYzogaGRtaW0xLXJ4LWNlYyB7Cj4gIAkJCXJvY2tjaGlw LHBpbnMgPQo+IGRpZmYgLS1naXQgYS9hcmNoL2FybTY0L2Jvb3QvZHRzL3JvY2tjaGlwL3JrMzU4 OC1leHRyYS5kdHNpIGIvYXJjaC9hcm02NC9ib290L2R0cy9yb2NrY2hpcC9yazM1ODgtZXh0cmEu ZHRzaQo+IGluZGV4IDRhOTUwOTA3ZWE2Zi4uYjdkMDZmOTNjOGNlIDEwMDY0NAo+IC0tLSBhL2Fy Y2gvYXJtNjQvYm9vdC9kdHMvcm9ja2NoaXAvcmszNTg4LWV4dHJhLmR0c2kKPiArKysgYi9hcmNo L2FybTY0L2Jvb3QvZHRzL3JvY2tjaGlwL3JrMzU4OC1leHRyYS5kdHNpCj4gQEAgLTEzNSw2ICsx NTksMzkgQEAgaTJzMTBfOGNoOiBpMnNAZmRlMDAwMDAgewo+ICAJCXN0YXR1cyA9ICJkaXNhYmxl ZCI7Cj4gIAl9Owo+ICAKPiArCWhkbWlfcmVjZWl2ZXI6IGhkbWlfcmVjZWl2ZXJAZmRlZTAwMDAg ewo+ICsJCWNvbXBhdGlibGUgPSAicm9ja2NoaXAscmszNTg4LWhkbWlyeC1jdHJsZXIiLCAic25w cyxkdy1oZG1pLXJ4IjsKPiArCQlyZWcgPSA8MHgwIDB4ZmRlZTAwMDAgMHgwIDB4NjAwMD47Cj4g KwkJcG93ZXItZG9tYWlucyA9IDwmcG93ZXIgUkszNTg4X1BEX1ZPMT47Cj4gKwkJcm9ja2NoaXAs Z3JmID0gPCZzeXNfZ3JmPjsKPiArCQlyb2NrY2hpcCx2bzEtZ3JmID0gPCZ2bzFfZ3JmPjsKPiAr CQlpbnRlcnJ1cHRzID0gPEdJQ19TUEkgMTc3IElSUV9UWVBFX0xFVkVMX0hJR0ggMD4sCj4gKwkJ CSAgICAgPEdJQ19TUEkgMTc4IElSUV9UWVBFX0xFVkVMX0hJR0ggMD4sCj4gKwkJCSAgICAgPEdJ Q19TUEkgMTc5IElSUV9UWVBFX0xFVkVMX0hJR0ggMD47Cj4gKwkJaW50ZXJydXB0LW5hbWVzID0g ImNlYyIsICJoZG1pIiwgImRtYSI7Cj4gKwkJY2xvY2tzID0gPCZjcnUgQUNMS19IRE1JUlg+LAo+ ICsJCQkgPCZjcnUgQ0xLX0hETUlSWF9BVUQ+LAo+ICsJCQkgPCZjcnUgQ0xLX0NSX1BBUkE+LAo+ ICsJCQkgPCZjcnUgUENMS19IRE1JUlg+LAo+ICsJCQkgPCZjcnUgQ0xLX0hETUlSWF9SRUY+LAo+ ICsJCQkgPCZjcnUgUENMS19TX0hETUlSWD4sCj4gKwkJCSA8JmNydSBIQ0xLX1ZPMT47Cj4gKwkJ Y2xvY2stbmFtZXMgPSAiYWNsayIsCj4gKwkJCSAgICAgICJhdWRpbyIsCj4gKwkJCSAgICAgICJj cl9wYXJhIiwKPiArCQkJICAgICAgInBjbGsiLAo+ICsJCQkgICAgICAicmVmIiwKPiArCQkJICAg ICAgImhjbGtfc19oZG1pcngiLAo+ICsJCQkgICAgICAiaGNsa192bzEiOwo+ICsJCXJlc2V0cyA9 IDwmY3J1IFNSU1RfQV9IRE1JUlg+LCA8JmNydSBTUlNUX1BfSERNSVJYPiwKPiArCQkJIDwmY3J1 IFNSU1RfSERNSVJYX1JFRj4sIDwmY3J1IFNSU1RfQV9IRE1JUlhfQklVPjsKPiArCQlyZXNldC1u YW1lcyA9ICJheGkiLCAiYXBiIiwgInJlZiIsICJiaXUiOwo+ICsJCW1lbW9yeS1yZWdpb24gPSA8 JmhkbWlfcmVjZWl2ZXJfY21hPjsKPiArCQlwaW5jdHJsLTAgPSA8JmhkbWltMV9yeD47Cj4gKwkJ cGluY3RybC1uYW1lcyA9ICJkZWZhdWx0IjsKCmhtbSwgdGhpcyBtaWdodCBiZSBiZXR0ZXIgbGl2 aW5nIGluIHRoZSBib2FyZCBkdHM/CgpIZWlrbwoKCgpfX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fXwpMaW51eC1yb2NrY2hpcCBtYWlsaW5nIGxpc3QKTGludXgt cm9ja2NoaXBAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9t YWlsbWFuL2xpc3RpbmZvL2xpbnV4LXJvY2tjaGlwCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from gloria.sntech.de (gloria.sntech.de [185.11.138.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CBCA420B80B; Thu, 6 Mar 2025 13:06:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.11.138.130 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741266417; cv=none; b=fXzOURZtvT9Q77xboymaArkxTEyLSRI7Hi1vM8EbZyhEbBrSrvn3frDzImx7643MjUtq8RYpy+R7M1MdnZdu6cU00ef6TBR6bSQqMg7mK+5F5Ftd6M8rJCyGsO+lgDH/Y6UXFN038JNsDS9ZpwpvwYpyAf5HFXt05AcTitx3z5Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741266417; c=relaxed/simple; bh=/zvzWaJI1zZXi4qtvOSdgjvM/z7uv3ifWM6gOzWmeH4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=VKE1Dm70FDLIfvoMDKtZmy+YvPOCunTVoodJYFlbjml6sUcZs+z6HK03/mQ+2jse1sHm87QYFF7Y7BzPNCDYI/8iIlnCHpTgCN4hVQyIOZPOK1avNXNV852VeFm3NysXAUwFEFo4BjaAdgtg9pTsQvrhss1X4rpbWA+b21VXgBM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sntech.de; spf=pass smtp.mailfrom=sntech.de; dkim=pass (2048-bit key) header.d=sntech.de header.i=@sntech.de header.b=HW4ePAFd; arc=none smtp.client-ip=185.11.138.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sntech.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sntech.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sntech.de header.i=@sntech.de header.b="HW4ePAFd" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sntech.de; s=gloria202408; h=Content-Type:Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=mfBuDbSuVwW4tPY5y3ejNrFbP51Lhqr440UyYLTygs4=; b=HW4ePAFdm0EXJK81MA9j0l1Ngf N3QPXF+BbJlJPc0SOGcLA1ibPPtby/R5nL4YwQC/BR0BgoiuSNlTA2Wnl5QT20X/yqs0ydptuWQms /FB8hhqJhXACRIer/jCk/qeyBtlsjzCB3R7/2OoH1WkR+Ctpp1sOFoFx/8dcCuY2+0v27H+LN6wqA VSqBTpJ3Noa58ge6W0gtqOyW39+UNE6CG19l1hASFfHGtOlwrWYfKGobuQIfyFU1GuAa1jjLIC4/l MjxDgwLGbSjM+hKtV9Pn+8TYKHGLC4AEjZF2EKiX7nqK5mQbgm1k20cfFD3QdcGmKinmPOe+WLv+R 6XWmSdHQ==; Received: from i53875a38.versanet.de ([83.135.90.56] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tqAvx-00039x-W9; Thu, 06 Mar 2025 14:06:42 +0100 From: Heiko =?UTF-8?B?U3TDvGJuZXI=?= To: Shreeya Patel , Mauro Carvalho Chehab , Hans Verkuil , Rob Herring , Krzysztof Kozlowski , Conor Dooley , jose.abreu@synopsys.com, nelson.costa@synopsys.com, shawn.wen@rock-chips.com, nicolas.dufresne@collabora.com, Sebastian Reichel , Dmitry Osipenko Cc: kernel@collabora.com, linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, Tim Surber , Christophe JAILLET , Diederik de Haas Subject: Re: [PATCH v14 1/3] arm64: dts: rockchip: Add device tree support for HDMI RX Controller Date: Thu, 06 Mar 2025 14:06:40 +0100 Message-ID: <9489391.T7Z3S40VBb@diego> In-Reply-To: <20250306072842.287142-2-dmitry.osipenko@collabora.com> References: <20250306072842.287142-1-dmitry.osipenko@collabora.com> <20250306072842.287142-2-dmitry.osipenko@collabora.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Hi Dmitry, Am Donnerstag, 6. M=C3=A4rz 2025, 08:28:40 MEZ schrieb Dmitry Osipenko: > From: Shreeya Patel >=20 > Add device tree support for Synopsys DesignWare HDMI RX > Controller. >=20 > Reviewed-by: Dmitry Osipenko > Tested-by: Dmitry Osipenko > Co-developed-by: Dingxian Wen > Signed-off-by: Dingxian Wen > Signed-off-by: Shreeya Patel > Signed-off-by: Dmitry Osipenko > --- > .../dts/rockchip/rk3588-base-pinctrl.dtsi | 14 +++++ > .../arm64/boot/dts/rockchip/rk3588-extra.dtsi | 57 +++++++++++++++++++ > 2 files changed, 71 insertions(+) >=20 > diff --git a/arch/arm64/boot/dts/rockchip/rk3588-base-pinctrl.dtsi b/arch= /arm64/boot/dts/rockchip/rk3588-base-pinctrl.dtsi > index 7f874c77410c..2d4b9986a177 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3588-base-pinctrl.dtsi > +++ b/arch/arm64/boot/dts/rockchip/rk3588-base-pinctrl.dtsi > @@ -594,6 +594,20 @@ hdmim0_tx1_hpd: hdmim0-tx1-hpd { > /* hdmim0_tx1_hpd */ > <1 RK_PA6 5 &pcfg_pull_none>; > }; > + > + /omit-if-no-ref/ > + hdmim1_rx: hdmim1-rx { > + rockchip,pins =3D > + /* hdmim1_rx_cec */ > + <3 RK_PD1 5 &pcfg_pull_none>, > + /* hdmim1_rx_scl */ > + <3 RK_PD2 5 &pcfg_pull_none_smt>, > + /* hdmim1_rx_sda */ > + <3 RK_PD3 5 &pcfg_pull_none_smt>, > + /* hdmim1_rx_hpdin */ > + <3 RK_PD4 5 &pcfg_pull_none>; > + }; > + what's the reason for duplicating these pinctrl entries? The base-pinctrl already contains a separate set of pins (and also a variant for the m0 set of pins), so why not check and use the already existing ones: hdmim1_rx_cec: hdmim1-rx-cec { rockchip,pins =3D /* hdmim1_rx_cec */ <3 RK_PD1 5 &pcfg_pull_none>; }; hdmim1_rx_hpdin: hdmim1-rx-hpdin { rockchip,pins =3D /* hdmim1_rx_hpdin */ <3 RK_PD4 5 &pcfg_pull_none>; }; hdmim1_rx_scl: hdmim1-rx-scl { rockchip,pins =3D /* hdmim1_rx_scl */ <3 RK_PD2 5 &pcfg_pull_none>; }; hdmim1_rx_sda: hdmim1-rx-sda { rockchip,pins =3D /* hdmim1_rx_sda */ <3 RK_PD3 5 &pcfg_pull_none>; }; Having multiple sets (even with differeing settings) will cause confusion later on. > /omit-if-no-ref/ > hdmim1_rx_cec: hdmim1-rx-cec { > rockchip,pins =3D > diff --git a/arch/arm64/boot/dts/rockchip/rk3588-extra.dtsi b/arch/arm64/= boot/dts/rockchip/rk3588-extra.dtsi > index 4a950907ea6f..b7d06f93c8ce 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3588-extra.dtsi > +++ b/arch/arm64/boot/dts/rockchip/rk3588-extra.dtsi > @@ -135,6 +159,39 @@ i2s10_8ch: i2s@fde00000 { > status =3D "disabled"; > }; > =20 > + hdmi_receiver: hdmi_receiver@fdee0000 { > + compatible =3D "rockchip,rk3588-hdmirx-ctrler", "snps,dw-hdmi-rx"; > + reg =3D <0x0 0xfdee0000 0x0 0x6000>; > + power-domains =3D <&power RK3588_PD_VO1>; > + rockchip,grf =3D <&sys_grf>; > + rockchip,vo1-grf =3D <&vo1_grf>; > + interrupts =3D , > + , > + ; > + interrupt-names =3D "cec", "hdmi", "dma"; > + clocks =3D <&cru ACLK_HDMIRX>, > + <&cru CLK_HDMIRX_AUD>, > + <&cru CLK_CR_PARA>, > + <&cru PCLK_HDMIRX>, > + <&cru CLK_HDMIRX_REF>, > + <&cru PCLK_S_HDMIRX>, > + <&cru HCLK_VO1>; > + clock-names =3D "aclk", > + "audio", > + "cr_para", > + "pclk", > + "ref", > + "hclk_s_hdmirx", > + "hclk_vo1"; > + resets =3D <&cru SRST_A_HDMIRX>, <&cru SRST_P_HDMIRX>, > + <&cru SRST_HDMIRX_REF>, <&cru SRST_A_HDMIRX_BIU>; > + reset-names =3D "axi", "apb", "ref", "biu"; > + memory-region =3D <&hdmi_receiver_cma>; > + pinctrl-0 =3D <&hdmim1_rx>; > + pinctrl-names =3D "default"; hmm, this might be better living in the board dts? Heiko