All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Kjellerstedt <peter.kjellerstedt@axis.com>
To: Ross Burton <ross.burton@arm.com>,
	"david.bagonyi@gmail.com" <david.bagonyi@gmail.com>
Cc: "openembedded-core@lists.openembedded.org"
	<openembedded-core@lists.openembedded.org>
Subject: RE: [OE-core] [PATCH] gpgme: Allow setuptools3-base to be excluded from the inherit list
Date: Wed, 5 Oct 2022 15:06:07 +0000	[thread overview]
Message-ID: <94da13d2ddcc4335b9967da1475f68cf@axis.com> (raw)
In-Reply-To: <C4870FFC-4738-4652-A853-9CBFF44FF1A8@arm.com>

> -----Original Message-----
> From: openembedded-core@lists.openembedded.org <openembedded-
> core@lists.openembedded.org> On Behalf Of Ross Burton
> Sent: den 5 oktober 2022 13:27
> To: david.bagonyi@gmail.com
> Cc: openembedded-core@lists.openembedded.org
> Subject: Re: [OE-core] [PATCH] gpgme: Allow setuptools3-base to be
> excluded from the inherit list
> 
> > On 5 Oct 2022, at 11:48, David Bagonyi via lists.openembedded.org <david.bagonyi=gmail.com@lists.openembedded.org> wrote:
> > PYTHON_INHERIT = "${@bb.utils.contains('PACKAGECONFIG', 'python2', 'pythonnative', '', d)}"
> > PYTHON_INHERIT .= "${@bb.utils.contains('PACKAGECONFIG', 'python3', 'python3native python3targetconfig', '', d)}"
> > +PYTHON_INHERIT .= "${@bb.utils.contains('LANGUAGES', 'python', 'setuptools3-base', '', d)}”
> 
> Note that setuptools3-base itself inherits python3native and
> python3targetconfig.  This is important due to ordering: if python2 is
> selected then pythonnative needs to be inherited *after* setuptools3-base
> so that PYTHON is python2 and not python3.
> 
> However as Py2 has been EOL for nearly three years now, I suggest we just
> rip out all of the python2 parts in the process of fixing the inherit.
> 
> Ross

Also note that the above should use "+=" rather than ".=", as otherwise 
the inherits will be concatenated into a mess without spaces if multiple 
options are enabled at the same time.

//Peter


      reply	other threads:[~2022-10-05 15:06 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-05 10:48 [PATCH] gpgme: Allow setuptools3-base to be excluded from the inherit list David Bagonyi
2022-10-05 11:26 ` [OE-core] " Ross Burton
2022-10-05 15:06   ` Peter Kjellerstedt [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=94da13d2ddcc4335b9967da1475f68cf@axis.com \
    --to=peter.kjellerstedt@axis.com \
    --cc=david.bagonyi@gmail.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=ross.burton@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.