From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17939C7EE2E for ; Wed, 17 May 2023 16:54:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229540AbjEQQxl (ORCPT ); Wed, 17 May 2023 12:53:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44566 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229738AbjEQQxQ (ORCPT ); Wed, 17 May 2023 12:53:16 -0400 Received: from mail-wm1-x336.google.com (mail-wm1-x336.google.com [IPv6:2a00:1450:4864:20::336]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6E5AF9D for ; Wed, 17 May 2023 09:53:00 -0700 (PDT) Received: by mail-wm1-x336.google.com with SMTP id 5b1f17b1804b1-3f41d087a84so1984375e9.1 for ; Wed, 17 May 2023 09:53:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20221208.gappssmtp.com; s=20221208; t=1684342379; x=1686934379; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=8dOJVIGMX/56gfv9vT65ZzraMpImyEbSMTyJtUPlCLo=; b=2BVmhZvz4oCFmI5/DV5GvMVrMDeSuoxTJrL4iNd3Jxd8RMgHHaG2zBP3QGXd4XOrKH hnCaxYsoji/6w9ykNXsu7Fi6zdPHszF1Q4gQwaYtYi+alCroMmK3dTCvf76H24m0hBNH uPYMxYIcvwsv9oLoqcnRqkuJqG160ovtznAlXlPoISd+6G5FUe39gNEpXnHhlVhKSgAr j7cJBOpVpVr6bIWkD/AWH7j1IIm/DQGL+hgxy/nADAKFAC150PQwk4fwE0f01qyGHD+P Cp76uAflMqRUWC6k9pvk/7rn+QHXpv19LDYyCPOIgLeWLoQ8+IfQ09AyPHmlKEGKrCXG SwVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684342379; x=1686934379; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=8dOJVIGMX/56gfv9vT65ZzraMpImyEbSMTyJtUPlCLo=; b=Bsz3x8NBgy7Raf/6Pn0ur2ANVnWgHHkyh+cRXCkBmwmQ52lMISMvut+TXs/0OkPp5A XDWgzsNyPZtTsBGuruuqmIta9RSDq3wNs0U58e5hyh+s8v+vU153n3xa7+n99LSfdYbo 7kEMUjiKU7yvwAEVFkGZ/7ItVONMJPlcLy/HuUsw6qoQ0tW064VU9wTJqP7sc3sVb9vw tk/fDaiUUF9ekPxj4kmEX2W3lMbk+u/43ocs1lYSp+9F3R2ALylYuZr9Wo0PFUifb7n6 xO5oyAQXuawKJSdHJtPPcoRHIR50oVzaBv1FJJVwSU7jw8Q1lJ09PBN58UpmC+gc6r1V 1sVA== X-Gm-Message-State: AC+VfDwRek5yc9hW9QMaYP41k8p/LSLwFZTQvnuLQoiX/yB5B+ogMkT9 MN2py+UXUVQ+mLWv8KlsMsV9JA== X-Google-Smtp-Source: ACHHUZ5oWXHIEKdFAwIxANhWR9lMlqKmEiYA0FORJIMDBWG4zKRbrOzb0ppHIUnnzPT2YmO1WjO6DQ== X-Received: by 2002:a7b:cd01:0:b0:3f4:fe7f:3d18 with SMTP id f1-20020a7bcd01000000b003f4fe7f3d18mr2318552wmj.2.1684342378813; Wed, 17 May 2023 09:52:58 -0700 (PDT) Received: from [192.168.1.172] (158.22.5.93.rev.sfr.net. [93.5.22.158]) by smtp.gmail.com with ESMTPSA id u15-20020adfed4f000000b00307c46f4f08sm3267555wro.79.2023.05.17.09.52.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 17 May 2023 09:52:58 -0700 (PDT) Message-ID: <94f8af4a-2555-052d-d04a-a0e54e0e2d13@baylibre.com> Date: Wed, 17 May 2023 18:52:56 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH v2 0/2] clk/mediatek: Adjustments for MSDC rate accuracy To: AngeloGioacchino Del Regno , mturquette@baylibre.com Cc: sboyd@kernel.org, matthias.bgg@gmail.com, wenst@chromium.org, chun-jie.chen@mediatek.com, mandyjh.liu@mediatek.com, miles.chen@mediatek.com, zhaojh329@gmail.com, daniel@makrotopia.org, nfraprado@collabora.com, rex-bc.chen@mediatek.com, Garmin.Chang@mediatek.com, msp@baylibre.com, yangyingliang@huawei.com, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, kernel@collabora.com References: <20230516135205.372951-1-angelogioacchino.delregno@collabora.com> Content-Language: en-US From: Alexandre Mergnat In-Reply-To: <20230516135205.372951-1-angelogioacchino.delregno@collabora.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org On 16/05/2023 15:52, AngeloGioacchino Del Regno wrote: > Changes in v2: > - Extended the changes in this series to MT8365 clocks > > This series stops unconditionally forcing CLK_SET_RATE_PARENT on > MediaTek muxes, as that should be set in the clock driver for each > clock requiring it, and removes CLK_SET_PARENT from all MSDC core > clocks to allow mtk-sd to select the right clock parent when doing > mclk setting, improving the rate accuracy and avoiding both under > and overclocks of the eMMC/SD/SDIO card, both improving performance > and stability of the attached storage. > > This series was successfully tested on MT8173, MT8192, MT8195. > > AngeloGioacchino Del Regno (2): > clk: mediatek: mux: Stop forcing CLK_SET_RATE_PARENT flag > clk: mediatek: Remove CLK_SET_PARENT from all MSDC core clocks > > drivers/clk/mediatek/clk-mt6765.c | 20 +++++----- > drivers/clk/mediatek/clk-mt6779.c | 24 +++++------ > drivers/clk/mediatek/clk-mt7981-topckgen.c | 12 +++--- > drivers/clk/mediatek/clk-mt7986-topckgen.c | 12 +++--- > drivers/clk/mediatek/clk-mt8173-topckgen.c | 24 +++++------ > drivers/clk/mediatek/clk-mt8183.c | 22 ++++++----- > drivers/clk/mediatek/clk-mt8186-topckgen.c | 24 +++++------ > drivers/clk/mediatek/clk-mt8188-topckgen.c | 40 +++++++++++-------- > drivers/clk/mediatek/clk-mt8192.c | 23 +++++------ > drivers/clk/mediatek/clk-mt8195-topckgen.c | 46 +++++++++++++--------- > drivers/clk/mediatek/clk-mt8365.c | 38 +++++++++--------- > drivers/clk/mediatek/clk-mux.c | 2 +- > 12 files changed, 155 insertions(+), 132 deletions(-) > I will try to test it next week on MT8365 SoC. -- Regards, Alexandre From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2D4A7C77B7A for ; Wed, 17 May 2023 16:53:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=JzlQEsqHqYcLOTnOdxNT/eiCjDt1L4/k4Tv9ndyXX+Q=; b=kB30QfuxNZo2Fp 4OGm8HaEMl8Eq+EjJTBBMXct9da71hUcC7Q6LOlGG+67i5drWKNMV2r5J1BoiZ0H/zGDoscBS+zMA /doYkU2WiHRqJM0Udx8Ngor+sUXwJVlQQDm9e3aMDwlQMuHOiqCkMywcDnLsNE5Ulwm5A0T+4KV1b WacmYV53Qp/Lek92DM5YhQff3nukywEGiHtuHb4HKem5Sy1e+TKPiZW24uEnlhpAhvl+J6HHKHbcb e2TDZ79Kh8TCbyUBW3mr9UYajLmuIl9TJ0SY8voJgdkp8ieb2cJ4GIqdOCcN4GnKeI0GN7vIoHf6t QuQIuVC6JQP8ftbDyojA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pzKOh-00AWL6-2N; Wed, 17 May 2023 16:53:07 +0000 Received: from mail-wm1-x32e.google.com ([2a00:1450:4864:20::32e]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pzKOc-00AWJ8-33 for linux-arm-kernel@lists.infradead.org; Wed, 17 May 2023 16:53:05 +0000 Received: by mail-wm1-x32e.google.com with SMTP id 5b1f17b1804b1-3f41d087a84so1984365e9.1 for ; Wed, 17 May 2023 09:53:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20221208.gappssmtp.com; s=20221208; t=1684342379; x=1686934379; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=8dOJVIGMX/56gfv9vT65ZzraMpImyEbSMTyJtUPlCLo=; b=2BVmhZvz4oCFmI5/DV5GvMVrMDeSuoxTJrL4iNd3Jxd8RMgHHaG2zBP3QGXd4XOrKH hnCaxYsoji/6w9ykNXsu7Fi6zdPHszF1Q4gQwaYtYi+alCroMmK3dTCvf76H24m0hBNH uPYMxYIcvwsv9oLoqcnRqkuJqG160ovtznAlXlPoISd+6G5FUe39gNEpXnHhlVhKSgAr j7cJBOpVpVr6bIWkD/AWH7j1IIm/DQGL+hgxy/nADAKFAC150PQwk4fwE0f01qyGHD+P Cp76uAflMqRUWC6k9pvk/7rn+QHXpv19LDYyCPOIgLeWLoQ8+IfQ09AyPHmlKEGKrCXG SwVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684342379; x=1686934379; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=8dOJVIGMX/56gfv9vT65ZzraMpImyEbSMTyJtUPlCLo=; b=UpJnS6Vc94W2NITUY7M8XLebzbvCShJ2mFrjqJ19MzHMIReHnW8XsBZSSTRCLK4Vqq TqEkPIlTHS17FN/W4Bcazvgya9PSuwg4Sfeq3P2OQC/YZFIvlCw9W4x2g2PEqcVfHcqi 8BBdJq7Zb/MUgsKNNR3irLnJ3XUqGhBMzkzlP7I4DAIh2Vgo4K9gxTwyhL5FPjXw1UDs 69/fy1EiodGe93VQTgk7Api5W2+4mfSEnvNjcICAhTCN3ND27ddu0qG5GY8V5a1Sqbh8 knBRPoMJWpxX84S+cEx+SMZ9viXHzuDqWrwTw2Yvf8JY0LhKCeRF+ds5ikNjywEWh7d/ IK/A== X-Gm-Message-State: AC+VfDz6tuVP2hxTfQ2P4Vtyj/iLW7KO5atdazVSQs0DF7wuZ/JtfVe0 +8jijvMHUa9lmCSGmF3AY3kloQ== X-Google-Smtp-Source: ACHHUZ5oWXHIEKdFAwIxANhWR9lMlqKmEiYA0FORJIMDBWG4zKRbrOzb0ppHIUnnzPT2YmO1WjO6DQ== X-Received: by 2002:a7b:cd01:0:b0:3f4:fe7f:3d18 with SMTP id f1-20020a7bcd01000000b003f4fe7f3d18mr2318552wmj.2.1684342378813; Wed, 17 May 2023 09:52:58 -0700 (PDT) Received: from [192.168.1.172] (158.22.5.93.rev.sfr.net. [93.5.22.158]) by smtp.gmail.com with ESMTPSA id u15-20020adfed4f000000b00307c46f4f08sm3267555wro.79.2023.05.17.09.52.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 17 May 2023 09:52:58 -0700 (PDT) Message-ID: <94f8af4a-2555-052d-d04a-a0e54e0e2d13@baylibre.com> Date: Wed, 17 May 2023 18:52:56 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH v2 0/2] clk/mediatek: Adjustments for MSDC rate accuracy To: AngeloGioacchino Del Regno , mturquette@baylibre.com Cc: sboyd@kernel.org, matthias.bgg@gmail.com, wenst@chromium.org, chun-jie.chen@mediatek.com, mandyjh.liu@mediatek.com, miles.chen@mediatek.com, zhaojh329@gmail.com, daniel@makrotopia.org, nfraprado@collabora.com, rex-bc.chen@mediatek.com, Garmin.Chang@mediatek.com, msp@baylibre.com, yangyingliang@huawei.com, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, kernel@collabora.com References: <20230516135205.372951-1-angelogioacchino.delregno@collabora.com> Content-Language: en-US From: Alexandre Mergnat In-Reply-To: <20230516135205.372951-1-angelogioacchino.delregno@collabora.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230517_095302_983729_BC85C6DB X-CRM114-Status: GOOD ( 16.32 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 16/05/2023 15:52, AngeloGioacchino Del Regno wrote: > Changes in v2: > - Extended the changes in this series to MT8365 clocks > > This series stops unconditionally forcing CLK_SET_RATE_PARENT on > MediaTek muxes, as that should be set in the clock driver for each > clock requiring it, and removes CLK_SET_PARENT from all MSDC core > clocks to allow mtk-sd to select the right clock parent when doing > mclk setting, improving the rate accuracy and avoiding both under > and overclocks of the eMMC/SD/SDIO card, both improving performance > and stability of the attached storage. > > This series was successfully tested on MT8173, MT8192, MT8195. > > AngeloGioacchino Del Regno (2): > clk: mediatek: mux: Stop forcing CLK_SET_RATE_PARENT flag > clk: mediatek: Remove CLK_SET_PARENT from all MSDC core clocks > > drivers/clk/mediatek/clk-mt6765.c | 20 +++++----- > drivers/clk/mediatek/clk-mt6779.c | 24 +++++------ > drivers/clk/mediatek/clk-mt7981-topckgen.c | 12 +++--- > drivers/clk/mediatek/clk-mt7986-topckgen.c | 12 +++--- > drivers/clk/mediatek/clk-mt8173-topckgen.c | 24 +++++------ > drivers/clk/mediatek/clk-mt8183.c | 22 ++++++----- > drivers/clk/mediatek/clk-mt8186-topckgen.c | 24 +++++------ > drivers/clk/mediatek/clk-mt8188-topckgen.c | 40 +++++++++++-------- > drivers/clk/mediatek/clk-mt8192.c | 23 +++++------ > drivers/clk/mediatek/clk-mt8195-topckgen.c | 46 +++++++++++++--------- > drivers/clk/mediatek/clk-mt8365.c | 38 +++++++++--------- > drivers/clk/mediatek/clk-mux.c | 2 +- > 12 files changed, 155 insertions(+), 132 deletions(-) > I will try to test it next week on MT8365 SoC. -- Regards, Alexandre _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel