All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexander Kanavin <alexander.kanavin@linux.intel.com>
To: Juro Bystricky <juro.bystricky@intel.com>,
	openembedded-core@lists.openembedded.org
Cc: jurobystricky@hotmail.com
Subject: Re: [PATCH] glib-2.0/glib.inc: fix broken mingw build
Date: Fri, 13 Apr 2018 09:48:58 +0300	[thread overview]
Message-ID: <94fbeffa-e80a-2160-d6b7-d76aa779b941@linux.intel.com> (raw)
In-Reply-To: <1523572087-34315-1-git-send-email-juro.bystricky@intel.com>

On 04/13/2018 01:28 AM, Juro Bystricky wrote:
> mingw build was broken by the commit:
> "glib-2.0/glib.inc: apply MLPREFIX renaming to all package classes"
> 
> When building for mingw, we encounter build errors such as:
> 
>    mv: cannot stat '<builddir>/<...>/usr/libexec/gio-querymodules': No such file or directory
> 
> The file that exists is actually "gio-querymodules.exe", but still there is no
> good reason to rename it to "nativesdk-gio-querymodules.exe".
> So for mingw we simply avoid renaming of the executable, by skippng the line:
> 
>    mv -v ${D}${libexecdir}/gio-querymodules ${D}${libexecdir}/${MLPREFIX}gio-querymodules
> 
> [YOCTO #12679]

The reason for the renaming is that postinst_intercept logic will try to 
execute the binary with the mlprefix, when running populate_sdk. I think 
this is not gonna work with your patch, and the bug does not mention 
that you tried it.

I think the better approach is to accommodate the exe suffix when doing 
the move:

mv -v ${D}${libexecdir}/gio-querymodules${EXEEXT} 
${D}${libexecdir}/${MLPREFIX}gio-querymodules${EXEEXT}

Alex


  reply	other threads:[~2018-04-13  6:55 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-12 22:28 [PATCH] glib-2.0/glib.inc: fix broken mingw build Juro Bystricky
2018-04-13  6:48 ` Alexander Kanavin [this message]
2018-04-13 14:43   ` Bystricky, Juro
2018-04-13 19:32     ` Alexander Kanavin
2018-04-13 20:29       ` Bystricky, Juro
2018-04-13 21:03         ` Alexander Kanavin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=94fbeffa-e80a-2160-d6b7-d76aa779b941@linux.intel.com \
    --to=alexander.kanavin@linux.intel.com \
    --cc=juro.bystricky@intel.com \
    --cc=jurobystricky@hotmail.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.