Re: [DPU PATCH v3 5/6] drm/msm: hook up DPU with upstream DSI

[Jeykumar Sankaran <jsanka-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>]

On 2018-06-01 09:21, Sean Paul wrote:
> On Fri, May 25, 2018 at 02:26:06PM -0700, Jeykumar Sankaran wrote:
>> Switch DPU from dsi-staging to upstream dsi driver. To make
>> the switch atomic, this change includes:
>> - remove dpu connector layers
>> - clean up dpu connector dependencies in encoder/crtc
>> - compile out writeback and display port drivers
>> - compile out dsi-staging driver (separate patch submitted to
>>   remove the driver)
>> - adapt upstream device hierarchy
>> 
>> changes in v2:
>> 	- remove files not applicable upstream (Sean Paul)
>> 	- remove compiled out non-dsi display init (Sean Paul)
>> 	- split unrelated changes into separate patch set (Sean Paul)
>> changes in v3:
>> 	- fix compilation warning
>> 	- compile out dsi staging
>> 
>> Signed-off-by: Jeykumar Sankaran <jsanka@codeaurora.org>
>> Signed-off-by: Sean Paul <seanpaul@chromium.org>
>> Signed-off-by: Rajesh Yadav <ryadav@codeaurora.org>
>> ---
> 
> /snip
> 
>> @@ -1089,7 +1095,7 @@ void dpu_rm_release(struct dpu_rm *rm, struct
> drm_encoder *enc)
>>  {
>>  	struct dpu_rm_rsvp *rsvp;
>>  	struct drm_connector *conn;
>> -	uint64_t top_ctrl;
>> +	uint64_t top_ctrl = 0;
> 
> This will always just force the else path. Just remove it all.
> 
> Sean
> 
> /snip
Sure. Taking care of it in the next patch set. FYI, most of the RSVP 
handling and custom top_ctrl are stripped down in the next series of 
clean up's.
-- 
Jeykumar S
_______________________________________________
Freedreno mailing list
Freedreno@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/freedreno