All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hans Verkuil <hverkuil+cisco@kernel.org>
To: bod@kernel.org, linux-media@vger.kernel.org
Cc: bryan.odonoghue@linaro.org
Subject: Re: [GIT PULL FOR 6.18] Please pull platform-qcom-iris-encoder-plus-dependent-fixes-for-6.18-v2
Date: Tue, 9 Sep 2025 14:07:56 +0200	[thread overview]
Message-ID: <951b925e-3d0f-4016-a45e-e1b4ccf5f3fc@kernel.org> (raw)
In-Reply-To: <20250909094256.40537-1-bod@kernel.org>

On 09/09/2025 11:42, bod@kernel.org wrote:
> From: Bryan O'Donoghue <bod@kernel.org>
> 
> The following changes since commit dcd2ca10faaf59fedcafffc6bbf41ba628a23cc4:
> 
>   media: i2c: s5k6a3: Use V4L2 legacy sensor clock helper (2025-09-08 20:32:43 +0200)
> 
> are available in the Git repository at:
> 
>   https://gitlab.freedesktop.org/linux-media/users/bodonoghue.git tags/platform-qcom-iris-encoder-plus-dependent-fixes-for-6.18-v2
> 
> for you to fetch changes up to 105d6bc8583498dee6b8c665143a8d8eef135610:
> 
>   media: iris: add VPU33 specific encoding buffer calculation (2025-09-09 09:59:37 +0100)
> 
> ----------------------------------------------------------------
> This tag contains:
> 
> - A number of Fixes:
> - An set of patches to enable the encoder which depend
>   on the Fixes: in this PR to apply cleanly
> - A power-sequencing update from Neil which also depends
>   on code in this tag
> - v2 missed inclusion of "Fix buffer count reporting.."
>   from Dikshita - fixed in v2.
> 
> platform-qcom-iris-generic-fixes-updates-for-6.18-v2 should be
> merged first.

This fails to compile since this patch is now merged:

https://patchwork.linuxtv.org/project/linux-media/patch/20250902-sm8750-iris-v3-3-564488b412d2@linaro.org/

"media: iris: Add platform-specific capabilities for encoder video device"
doesn't take support for SM8750 (added by that patch) into account.

I marked this PR as "Changes Requested".

Bryan, if the changes are trivial (I suspect that's likely to be the case),
then just adjust the patch and post a new PR.

Regards,

	Hans

> 
> ----------------------------------------------------------------
> Dikshita Agarwal (26):
>       media: iris: Fix buffer count reporting in internal buffer check
>       media: iris: Report unreleased PERSIST buffers on session close
>       media: iris: Fix memory leak by freeing untracked persist buffer
>       media: iris: Fix port streaming handling
>       media: iris: Allow substate transition to load resources during output streaming
>       media: iris: Always destroy internal buffers on firmware release response
>       media: iris: Update vbuf flags before v4l2_m2m_buf_done
>       media: iris: Simplify session stop logic by relying on vb2 checks
>       media: iris: Allow stop on firmware only if start was issued.
>       media: iris: Send dummy buffer address for all codecs during drain
>       media: iris: Fix missing LAST flag handling during drain
>       media: iris: Fix format check for CAPTURE plane in try_fmt
>       media: iris: Add support for video encoder device
>       media: iris: Initialize and deinitialize encoder instance structure
>       media: iris: Add support for ENUM_FMT, S/G/TRY_FMT encoder
>       media: iris: Add support for ENUM_FRAMESIZES/FRAMEINTERVALS for encoder
>       media: iris: Add support for VIDIOC_QUERYCAP for encoder video device
>       media: iris: Add encoder support for V4L2 event subscription
>       media: iris: Add support for G/S_SELECTION for encoder video device
>       media: iris: Add support for G/S_PARM for encoder video device
>       media: iris: Add platform-specific capabilities for encoder video device
>       media: iris: Add V4L2 streaming support for encoder video device
>       media: iris: Set platform capabilities to firmware for encoder video device
>       media: iris: Allocate and queue internal buffers for encoder video device
>       media: iris: Add support for buffer management ioctls for encoder device
>       media: iris: Add support for drain sequence in encoder video device
> 
> Neil Armstrong (1):
>       media: iris: add VPU33 specific encoding buffer calculation
> 
>  drivers/media/platform/qcom/iris/Makefile          |   5 +-
>  drivers/media/platform/qcom/iris/iris_buffer.c     | 222 ++++-
>  drivers/media/platform/qcom/iris/iris_buffer.h     |   7 +-
>  drivers/media/platform/qcom/iris/iris_common.c     | 232 ++++++
>  drivers/media/platform/qcom/iris/iris_common.h     |  18 +
>  drivers/media/platform/qcom/iris/iris_core.h       |  20 +-
>  drivers/media/platform/qcom/iris/iris_ctrls.c      | 675 ++++++++++++++-
>  drivers/media/platform/qcom/iris/iris_ctrls.h      |  15 +
>  drivers/media/platform/qcom/iris/iris_hfi_common.h |   2 +-
>  .../platform/qcom/iris/iris_hfi_gen1_command.c     | 482 ++++++++---
>  .../platform/qcom/iris/iris_hfi_gen1_defines.h     | 112 ++-
>  .../platform/qcom/iris/iris_hfi_gen1_response.c    |  60 +-
>  .../platform/qcom/iris/iris_hfi_gen2_command.c     | 359 +++++---
>  .../platform/qcom/iris/iris_hfi_gen2_defines.h     |  44 +-
>  .../platform/qcom/iris/iris_hfi_gen2_response.c    |  46 +-
>  drivers/media/platform/qcom/iris/iris_instance.h   |  24 +
>  .../platform/qcom/iris/iris_platform_common.h      |  76 +-
>  .../media/platform/qcom/iris/iris_platform_gen2.c  | 526 +++++++++++-
>  .../platform/qcom/iris/iris_platform_qcs8300.h     | 352 +++++++-
>  .../platform/qcom/iris/iris_platform_sm8250.c      | 236 +++++-
>  drivers/media/platform/qcom/iris/iris_probe.c      |  33 +-
>  drivers/media/platform/qcom/iris/iris_state.c      |   9 +-
>  drivers/media/platform/qcom/iris/iris_state.h      |   1 +
>  drivers/media/platform/qcom/iris/iris_utils.c      |  36 +
>  drivers/media/platform/qcom/iris/iris_utils.h      |   2 +
>  drivers/media/platform/qcom/iris/iris_vb2.c        |  58 +-
>  drivers/media/platform/qcom/iris/iris_vdec.c       | 251 +-----
>  drivers/media/platform/qcom/iris/iris_vdec.h       |  13 +-
>  drivers/media/platform/qcom/iris/iris_venc.c       | 579 +++++++++++++
>  drivers/media/platform/qcom/iris/iris_venc.h       |  27 +
>  drivers/media/platform/qcom/iris/iris_vidc.c       | 299 ++++++-
>  drivers/media/platform/qcom/iris/iris_vpu_buffer.c | 922 ++++++++++++++++++++-
>  drivers/media/platform/qcom/iris/iris_vpu_buffer.h |  24 +-
>  33 files changed, 5051 insertions(+), 716 deletions(-)
>  create mode 100644 drivers/media/platform/qcom/iris/iris_common.c
>  create mode 100644 drivers/media/platform/qcom/iris/iris_common.h
>  create mode 100644 drivers/media/platform/qcom/iris/iris_venc.c
>  create mode 100644 drivers/media/platform/qcom/iris/iris_venc.h
> 


      reply	other threads:[~2025-09-09 12:07 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-09  9:42 [GIT PULL FOR 6.18] Please pull platform-qcom-iris-encoder-plus-dependent-fixes-for-6.18-v2 bod
2025-09-09 12:07 ` Hans Verkuil [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=951b925e-3d0f-4016-a45e-e1b4ccf5f3fc@kernel.org \
    --to=hverkuil+cisco@kernel.org \
    --cc=bod@kernel.org \
    --cc=bryan.odonoghue@linaro.org \
    --cc=linux-media@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.