Re: [PATCH v2 2/3] arm64: dts: qcom: qcs9100: Update memory map

[Krzysztof Kozlowski <krzk@kernel.org>]

On 13/01/2025 13:13, Pratyush Brahma wrote:
> Update the iot specific memory map for qcs9100* boards.
> 
> Signed-off-by: Pratyush Brahma <quic_pbrahma@quicinc.com>
> ---
>  arch/arm64/boot/dts/qcom/qcs9100-ride-r3.dts | 2 ++
>  arch/arm64/boot/dts/qcom/qcs9100-ride.dts    | 2 ++
>  2 files changed, 4 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/qcs9100-ride-r3.dts b/arch/arm64/boot/dts/qcom/qcs9100-ride-r3.dts
> index 759d1ec694b20e9cead674c1bd61c6a6627eeb27..06e57239bbe975b9c0b939d438095692243e39cf 100644
> --- a/arch/arm64/boot/dts/qcom/qcs9100-ride-r3.dts
> +++ b/arch/arm64/boot/dts/qcom/qcs9100-ride-r3.dts
> @@ -5,6 +5,8 @@
>  /dts-v1/;
>  
>  #include "sa8775p-ride-r3.dts"
> +#include "sa8775p-iot.dtsi"

No. Either this is car or iot. Cannot be both.

In other threads I already complained you add some artificial split of
DTS/DTSI and not describing the hardware. This is another example of
that - you claim you have automotive board, which is derived from
automotive board, but it is not automotive and instead it is iot.

Decide about all this and come with DTS/DTSI structure reflecting actual
hardware, not how you want to organize your device nodes.

Best regards,
Krzysztof