From: Thomas Monjalon <thomas@monjalon.net>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: dev@dpdk.org, Stephen Hemminger <stephen@networkplumber.org>,
Reshma Pattan <reshma.pattan@intel.com>,
Bruce Richardson <bruce.richardson@intel.com>,
Khadem Ullah <14pwcse1224@uetpeshawar.edu.pk>
Subject: Re: [PATCH 2/2] pdump: fix race in pdump disabling
Date: Wed, 19 Nov 2025 04:29:51 +0100 [thread overview]
Message-ID: <9567436.NyiUUSuA9g@thomas> (raw)
In-Reply-To: <20251112200510.332651-2-stephen@networkplumber.org>
12/11/2025 21:05, Stephen Hemminger:
> There is a race where the request to disable pdump may get ahead
> of the handling of pdump requests in dumpcap. The fix is to do
> local removal of callbacks before forwarding same to secondary.
>
> To reproduce:
> 1. Start testpmd and start traffic
> 2. Start dumpcap to capture
> 3. Interrupt dumpcap with ^C
>
> Testpmd will show missing response and dumpcap will show error:
> EAL: Cannot find action: mp_pdump
>
> Only reproducible if additional logging not enabled.
>
> Fixes: c3ceb8742295 ("pdump: forward callback enable to secondary process")
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Applied, thanks.
prev parent reply other threads:[~2025-11-19 3:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-12 20:05 [PATCH 1/2] pdump: avoid integer issues Stephen Hemminger
2025-11-12 20:05 ` [PATCH 2/2] pdump: fix race in pdump disabling Stephen Hemminger
2025-11-19 3:29 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9567436.NyiUUSuA9g@thomas \
--to=thomas@monjalon.net \
--cc=14pwcse1224@uetpeshawar.edu.pk \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=reshma.pattan@intel.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.