From: Thomas Monjalon <thomas@monjalon.net>
To: Raslan Darawsheh <rasland@mellanox.com>
Cc: dev@dpdk.org, shahafs@mellanox.com, orika@mellanox.com
Subject: Re: [PATCH v2] examples/client_server_mp: add sigint handler to server
Date: Thu, 27 Sep 2018 13:36:06 +0200 [thread overview]
Message-ID: <9568922.17cOiG4SW6@xps> (raw)
In-Reply-To: <1538047613-27309-1-git-send-email-rasland@mellanox.com>
27/09/2018 13:26, Raslan Darawsheh:
> v2:
> - fix includes order
I'm afraid you will need a v3 to fix spacing :)
> --- a/examples/multi_process/client_server_mp/mp_server/main.c
> +++ b/examples/multi_process/client_server_mp/mp_server/main.c
> @@ -37,6 +37,7 @@
> #include "common.h"
> #include "args.h"
> #include "init.h"
> +#include<signal.h>
A space is missing here.
> +static void signal_handler(int signal)
> +{
> + uint16_t port_id;
> +
> + if (signal == SIGINT)
> + RTE_ETH_FOREACH_DEV(port_id) {
> + rte_eth_dev_stop(port_id);
> + rte_eth_dev_close(port_id);
> + }
> + exit(0);
> +}
> int
> main(int argc, char *argv[])
A blank line is missing between the functions.
next prev parent reply other threads:[~2018-09-27 11:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-27 11:26 [PATCH v2] examples/client_server_mp: add sigint handler to server Raslan Darawsheh
2018-09-27 11:36 ` Thomas Monjalon [this message]
2018-09-27 12:30 ` Bruce Richardson
2018-09-27 12:48 ` Thomas Monjalon
2018-09-27 14:37 ` Bruce Richardson
2018-09-27 11:51 ` [PATCH v3] " Raslan Darawsheh
2018-11-04 20:42 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9568922.17cOiG4SW6@xps \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=orika@mellanox.com \
--cc=rasland@mellanox.com \
--cc=shahafs@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.