From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AF916C433EF for ; Wed, 22 Jun 2022 04:39:42 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 3AC2B40C59; Wed, 22 Jun 2022 04:39:42 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 3AC2B40C59 Authentication-Results: smtp2.osuosl.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=cC+D2yO4 X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id xHiloUTciyUT; Wed, 22 Jun 2022 04:39:41 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [IPv6:2605:bc80:3010:104::8cd3:938]) by smtp2.osuosl.org (Postfix) with ESMTPS id C37B3400DD; Wed, 22 Jun 2022 04:39:40 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org C37B3400DD Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 85DF6C0039; Wed, 22 Jun 2022 04:39:40 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136]) by lists.linuxfoundation.org (Postfix) with ESMTP id 6FB0CC002D for ; Wed, 22 Jun 2022 04:39:39 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 240E161226 for ; Wed, 22 Jun 2022 04:39:39 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 240E161226 Authentication-Results: smtp3.osuosl.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=cC+D2yO4 X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id A4-7xd-RpPWs for ; Wed, 22 Jun 2022 04:39:38 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 5DB5D61052 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by smtp3.osuosl.org (Postfix) with ESMTPS id 5DB5D61052 for ; Wed, 22 Jun 2022 04:39:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1655872778; x=1687408778; h=message-id:date:mime-version:cc:subject:to:references: from:in-reply-to:content-transfer-encoding; bh=AMhZegtFWYVx//Lb0JAJ2PWASXQIxUvUTb3GUIaBbv8=; b=cC+D2yO49b41AToNl7cg1a9DabVtd4/Duvv8LbUAW9F2PmiURuTnEDe4 CURD9/6c/3rSLhcga3S/YXzfYXdbDYlU2e4HdRtxAZmJOosEA1xGl8KZt f34DYTQD4xWelayvDO5Tmh0CdBvTBvdqUmm4rhoJgi99bH2Sqf3x4+K6w 32x268QSrtqV3l2w0jiybU5OU+NJhzDqdOGiZPmQK6B4xL/opF40qIGEF tOSAKq0Lplc+a0L7r0ZIfoRAXAC102siXDmgzhIC/x+vS3KivWVqR7oaF GoTgTTEaClDtq5Rhbe7jHPfEPctOaZDmfL0HZlVKarxGQgle0cTg8KPId Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10385"; a="280357876" X-IronPort-AV: E=Sophos;i="5.92,211,1650956400"; d="scan'208";a="280357876" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Jun 2022 21:39:37 -0700 X-IronPort-AV: E=Sophos;i="5.92,211,1650956400"; d="scan'208";a="833905619" Received: from xzhan99-mobl1.ccr.corp.intel.com (HELO [10.249.172.26]) ([10.249.172.26]) by fmsmga006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Jun 2022 21:39:35 -0700 Message-ID: <95845c03-d191-7228-c83f-92f5589a70db@linux.intel.com> Date: Wed, 22 Jun 2022 12:39:34 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH 1/1] iommu/vt-d: Fix RID2PASID setup failure Content-Language: en-US To: "Tian, Kevin" , Joerg Roedel , "Raj, Ashok" References: <20220620081729.4610-1-baolu.lu@linux.intel.com> <5d13cab5-1f0a-51c7-78a3-fb5d3d793ab1@linux.intel.com> <80457871-a760-69ba-70be-5e95344182ea@linux.intel.com> <4316fa3e-3183-beb0-9c4a-d6045c6b5340@linux.intel.com> From: Baolu Lu In-Reply-To: Cc: "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" , "Qiang, Chenyi" , "iommu@lists.linux-foundation.org" , "Pan, Jacob jun" X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" T24gMjAyMi82LzIyIDExOjMxLCBUaWFuLCBLZXZpbiB3cm90ZToKPj4gRnJvbTogQmFvbHUgTHUg PGJhb2x1Lmx1QGxpbnV4LmludGVsLmNvbT4KPj4gU2VudDogV2VkbmVzZGF5LCBKdW5lIDIyLCAy MDIyIDExOjI4IEFNCj4+Cj4+IE9uIDIwMjIvNi8yMiAxMTowNiwgVGlhbiwgS2V2aW4gd3JvdGU6 Cj4+Pj4gRnJvbTogQmFvbHUgTHU8YmFvbHUubHVAbGludXguaW50ZWwuY29tPgo+Pj4+IFNlbnQ6 IFR1ZXNkYXksIEp1bmUgMjEsIDIwMjIgNTowNCBQTQo+Pj4+Cj4+Pj4gT24gMjAyMi82LzIxIDEz OjQ4LCBUaWFuLCBLZXZpbiB3cm90ZToKPj4+Pj4+IEZyb206IEJhb2x1IEx1PGJhb2x1Lmx1QGxp bnV4LmludGVsLmNvbT4KPj4+Pj4+IFNlbnQ6IFR1ZXNkYXksIEp1bmUgMjEsIDIwMjIgMTI6Mjgg UE0KPj4+Pj4+Cj4+Pj4+PiBPbiAyMDIyLzYvMjEgMTE6NDYsIFRpYW4sIEtldmluIHdyb3RlOgo+ Pj4+Pj4+PiBGcm9tOiBCYW9sdSBMdTxiYW9sdS5sdUBsaW51eC5pbnRlbC5jb20+Cj4+Pj4+Pj4+ IFNlbnQ6IFR1ZXNkYXksIEp1bmUgMjEsIDIwMjIgMTE6MzkgQU0KPj4+Pj4+Pj4KPj4+Pj4+Pj4g T24gMjAyMi82LzIxIDEwOjU0LCBUaWFuLCBLZXZpbiB3cm90ZToKPj4+Pj4+Pj4+PiBGcm9tOiBM dSBCYW9sdTxiYW9sdS5sdUBsaW51eC5pbnRlbC5jb20+Cj4+Pj4+Pj4+Pj4gU2VudDogTW9uZGF5 LCBKdW5lIDIwLCAyMDIyIDQ6MTcgUE0KPj4+Pj4+Pj4+PiBAQCAtMjU2NCw3ICsyNTY0LDcgQEAg c3RhdGljIGludCBkb21haW5fYWRkX2Rldl9pbmZvKHN0cnVjdAo+Pj4+Pj4+Pj4+IGRtYXJfZG9t YWluICpkb21haW4sIHN0cnVjdCBkZXZpY2UgKmRldikKPj4+Pj4+Pj4+PiAgICAgICAJCQlyZXQg PSBpbnRlbF9wYXNpZF9zZXR1cF9zZWNvbmRfbGV2ZWwoaW9tbXUsCj4+Pj4+Pj4+Pj4gZG9tYWlu LAo+Pj4+Pj4+Pj4+ICAgICAgIAkJCQkJZGV2LCBQQVNJRF9SSUQyUEFTSUQpOwo+Pj4+Pj4+Pj4+ ICAgICAgIAkJc3Bpbl91bmxvY2tfaXJxcmVzdG9yZSgmaW9tbXUtPmxvY2ssIGZsYWdzKTsKPj4+ Pj4+Pj4+PiAtCQlpZiAocmV0KSB7Cj4+Pj4+Pj4+Pj4gKwkJaWYgKHJldCAmJiByZXQgIT0gLUVC VVNZKSB7Cj4+Pj4+Pj4+Pj4gICAgICAgCQkJZGV2X2VycihkZXYsICJTZXR1cCBSSUQyUEFTSUQg ZmFpbGVkXG4iKTsKPj4+Pj4+Pj4+PiAgICAgICAJCQlkbWFyX3JlbW92ZV9vbmVfZGV2X2luZm8o ZGV2KTsKPj4+Pj4+Pj4+PiAgICAgICAJCQlyZXR1cm4gcmV0Owo+Pj4+Pj4+Pj4+IC0tCj4+Pj4+ Pj4+Pj4gMi4yNS4xCj4+Pj4+Pj4+PiBJdCdzIGNsZWFuZXIgdG8gYXZvaWQgdGhpcyBlcnJvciBh dCB0aGUgZmlyc3QgcGxhY2UsIGkuZS4gb25seSBkbyB0aGUKPj4+Pj4+Pj4+IHNldHVwIHdoZW4g dGhlIGZpcnN0IGRldmljZSBpcyBhdHRhY2hlZCB0byB0aGUgcGFzaWQgdGFibGUuCj4+Pj4+Pj4+ IFRoZSBsb2dpYyB0aGF0IGlkZW50aWZpZXMgdGhlIGZpcnN0IGRldmljZSBtaWdodCBpbnRyb2R1 Y2UgYWRkaXRpb25hbAo+Pj4+Pj4+PiB1bm5lY2Vzc2FyeSBjb21wbGV4aXR5LiBEZXZpY2VzIHRo YXQgc2hhcmUgYSBwYXNpZCB0YWJsZSBhcmUgcmFyZS4gSQo+Pj4+Pj4+PiBldmVuIHByZWZlciB0 byBnaXZlIHVwIHNoYXJpbmcgdGFibGVzIHNvIHRoYXQgdGhlIGNvZGUgY2FuIGJlCj4+Pj4+Pj4+ IHNpbXBsZXIuOi0pCj4+Pj4+Pj4+Cj4+Pj4+Pj4gSXQncyBub3QgdGhhdCBjb21wbGV4IGlmIHlv dSBzaW1wbHkgbW92ZSBkZXZpY2VfYXR0YWNoX3Bhc2lkX3RhYmxlKCkKPj4+Pj4+PiBvdXQgb2Yg aW50ZWxfcGFzaWRfYWxsb2NfdGFibGUoKS4gVGhlbiBkbyB0aGUgc2V0dXAgaWYKPj4+Pj4+PiBs aXN0X2VtcHR5KCZwYXNpZF90YWJsZS0+ZGV2KSBhbmQgdGhlbiBhdHRhY2ggZGV2aWNlIHRvIHRo ZQo+Pj4+Pj4+IHBhc2lkIHRhYmxlIGluIGRvbWFpbl9hZGRfZGV2X2luZm8oKS4KPj4+Pj4+IFRo ZSBwYXNpZCB0YWJsZSBpcyBwYXJ0IG9mIHRoZSBkZXZpY2UsIGhlbmNlIGEgYmV0dGVyIHBsYWNl IHRvCj4+Pj4+PiBhbGxvY2F0ZS9mcmVlIHRoZSBwYXNpZCB0YWJsZSBpcyBpbiB0aGUgZGV2aWNl IHByb2JlL3JlbGVhc2UgcGF0aHMuCj4+Pj4+PiBUaGluZ3Mgd2lsbCBiZWNvbWUgbW9yZSBjb21w bGljYXRlZCBpZiB3ZSBjaGFuZ2UgcmVsYXRpb25zaGlwCj4+IGJldHdlZW4KPj4+Pj4+IGRldmlj ZSBhbmQgaXQncyBwYXNpZCB0YWJsZSB3aGVuIGF0dGFjaGluZy9kZXRhY2hpbmcgYSBkb21haW4u IFRoYXQncwo+Pj4+Pj4gdGhlIHJlYXNvbiB3aHkgSSB0aG91Z2h0IGl0IHdhcyBhZGRpdGlvbmFs IGNvbXBsZXhpdHkuCj4+Pj4+Pgo+Pj4+PiBJZiB5b3UgZG8gd2FudCB0byBmb2xsb3cgY3VycmVu dCByb3V0ZSBpdOKAmXMgc3RpbGwgY2xlYW5lciB0byBjaGVjawo+Pj4+PiB3aGV0aGVyIHRoZSBw YXNpZCBlbnRyeSBoYXMgcG9pbnRlZCB0byB0aGUgZG9tYWluIGluIHRoZSBpbmRpdmlkdWFsCj4+ Pj4+IHNldHVwIGZ1bmN0aW9uIGluc3RlYWQgb2YgYmxpbmRseSByZXR1cm5pbmcgLUVCVVNZIGFu ZCB0aGVuIGlnbm9yaW5nCj4+Pj4+IGl0IGV2ZW4gaWYgYSByZWFsIGJ1c3kgY29uZGl0aW9uIG9j Y3Vycy4gVGhlIHNldHVwIGZ1bmN0aW9ucyBjYW4KPj4+Pj4ganVzdCByZXR1cm4gemVybyBmb3Ig dGhpcyBiZW5pZ24gYWxpYXMgY2FzZS4KPj4+PiBLZXZpbiwgaG93IGRvIHlvdSBsaWtlIHRoaXMg b25lPwo+Pj4+Cj4+Pj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvaW9tbXUvaW50ZWwvcGFzaWQuYyBi L2RyaXZlcnMvaW9tbXUvaW50ZWwvcGFzaWQuYwo+Pj4+IGluZGV4IGNiNGMxZDBjZjI1Yy4uZWNm ZmQwMTI5YjJiIDEwMDY0NAo+Pj4+IC0tLSBhL2RyaXZlcnMvaW9tbXUvaW50ZWwvcGFzaWQuYwo+ Pj4+ICsrKyBiL2RyaXZlcnMvaW9tbXUvaW50ZWwvcGFzaWQuYwo+Pj4+IEBAIC01NzUsNiArNTc1 LDE2IEBAIHN0YXRpYyBpbmxpbmUgaW50IHBhc2lkX2VuYWJsZV93cGUoc3RydWN0Cj4+Pj4gcGFz aWRfZW50cnkgKnB0ZSkKPj4+PiAgICAgCXJldHVybiAwOwo+Pj4+ICAgICB9Owo+Pj4+Cj4+Pj4g Ky8qCj4+Pj4gKyAqIFJldHVybiB0cnVlIGlmIEBwYXNpZCBpcyBSSUQyUEFTSUQgYW5kIHRoZSBk b21haW4gQGRpZCBoYXMgYWxyZWFkeQo+Pj4+ICsgKiBiZWVuIHNldHVwIHRvIHRoZSBAcHRlLiBP dGhlcndpc2UsIHJldHVybiBmYWxzZS4KPj4+PiArICovCj4+Pj4gK3N0YXRpYyBpbmxpbmUgYm9v bAo+Pj4+ICtyaWQycGFzaWRfZG9tYWluX3ZhbGlkKHN0cnVjdCBwYXNpZF9lbnRyeSAqcHRlLCB1 MzIgcGFzaWQsIHUxNiBkaWQpCj4+Pj4gK3sKPj4+PiArCXJldHVybiBwYXNpZCA9PSBQQVNJRF9S SUQyUEFTSUQgJiYgcGFzaWRfZ2V0X2RvbWFpbl9pZChwdGUpID09Cj4+Pj4gZGlkOwo+Pj4+ICt9 Cj4+PiBiZXR0ZXIgdGhpcyBpcyBub3QgcmVzdHJpY3RlZCB0byBSSUQyUEFTSUQgb25seSwgZS5n Lgo+PiBwYXNpZF9wdGVfbWF0Y2hfZG9tYWluKCkKPj4+IGFuZCB0aGVuIHJlYWQgcGFzaWQgZnJv bSB0aGUgcHRlIHRvIGNvbXBhcmUgd2l0aCB0aGUgcGFzaWQgYXJndW1lbnQuCj4+Pgo+Pgo+PiBU aGUgcGFzaWQgdmFsdWUgaXMgbm90IGVuY29kZWQgaW4gdGhlIHBhc2lkIHRhYmxlIGVudHJ5LiBU aGlzIHZhbGlkaXR5Cj4+IGNoZWNrIGlzIG9ubHkgZm9yIFJJRDJQQVNJRCBhcyBhbGlhcyBkZXZp Y2VzIHNoYXJlIHRoZSBzaW5nbGUgUklEMlBBU0lECj4+IGVudHJ5LiBGb3Igb3RoZXIgY2FzZXMs IHdlIHNob3VsZCBhbHdheXMgcmV0dXJuIC1FQlVTWSBhcyB3aGF0IHRoZSBjb2RlCj4+IGlzIGRv aW5nIG5vdy4KPj4KPiAKPiBZb3UgYXJlIHJpZ2h0LgoKVmVyeSBhcHByZWNpYXRlZCBmb3IgeW91 ciBpbnB1dC4gSSB3aWxsIHVwZGF0ZSBpdCB3aXRoIGEgdjIuCgpCZXN0IHJlZ2FyZHMsCmJhb2x1 Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmlvbW11IG1h aWxpbmcgbGlzdAppb21tdUBsaXN0cy5saW51eC1mb3VuZGF0aW9uLm9yZwpodHRwczovL2xpc3Rz LmxpbnV4Zm91bmRhdGlvbi5vcmcvbWFpbG1hbi9saXN0aW5mby9pb21tdQ== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C09FC43334 for ; Wed, 22 Jun 2022 04:39:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1356874AbiFVEjk (ORCPT ); Wed, 22 Jun 2022 00:39:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34538 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1356770AbiFVEjk (ORCPT ); Wed, 22 Jun 2022 00:39:40 -0400 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7760634BB1; Tue, 21 Jun 2022 21:39:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1655872778; x=1687408778; h=message-id:date:mime-version:cc:subject:to:references: from:in-reply-to:content-transfer-encoding; bh=AMhZegtFWYVx//Lb0JAJ2PWASXQIxUvUTb3GUIaBbv8=; b=cC+D2yO49b41AToNl7cg1a9DabVtd4/Duvv8LbUAW9F2PmiURuTnEDe4 CURD9/6c/3rSLhcga3S/YXzfYXdbDYlU2e4HdRtxAZmJOosEA1xGl8KZt f34DYTQD4xWelayvDO5Tmh0CdBvTBvdqUmm4rhoJgi99bH2Sqf3x4+K6w 32x268QSrtqV3l2w0jiybU5OU+NJhzDqdOGiZPmQK6B4xL/opF40qIGEF tOSAKq0Lplc+a0L7r0ZIfoRAXAC102siXDmgzhIC/x+vS3KivWVqR7oaF GoTgTTEaClDtq5Rhbe7jHPfEPctOaZDmfL0HZlVKarxGQgle0cTg8KPId Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10385"; a="344302209" X-IronPort-AV: E=Sophos;i="5.92,211,1650956400"; d="scan'208";a="344302209" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Jun 2022 21:39:38 -0700 X-IronPort-AV: E=Sophos;i="5.92,211,1650956400"; d="scan'208";a="833905619" Received: from xzhan99-mobl1.ccr.corp.intel.com (HELO [10.249.172.26]) ([10.249.172.26]) by fmsmga006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Jun 2022 21:39:35 -0700 Message-ID: <95845c03-d191-7228-c83f-92f5589a70db@linux.intel.com> Date: Wed, 22 Jun 2022 12:39:34 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Cc: baolu.lu@linux.intel.com, "Qiang, Chenyi" , "Liu, Yi L" , "Pan, Jacob jun" , "iommu@lists.linux-foundation.org" , "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" Subject: Re: [PATCH 1/1] iommu/vt-d: Fix RID2PASID setup failure Content-Language: en-US To: "Tian, Kevin" , Joerg Roedel , "Raj, Ashok" References: <20220620081729.4610-1-baolu.lu@linux.intel.com> <5d13cab5-1f0a-51c7-78a3-fb5d3d793ab1@linux.intel.com> <80457871-a760-69ba-70be-5e95344182ea@linux.intel.com> <4316fa3e-3183-beb0-9c4a-d6045c6b5340@linux.intel.com> From: Baolu Lu In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On 2022/6/22 11:31, Tian, Kevin wrote: >> From: Baolu Lu >> Sent: Wednesday, June 22, 2022 11:28 AM >> >> On 2022/6/22 11:06, Tian, Kevin wrote: >>>> From: Baolu Lu >>>> Sent: Tuesday, June 21, 2022 5:04 PM >>>> >>>> On 2022/6/21 13:48, Tian, Kevin wrote: >>>>>> From: Baolu Lu >>>>>> Sent: Tuesday, June 21, 2022 12:28 PM >>>>>> >>>>>> On 2022/6/21 11:46, Tian, Kevin wrote: >>>>>>>> From: Baolu Lu >>>>>>>> Sent: Tuesday, June 21, 2022 11:39 AM >>>>>>>> >>>>>>>> On 2022/6/21 10:54, Tian, Kevin wrote: >>>>>>>>>> From: Lu Baolu >>>>>>>>>> Sent: Monday, June 20, 2022 4:17 PM >>>>>>>>>> @@ -2564,7 +2564,7 @@ static int domain_add_dev_info(struct >>>>>>>>>> dmar_domain *domain, struct device *dev) >>>>>>>>>> ret = intel_pasid_setup_second_level(iommu, >>>>>>>>>> domain, >>>>>>>>>> dev, PASID_RID2PASID); >>>>>>>>>> spin_unlock_irqrestore(&iommu->lock, flags); >>>>>>>>>> - if (ret) { >>>>>>>>>> + if (ret && ret != -EBUSY) { >>>>>>>>>> dev_err(dev, "Setup RID2PASID failed\n"); >>>>>>>>>> dmar_remove_one_dev_info(dev); >>>>>>>>>> return ret; >>>>>>>>>> -- >>>>>>>>>> 2.25.1 >>>>>>>>> It's cleaner to avoid this error at the first place, i.e. only do the >>>>>>>>> setup when the first device is attached to the pasid table. >>>>>>>> The logic that identifies the first device might introduce additional >>>>>>>> unnecessary complexity. Devices that share a pasid table are rare. I >>>>>>>> even prefer to give up sharing tables so that the code can be >>>>>>>> simpler.:-) >>>>>>>> >>>>>>> It's not that complex if you simply move device_attach_pasid_table() >>>>>>> out of intel_pasid_alloc_table(). Then do the setup if >>>>>>> list_empty(&pasid_table->dev) and then attach device to the >>>>>>> pasid table in domain_add_dev_info(). >>>>>> The pasid table is part of the device, hence a better place to >>>>>> allocate/free the pasid table is in the device probe/release paths. >>>>>> Things will become more complicated if we change relationship >> between >>>>>> device and it's pasid table when attaching/detaching a domain. That's >>>>>> the reason why I thought it was additional complexity. >>>>>> >>>>> If you do want to follow current route it’s still cleaner to check >>>>> whether the pasid entry has pointed to the domain in the individual >>>>> setup function instead of blindly returning -EBUSY and then ignoring >>>>> it even if a real busy condition occurs. The setup functions can >>>>> just return zero for this benign alias case. >>>> Kevin, how do you like this one? >>>> >>>> diff --git a/drivers/iommu/intel/pasid.c b/drivers/iommu/intel/pasid.c >>>> index cb4c1d0cf25c..ecffd0129b2b 100644 >>>> --- a/drivers/iommu/intel/pasid.c >>>> +++ b/drivers/iommu/intel/pasid.c >>>> @@ -575,6 +575,16 @@ static inline int pasid_enable_wpe(struct >>>> pasid_entry *pte) >>>> return 0; >>>> }; >>>> >>>> +/* >>>> + * Return true if @pasid is RID2PASID and the domain @did has already >>>> + * been setup to the @pte. Otherwise, return false. >>>> + */ >>>> +static inline bool >>>> +rid2pasid_domain_valid(struct pasid_entry *pte, u32 pasid, u16 did) >>>> +{ >>>> + return pasid == PASID_RID2PASID && pasid_get_domain_id(pte) == >>>> did; >>>> +} >>> better this is not restricted to RID2PASID only, e.g. >> pasid_pte_match_domain() >>> and then read pasid from the pte to compare with the pasid argument. >>> >> >> The pasid value is not encoded in the pasid table entry. This validity >> check is only for RID2PASID as alias devices share the single RID2PASID >> entry. For other cases, we should always return -EBUSY as what the code >> is doing now. >> > > You are right. Very appreciated for your input. I will update it with a v2. Best regards, baolu