From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 601E2C61D9B for ; Wed, 22 Nov 2023 10:00:22 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.638610.995367 (Exim 4.92) (envelope-from ) id 1r5k1k-0000OZ-4a; Wed, 22 Nov 2023 10:00:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 638610.995367; Wed, 22 Nov 2023 10:00:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1r5k1j-0000OQ-Vo; Wed, 22 Nov 2023 10:00:11 +0000 Received: by outflank-mailman (input) for mailman id 638610; Wed, 22 Nov 2023 10:00:11 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1r5k1i-0007W3-W5 for xen-devel@lists.xenproject.org; Wed, 22 Nov 2023 10:00:10 +0000 Received: from mail-wm1-x32b.google.com (mail-wm1-x32b.google.com [2a00:1450:4864:20::32b]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ec0cff92-891d-11ee-98e1-6d05b1d4d9a1; Wed, 22 Nov 2023 11:00:10 +0100 (CET) Received: by mail-wm1-x32b.google.com with SMTP id 5b1f17b1804b1-40b31232bf0so4182885e9.1 for ; Wed, 22 Nov 2023 02:00:10 -0800 (PST) Received: from [192.168.1.10] (host-92-26-107-252.as13285.net. [92.26.107.252]) by smtp.gmail.com with ESMTPSA id v9-20020a05600c444900b0040836519dd9sm1680416wmn.25.2023.11.22.02.00.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 22 Nov 2023 02:00:09 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ec0cff92-891d-11ee-98e1-6d05b1d4d9a1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.com; s=google; t=1700647210; x=1701252010; darn=lists.xenproject.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=JwboJve+NnWYazpjvoy1l3Fmapvi/cNmoLbs/tPpc/k=; b=Z9ZzotFMd85RGcPGeP95JY3lQVLriIaaAcXxSqt7N2lU1/xNAl7CZpuy55dI5gobg+ DU4ysyaemQlcSMOT2RBztbexSIFgV405Res34viyGYBkwOX16mY9RJE9SCCCPwDkGe6W doiKe2fILEVSGqpPwhDW8Op4QRJ/39VNTvYw0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700647210; x=1701252010; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=JwboJve+NnWYazpjvoy1l3Fmapvi/cNmoLbs/tPpc/k=; b=AmlB5srDdbR429uWLSHZcLlc+T6JZADUVVVGTgx/uL5KNfRYyeOYNg/Kymic7s9qAf 2q56lrJA6uOAvmI1lLD01Phq+0zU6+MWWAUUD08PDJFuZ5ZG93aOWEmf6c7WTWJ/7xne Wa75phUy4I+2TOS4bBkr8uYFKlP1Ybz8lZli1ps9CG5ebzqModn+2JMZj21fLFUYrpMI u6FaUwgvoAXwOdhzY2v+Tm/PrLuRrFNmQQu8walJIrNZkS10G6tK30M3bXmu+solWtAW 1qlSGtv/5JlaFPl8L6W1LWVm0wVp2XtY6IiUi2bS9JlRuct4L5njKIZrjI1wtY6kDX3r iWfA== X-Gm-Message-State: AOJu0YypLB8HvYI+lX3HBsXKElY78h51tk64GLmywKcGSlmZ5O9A/0eN sc7zQRcCZvFFPmPSgJ/ffGQVCA== X-Google-Smtp-Source: AGHT+IGi2r/wxjkAgrOwDmC8y7eBdt+JyMNxUIeJjoIZvO8oWuRhssivOsm5N9QLla85bel8+vNkvQ== X-Received: by 2002:a05:600c:4295:b0:408:3a67:f6f5 with SMTP id v21-20020a05600c429500b004083a67f6f5mr1420780wmc.18.1700647209820; Wed, 22 Nov 2023 02:00:09 -0800 (PST) Message-ID: <95872c39-a375-4c0a-b22f-a0798634e86b@citrix.com> Date: Wed, 22 Nov 2023 10:00:09 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] stubdom: remove caml-stubdom Content-Language: en-GB To: Juergen Gross , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD , Samuel Thibault References: <20231101160837.32241-1-jgross@suse.com> <7b6658b4-cd36-4d52-991b-f4b94b6fb172@suse.com> From: Andrew Cooper Autocrypt: addr=andrew.cooper3@citrix.com; keydata= xsFNBFLhNn8BEADVhE+Hb8i0GV6mihnnr/uiQQdPF8kUoFzCOPXkf7jQ5sLYeJa0cQi6Penp VtiFYznTairnVsN5J+ujSTIb+OlMSJUWV4opS7WVNnxHbFTPYZVQ3erv7NKc2iVizCRZ2Kxn srM1oPXWRic8BIAdYOKOloF2300SL/bIpeD+x7h3w9B/qez7nOin5NzkxgFoaUeIal12pXSR Q354FKFoy6Vh96gc4VRqte3jw8mPuJQpfws+Pb+swvSf/i1q1+1I4jsRQQh2m6OTADHIqg2E ofTYAEh7R5HfPx0EXoEDMdRjOeKn8+vvkAwhviWXTHlG3R1QkbE5M/oywnZ83udJmi+lxjJ5 YhQ5IzomvJ16H0Bq+TLyVLO/VRksp1VR9HxCzItLNCS8PdpYYz5TC204ViycobYU65WMpzWe LFAGn8jSS25XIpqv0Y9k87dLbctKKA14Ifw2kq5OIVu2FuX+3i446JOa2vpCI9GcjCzi3oHV e00bzYiHMIl0FICrNJU0Kjho8pdo0m2uxkn6SYEpogAy9pnatUlO+erL4LqFUO7GXSdBRbw5 gNt25XTLdSFuZtMxkY3tq8MFss5QnjhehCVPEpE6y9ZjI4XB8ad1G4oBHVGK5LMsvg22PfMJ ISWFSHoF/B5+lHkCKWkFxZ0gZn33ju5n6/FOdEx4B8cMJt+cWwARAQABzSlBbmRyZXcgQ29v cGVyIDxhbmRyZXcuY29vcGVyM0BjaXRyaXguY29tPsLBegQTAQgAJAIbAwULCQgHAwUVCgkI CwUWAgMBAAIeAQIXgAUCWKD95wIZAQAKCRBlw/kGpdefoHbdD/9AIoR3k6fKl+RFiFpyAhvO 59ttDFI7nIAnlYngev2XUR3acFElJATHSDO0ju+hqWqAb8kVijXLops0gOfqt3VPZq9cuHlh IMDquatGLzAadfFx2eQYIYT+FYuMoPZy/aTUazmJIDVxP7L383grjIkn+7tAv+qeDfE+txL4 SAm1UHNvmdfgL2/lcmL3xRh7sub3nJilM93RWX1Pe5LBSDXO45uzCGEdst6uSlzYR/MEr+5Z JQQ32JV64zwvf/aKaagSQSQMYNX9JFgfZ3TKWC1KJQbX5ssoX/5hNLqxMcZV3TN7kU8I3kjK mPec9+1nECOjjJSO/h4P0sBZyIUGfguwzhEeGf4sMCuSEM4xjCnwiBwftR17sr0spYcOpqET ZGcAmyYcNjy6CYadNCnfR40vhhWuCfNCBzWnUW0lFoo12wb0YnzoOLjvfD6OL3JjIUJNOmJy RCsJ5IA/Iz33RhSVRmROu+TztwuThClw63g7+hoyewv7BemKyuU6FTVhjjW+XUWmS/FzknSi dAG+insr0746cTPpSkGl3KAXeWDGJzve7/SBBfyznWCMGaf8E2P1oOdIZRxHgWj0zNr1+ooF /PzgLPiCI4OMUttTlEKChgbUTQ+5o0P080JojqfXwbPAyumbaYcQNiH1/xYbJdOFSiBv9rpt TQTBLzDKXok86M7BTQRS4TZ/ARAAkgqudHsp+hd82UVkvgnlqZjzz2vyrYfz7bkPtXaGb9H4 Rfo7mQsEQavEBdWWjbga6eMnDqtu+FC+qeTGYebToxEyp2lKDSoAsvt8w82tIlP/EbmRbDVn 7bhjBlfRcFjVYw8uVDPptT0TV47vpoCVkTwcyb6OltJrvg/QzV9f07DJswuda1JH3/qvYu0p vjPnYvCq4NsqY2XSdAJ02HrdYPFtNyPEntu1n1KK+gJrstjtw7KsZ4ygXYrsm/oCBiVW/OgU g/XIlGErkrxe4vQvJyVwg6YH653YTX5hLLUEL1NS4TCo47RP+wi6y+TnuAL36UtK/uFyEuPy wwrDVcC4cIFhYSfsO0BumEI65yu7a8aHbGfq2lW251UcoU48Z27ZUUZd2Dr6O/n8poQHbaTd 6bJJSjzGGHZVbRP9UQ3lkmkmc0+XCHmj5WhwNNYjgbbmML7y0fsJT5RgvefAIFfHBg7fTY/i kBEimoUsTEQz+N4hbKwo1hULfVxDJStE4sbPhjbsPCrlXf6W9CxSyQ0qmZ2bXsLQYRj2xqd1 bpA+1o1j2N4/au1R/uSiUFjewJdT/LX1EklKDcQwpk06Af/N7VZtSfEJeRV04unbsKVXWZAk uAJyDDKN99ziC0Wz5kcPyVD1HNf8bgaqGDzrv3TfYjwqayRFcMf7xJaL9xXedMcAEQEAAcLB XwQYAQgACQUCUuE2fwIbDAAKCRBlw/kGpdefoG4XEACD1Qf/er8EA7g23HMxYWd3FXHThrVQ HgiGdk5Yh632vjOm9L4sd/GCEACVQKjsu98e8o3ysitFlznEns5EAAXEbITrgKWXDDUWGYxd pnjj2u+GkVdsOAGk0kxczX6s+VRBhpbBI2PWnOsRJgU2n10PZ3mZD4Xu9kU2IXYmuW+e5KCA vTArRUdCrAtIa1k01sPipPPw6dfxx2e5asy21YOytzxuWFfJTGnVxZZSCyLUO83sh6OZhJkk b9rxL9wPmpN/t2IPaEKoAc0FTQZS36wAMOXkBh24PQ9gaLJvfPKpNzGD8XWR5HHF0NLIJhgg 4ZlEXQ2fVp3XrtocHqhu4UZR4koCijgB8sB7Tb0GCpwK+C4UePdFLfhKyRdSXuvY3AHJd4CP 4JzW0Bzq/WXY3XMOzUTYApGQpnUpdOmuQSfpV9MQO+/jo7r6yPbxT7CwRS5dcQPzUiuHLK9i nvjREdh84qycnx0/6dDroYhp0DFv4udxuAvt1h4wGwTPRQZerSm4xaYegEFusyhbZrI0U9tJ B8WrhBLXDiYlyJT6zOV2yZFuW47VrLsjYnHwn27hmxTC/7tvG3euCklmkn9Sl9IAKFu29RSo d5bD8kMSCYsTqtTfT6W4A3qHGvIDta3ptLYpIAOD2sY3GYq2nf3Bbzx81wZK14JdDDHUX2Rs 6+ahAA== In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 22/11/2023 7:20 am, Juergen Gross wrote: > On 21.11.23 22:14, Andrew Cooper wrote: >> On 20/11/2023 10:36 am, Juergen Gross wrote: >>> On 01.11.23 17:08, Juergen Gross wrote: >>>> In order to build caml-stubdom, it must be explicitly enabled via >>>> "configure --enable-caml-stubdom". The build process is failing due to >>>> stubdom/ocaml.patch failing to apply. Since the patched file has been >>>> modified in 2014 the last time, it seems nobody cares for caml-stubdom >>>> since at least then. >>>> >>>> Remove caml-stubdom from the build system. >>>> >>>> Signed-off-by: Juergen Gross >>> >>> Any comments? >> >> I'd say the tumbleweeds from the Ocaml folks says enough. >> >> Any chance you can resend with the Changelog adjustment, and with the >> option stripped out of ./configure ?  Might as well clean up everything >> as we go. > > I can do the Changelog adjustment, but I don't see what else could be > removed > from configure. The patch already _is_ removing the --enable-caml-stubdom > option from stubdom/configure. Oh, so it does.  I'd assumed it would be in the root ./configure. ~Andrew