Re: [PATCH linux-next v5 08/13] drivers/mfd: Add PECI client mfd driver

[Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>]

On 7/3/2018 11:42 PM, Lee Jones wrote:
> On Mon, 18 Jun 2018, Jae Hyun Yoo wrote:
>> On 6/17/2018 10:59 PM, Lee Jones wrote:
>>> On Thu, 14 Jun 2018, Jae Hyun Yoo wrote:
>>>
>>>> Thanks for the review. Please see my inline answers.
>>>>
>>>> On 6/12/2018 11:30 PM, Lee Jones wrote:
>>>>> On Fri, 01 Jun 2018, Jae Hyun Yoo wrote:
>>>>>
>>>>>> This commit adds PECI client mfd driver.
>>>>>>
>>>>>> Signed-off-by: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
>>>>>> Cc: Andrew Jeffery <andrew@aj.id.au>
>>>>>> Cc: James Feist <james.feist@linux.intel.com>
>>>>>> Cc: Jason M Biils <jason.m.bills@linux.intel.com>
>>>>>> Cc: Joel Stanley <joel@jms.id.au>
>>>>>> Cc: Vernon Mauery <vernon.mauery@linux.intel.com>
>>>>>> ---
>>>>>>     drivers/mfd/Kconfig             |  11 ++
>>>>>>     drivers/mfd/Makefile            |   1 +
>>>>>>     drivers/mfd/peci-client.c       | 205 ++++++++++++++++++++++++++++++++
>>>>>>     include/linux/mfd/peci-client.h |  60 ++++++++++
>>>>>>     4 files changed, 277 insertions(+)
>>>>>>     create mode 100644 drivers/mfd/peci-client.c
>>>>>>     create mode 100644 include/linux/mfd/peci-client.h
>>
>>> [...]
>>>
>>>>>> +static struct peci_driver peci_client_driver = {
>>>>>
>>>>> I'm pretty sure this will be NAKED by the platform Maintainer.
>>>>
>>>> Does it have problems? Can you please give me a hint?
>>>
>>> New bus types are usually only added for well defined, heavily used
>>> buses which AFAIK all have their own subsystems.  Why can't you use
>>> one of the existing bus types?  Platform is the most frequently used.
>>>
>>
>> I implemented this PECI drivers as a simple platform drivers in V1 but
>> I had to change it to follow other maintainers' suggestions. I believe
>> driver core maintainers are reviewing the PECI subsystem implementation
>> code in this patch set as well.
> 
> I don't see this discussion.  How is it progressing?
> 

v1:
https://lkml.org/lkml/2018/1/9/1088

v2:
https://lkml.org/lkml/2018/2/21/983

v3:
https://lkml.org/lkml/2018/4/10/750

v4:
https://lkml.org/lkml/2018/5/21/717

v5:
https://lkml.org/lkml/2018/6/1/732
https://lkml.org/lkml/2018/6/1/733
https://lkml.org/lkml/2018/6/1/734
https://lkml.org/lkml/2018/6/1/736
https://lkml.org/lkml/2018/6/1/737
https://lkml.org/lkml/2018/6/1/738
https://lkml.org/lkml/2018/6/1/740
https://lkml.org/lkml/2018/6/1/742
https://lkml.org/lkml/2018/6/1/743
https://lkml.org/lkml/2018/6/1/744
https://lkml.org/lkml/2018/6/1/745
https://lkml.org/lkml/2018/6/1/746
https://lkml.org/lkml/2018/6/1/747

v6:
https://lkml.org/lkml/2018/6/21/596

Thanks,

Jae