From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sebastian Hesselbarth Subject: Re: [PATCHv3 3/5] pinctrl: mvebu: pinctrl driver for 98DX3236 SoC Date: Wed, 11 Jan 2017 21:55:48 +0100 Message-ID: <95cb4240-e77b-5eaa-1920-4d9e26028038@gmail.com> References: <20170105033641.6212-1-chris.packham@alliedtelesis.co.nz> <20170106041517.9589-1-chris.packham@alliedtelesis.co.nz> <20170106041517.9589-4-chris.packham@alliedtelesis.co.nz> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Linus Walleij , Chris Packham , Gregory CLEMENT , Thomas Petazzoni Cc: Mark Rutland , "devicetree@vger.kernel.org" , "linux-gpio@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Kalyan Kinthada , Rob Herring , Laxman Dewangan , "linux-arm-kernel@lists.infradead.org" List-Id: linux-gpio@vger.kernel.org On 01/11/2017 03:44 PM, Linus Walleij wrote: > On Fri, Jan 6, 2017 at 5:15 AM, Chris Packham > wrote: > >> From: Kalyan Kinthada >> >> This pinctrl driver supports the 98DX3236, 98DX3336 and 98DX4251 SoCs >> from Marvell. >> >> Signed-off-by: Kalyan Kinthada >> Signed-off-by: Chris Packham > > I am waiting for an ACK or comment from the maintainers on > this patch. Sebastian? Sorry for the ignorance. I don't have the patch to reply to inline, but: - In the driver MPP_MODE2, spi0 there is a typo "csk" instead of "sck". - MPP_MODE5 binding "dev","bootcs" and driver "dev","bootcs0" differ. - MPP_MODE6 binding "gpio" and driver "gpo" differ. - MPP_MODE17 binding "dev","clk" and driver "dev","clkout" differ. - MPP_MODE19 binding mentiones "dev","rb" but driver does not. - MPP_MODE20 binding "gpio" and driver "gpo" differ. - MPP_MODE20 binding "dev","we" and driver "dev","we0" differ. - MPP_MODE21 through MPP_MODE30 binding "gpio" and driver "gpo" differ. - remove spaces before "0, 0" in mv98dx3236_mpp_gpio_ranges. Most of it is cosmetic stuff, so if you fix it feel free to add my Acked-by: Sebastian Hesselbarth Sebastian From mboxrd@z Thu Jan 1 00:00:00 1970 From: sebastian.hesselbarth@gmail.com (Sebastian Hesselbarth) Date: Wed, 11 Jan 2017 21:55:48 +0100 Subject: [PATCHv3 3/5] pinctrl: mvebu: pinctrl driver for 98DX3236 SoC In-Reply-To: References: <20170105033641.6212-1-chris.packham@alliedtelesis.co.nz> <20170106041517.9589-1-chris.packham@alliedtelesis.co.nz> <20170106041517.9589-4-chris.packham@alliedtelesis.co.nz> Message-ID: <95cb4240-e77b-5eaa-1920-4d9e26028038@gmail.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 01/11/2017 03:44 PM, Linus Walleij wrote: > On Fri, Jan 6, 2017 at 5:15 AM, Chris Packham > wrote: > >> From: Kalyan Kinthada >> >> This pinctrl driver supports the 98DX3236, 98DX3336 and 98DX4251 SoCs >> from Marvell. >> >> Signed-off-by: Kalyan Kinthada >> Signed-off-by: Chris Packham > > I am waiting for an ACK or comment from the maintainers on > this patch. Sebastian? Sorry for the ignorance. I don't have the patch to reply to inline, but: - In the driver MPP_MODE2, spi0 there is a typo "csk" instead of "sck". - MPP_MODE5 binding "dev","bootcs" and driver "dev","bootcs0" differ. - MPP_MODE6 binding "gpio" and driver "gpo" differ. - MPP_MODE17 binding "dev","clk" and driver "dev","clkout" differ. - MPP_MODE19 binding mentiones "dev","rb" but driver does not. - MPP_MODE20 binding "gpio" and driver "gpo" differ. - MPP_MODE20 binding "dev","we" and driver "dev","we0" differ. - MPP_MODE21 through MPP_MODE30 binding "gpio" and driver "gpo" differ. - remove spaces before "0, 0" in mv98dx3236_mpp_gpio_ranges. Most of it is cosmetic stuff, so if you fix it feel free to add my Acked-by: Sebastian Hesselbarth Sebastian From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759950AbdAKU41 (ORCPT ); Wed, 11 Jan 2017 15:56:27 -0500 Received: from mail-wj0-f196.google.com ([209.85.210.196]:35539 "EHLO mail-wj0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757884AbdAKUzx (ORCPT ); Wed, 11 Jan 2017 15:55:53 -0500 Subject: Re: [PATCHv3 3/5] pinctrl: mvebu: pinctrl driver for 98DX3236 SoC To: Linus Walleij , Chris Packham , Gregory CLEMENT , Thomas Petazzoni References: <20170105033641.6212-1-chris.packham@alliedtelesis.co.nz> <20170106041517.9589-1-chris.packham@alliedtelesis.co.nz> <20170106041517.9589-4-chris.packham@alliedtelesis.co.nz> Cc: "linux-arm-kernel@lists.infradead.org" , Kalyan Kinthada , Rob Herring , Mark Rutland , Laxman Dewangan , "linux-gpio@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" From: Sebastian Hesselbarth Message-ID: <95cb4240-e77b-5eaa-1920-4d9e26028038@gmail.com> Date: Wed, 11 Jan 2017 21:55:48 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/11/2017 03:44 PM, Linus Walleij wrote: > On Fri, Jan 6, 2017 at 5:15 AM, Chris Packham > wrote: > >> From: Kalyan Kinthada >> >> This pinctrl driver supports the 98DX3236, 98DX3336 and 98DX4251 SoCs >> from Marvell. >> >> Signed-off-by: Kalyan Kinthada >> Signed-off-by: Chris Packham > > I am waiting for an ACK or comment from the maintainers on > this patch. Sebastian? Sorry for the ignorance. I don't have the patch to reply to inline, but: - In the driver MPP_MODE2, spi0 there is a typo "csk" instead of "sck". - MPP_MODE5 binding "dev","bootcs" and driver "dev","bootcs0" differ. - MPP_MODE6 binding "gpio" and driver "gpo" differ. - MPP_MODE17 binding "dev","clk" and driver "dev","clkout" differ. - MPP_MODE19 binding mentiones "dev","rb" but driver does not. - MPP_MODE20 binding "gpio" and driver "gpo" differ. - MPP_MODE20 binding "dev","we" and driver "dev","we0" differ. - MPP_MODE21 through MPP_MODE30 binding "gpio" and driver "gpo" differ. - remove spaces before "0, 0" in mv98dx3236_mpp_gpio_ranges. Most of it is cosmetic stuff, so if you fix it feel free to add my Acked-by: Sebastian Hesselbarth Sebastian