From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 29F35CA100A for ; Sat, 31 Aug 2024 00:01:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:References:Cc:To:Subject:From:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=sr+m/MCpvguQ1PEITzYf3gtI8iZ+jxmN3Qz312mDJ+Y=; b=k+EHHXy/oGrTIj10VwrhDATXTe mz/IkjoRyDYfNWH/YGTgum9q1pH6YI+pgaIeOK+8Zgf/MANhcjX+UvP2xtxE/QAAibaZCjDKni5zY A4TGQZU3rPNqBBKJmQBvvDdQHhYQon0Zt7JABx1a0++92FWS8+0vprHQ7OmC0cSzktJQ7EJaUcgbb WlyZMM6UBM0LI+dJ8bT7Be7LEW6/y5o1F+6jfjUOfPW+JOGvjt9QtFuCTCeNGU6bwvKRL4J8InlhB EXJSWIv+nOFu0149CfXqwbk7YE4W6aocRUJ92G8Ii7b+xPt66MdDDJ6uxrwS+JY0YqZ9xz7pXpE3T /vWp9eTA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1skBY5-000000084DR-3fbu; Sat, 31 Aug 2024 00:01:04 +0000 Received: from mail-pl1-x636.google.com ([2607:f8b0:4864:20::636]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1skBWk-00000008410-1GbJ for linux-arm-kernel@lists.infradead.org; Fri, 30 Aug 2024 23:59:39 +0000 Received: by mail-pl1-x636.google.com with SMTP id d9443c01a7336-202318c4f45so23337315ad.0 for ; Fri, 30 Aug 2024 16:59:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1725062377; x=1725667177; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:from:user-agent:mime-version:date:message-id:from:to :cc:subject:date:message-id:reply-to; bh=sr+m/MCpvguQ1PEITzYf3gtI8iZ+jxmN3Qz312mDJ+Y=; b=hz+0qXrRUHByzxNkT2guiPlIwuqMLwqyhlQtnGoRlF4yGXmLGcl/0/EARg1LBa7l+c EIQpFWLXhgRWhN73Wq/hI3reJa4vz+BPu9Sp+ofFR29QhpNJFsp5XqHn7h8zrxuK4wuB AnywQZLAc4aVt6ies4sL2GMTU5tW6r89OByPQ0OPB9vYUWNHBuFaDlIqXAiQu6HJPDBD xDfEJ94TdXekljFcDCMjCwfE9IS12TTpq+ELOWYoP3lAnb70t+8hT7JQ/vE3w+dtUOSM n4Lfh8pjR9USvh1AJFjvNOagXeoduZL+5QTuCXu50lRj6zVgF6DmyIxschlhVSx5zxmE FGgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725062377; x=1725667177; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:from:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=sr+m/MCpvguQ1PEITzYf3gtI8iZ+jxmN3Qz312mDJ+Y=; b=C0aBblwxYF5WfKBM7rnQD1hFuCwYBToHvGkBIFFTjLE8SeDip2f0laOV7U6RYj+wC6 vUL5wuW+eKHFA/PJibqU0Gt1w7tuIAsF6lsG+03ikhV8dz+iIPQvyEpIOhCw3xSoc6TR tW9K0pWoUHprBdOs50d6nLYWANE1jPhoJRowsuVkLqhx1EUujsWvttc8z5hw2FkmoybP TDT1qtaoofj7tiUCFrPuG2pxQwgNrRTQJYcMejtzHEfkSB0hNhXrhW9SRQEay368pxEm 6OoDviCB++oz7mcTTrOI+uQ1zJ/wLdn6UmqdgWxV1yQ5J0Jg0tx6AEvtLzZJUSvlldhw slaw== X-Forwarded-Encrypted: i=1; AJvYcCX+GgpbvWfOqNdNOQNjAbMkHex3B6HCpLl8OcpSVFYQiNQs0vkO890Pfcz7l1cAhGkMX3Z13RTnqcW6fgMbO1Xh@lists.infradead.org X-Gm-Message-State: AOJu0YwJHvaRbaCwrQUmf/BI+jYzHaTtnsyNsFWGfYpBA28ENPZyssco 7LAEzttsoNditm1Uj2zFhLEZpltvvobesh0WsuORKOs7izTRCnBD X-Google-Smtp-Source: AGHT+IHAQjId6GpdvBN5Oyuv2ZrrV71Pt4bk2AIiEuJwheyfWAw667JccSxOY37LyeSAoczElPRHIw== X-Received: by 2002:a17:902:da86:b0:1fc:5ed5:ff56 with SMTP id d9443c01a7336-20546b55c5dmr8024345ad.61.1725062377258; Fri, 30 Aug 2024 16:59:37 -0700 (PDT) Received: from [10.67.48.245] ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2052a6843f3sm15745525ad.43.2024.08.30.16.59.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 30 Aug 2024 16:59:36 -0700 (PDT) Message-ID: <95ce8d16-17bf-490e-a084-ac16fe8ba813@gmail.com> Date: Fri, 30 Aug 2024 16:59:35 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Florian Fainelli Subject: Re: [net-next,v3,1/1] net: stmmac: Batch set RX OWN flag and other flags To: ende.tan@starfivetech.com, netdev@vger.kernel.org Cc: andrew@lunn.ch, alexandre.torgue@foss.st.com, joabreu@synopsys.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, mcoquelin.stm32@gmail.com, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, leyfoon.tan@starfivetech.com, minda.chen@starfivetech.com, endeneer@gmail.com References: <20240829134043.323855-1-ende.tan@starfivetech.com> Content-Language: en-US In-Reply-To: <20240829134043.323855-1-ende.tan@starfivetech.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240830_165938_348768_B7EACF1D X-CRM114-Status: GOOD ( 19.67 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 8/29/24 06:40, ende.tan@starfivetech.com wrote: > From: Tan En De > > Minimize access to the RX descriptor by collecting all the flags in a > local variable and then updating the descriptor at once. > > Signed-off-by: Tan En De > --- > v3: > - Use local variable to batch set the descriptor flags. > - This reduces the number of accesses to the descriptor. > v2: https://patchwork.kernel.org/project/netdevbpf/patch/20240821060307.46350-1-ende.tan@starfivetech.com/ > - Avoid introducing a new function just to set the interrupt-on-completion > bit, as it is wasteful to do so. > - Delegate the responsibility of calling dma_wmb() from main driver code > to set_rx_owner() callbacks (i.e. let callbacks to manage the low-level > ordering/barrier rather than cluttering up the main driver code). > v1: https://patchwork.kernel.org/project/netdevbpf/patch/20240814092438.3129-1-ende.tan@starfivetech.com/ > --- > drivers/net/ethernet/stmicro/stmmac/dwmac4_descs.c | 6 ++++-- > drivers/net/ethernet/stmicro/stmmac/dwxgmac2_descs.c | 6 ++++-- > 2 files changed, 8 insertions(+), 4 deletions(-) > > diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac4_descs.c b/drivers/net/ethernet/stmicro/stmmac/dwmac4_descs.c > index 1c5802e0d7f4..dfcbe7036988 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/dwmac4_descs.c > +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac4_descs.c > @@ -186,10 +186,12 @@ static void dwmac4_set_tx_owner(struct dma_desc *p) > > static void dwmac4_set_rx_owner(struct dma_desc *p, int disable_rx_ic) > { > - p->des3 |= cpu_to_le32(RDES3_OWN | RDES3_BUFFER1_VALID_ADDR); > + u32 flags = cpu_to_le32(RDES3_OWN | RDES3_BUFFER1_VALID_ADDR); > > if (!disable_rx_ic) > - p->des3 |= cpu_to_le32(RDES3_INT_ON_COMPLETION_EN); > + flags |= cpu_to_le32(RDES3_INT_ON_COMPLETION_EN); > + > + p->des3 |= flags; You could just batch the endian conversion too: u32 flags = DES3_OWN | RDES3_BUFFER1_VALID_ADDR; if (!disable_rx_ic) flags |= RDES3_INT_ON_COMPLETION_EN; p->desc3 |= cpu_to_le32(flags); > } > > static int dwmac4_get_tx_ls(struct dma_desc *p) > diff --git a/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_descs.c b/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_descs.c > index fc82862a612c..0c7ea939f787 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_descs.c > +++ b/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_descs.c > @@ -56,10 +56,12 @@ static void dwxgmac2_set_tx_owner(struct dma_desc *p) > > static void dwxgmac2_set_rx_owner(struct dma_desc *p, int disable_rx_ic) > { > - p->des3 |= cpu_to_le32(XGMAC_RDES3_OWN); > + u32 flags = cpu_to_le32(XGMAC_RDES3_OWN); > > if (!disable_rx_ic) > - p->des3 |= cpu_to_le32(XGMAC_RDES3_IOC); > + flags |= cpu_to_le32(XGMAC_RDES3_IOC); > + > + p->des3 |= flags; And likewise here, and that would likely squash the sparse warning, since you would not be assigning an 'u32' field to a __le32 field anymore. -- Florian