Re: [PATCHv2] mac80211: fix NULL ptr dereference during mesh peer connection for non HE devices

[Abinaya Kalaiselvan <akalaise@codeaurora.org>]

On 2021-06-15 19:47, Nicolas Cavallari wrote:
> On 19/04/2021 13:23, Johannes Berg wrote:
>> On Thu, 2021-04-15 at 16:17 +0530, Abinaya Kalaiselvan wrote:
>>> "sband->iftype_data" is not assigned with any value for non HE 
>>> supported
>>> devices, which causes NULL pointer access during mesh peer connection
>>> in those devices. Fix this by accessing the pointer after HE
>>> capabilities condition check.
>>> 
>>> Fixes: 7f7aa94bcaf0 (mac80211: reduce peer HE MCS/NSS to own 
>>> capabilities)
>>> Signed-off-by: Abinaya Kalaiselvan <akalaise@codeaurora.org>
>>> ---
>>> v2:
>>> * ieee80211_sta_he_cap structure instance is initialized.
>>> 
>> How about taking other feedback into account?
>> 
>> johannes
>> 
> 
> I got a crash because of this bug and this patch fixes it. Abinaya, do
> you plan to submit a version with the indentation fixed, or can I do
> it ?

Thanks Nicolas. I have sent the updated patch with indentation fix.

Thanks,
Abinaya Kalaiselvan