From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC20EC54EBE for ; Fri, 13 Jan 2023 01:15:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232740AbjAMBPX (ORCPT ); Thu, 12 Jan 2023 20:15:23 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60066 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232226AbjAMBPX (ORCPT ); Thu, 12 Jan 2023 20:15:23 -0500 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D74F1271A5; Thu, 12 Jan 2023 17:15:21 -0800 (PST) Received: from kwepemm600010.china.huawei.com (unknown [172.30.72.56]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4NtNjM716gzJrJT; Fri, 13 Jan 2023 09:13:59 +0800 (CST) Received: from [10.67.110.237] (10.67.110.237) by kwepemm600010.china.huawei.com (7.193.23.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Fri, 13 Jan 2023 09:15:18 +0800 Subject: Re: [PATCH 4/8] ftrace: Add DYNAMIC_FTRACE_WITH_CALL_OPS To: Mark Rutland CC: , , , , , , , , , , , , , References: <20230109135828.879136-1-mark.rutland@arm.com> <20230109135828.879136-5-mark.rutland@arm.com> From: Li Huafei Message-ID: <95f421a3-383f-5d05-adaf-3d8188ae3a36@huawei.com> Date: Fri, 13 Jan 2023 09:15:18 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.110.237] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To kwepemm600010.china.huawei.com (7.193.23.86) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On 2023/1/12 19:00, Mark Rutland wrote: > On Thu, Jan 12, 2023 at 02:48:45PM +0800, Li Huafei wrote: >> On 2023/1/9 21:58, Mark Rutland wrote: >> >>> diff --git a/include/linux/ftrace.h b/include/linux/ftrace.h >>> index 99f1146614c04..5eeb2776124c5 100644 >>> --- a/include/linux/ftrace.h >>> +++ b/include/linux/ftrace.h >>> @@ -57,6 +57,9 @@ void arch_ftrace_ops_list_func(unsigned long ip, unsigned long parent_ip); >>> void arch_ftrace_ops_list_func(unsigned long ip, unsigned long parent_ip, >>> struct ftrace_ops *op, struct ftrace_regs *fregs); >>> #endif >>> +extern const struct ftrace_ops ftrace_nop_ops; >>> +extern const struct ftrace_ops ftrace_list_ops; >>> +struct ftrace_ops *ftrace_find_unique_ops(struct dyn_ftrace *rec); >> >> Hi Mark, > > Hi Huafei, > > Thanks for the reporrt. > >> This patch has build issues on x86: >> >> CC mm/readahead.o >> In file included from include/linux/perf_event.h:52:0, >> from arch/x86/events/amd/lbr.c:2: >> include/linux/ftrace.h:62:50: error: ‘struct dyn_ftrace’ declared inside parameter list will not be visible outside of this definition or declaration [-Werror] >> struct ftrace_ops *ftrace_find_unique_ops(struct dyn_ftrace *rec); >> >> Here we should need 'struct dyn_ftrace' forward declaration. > > The build robot spotted this a couple of days ago (from my branch rather than > the list), and I fixed it there a couple of days ago. The relevant messages were: > > https://lore.kernel.org/oe-kbuild-all/202301100944.E0mV3kSO-lkp@intel.com/ > https://lore.kernel.org/oe-kbuild-all/Y72TJ3qQuvx3gIOi@FVFF77S0Q05N/#t > > ... and the updated commit is at: > > https://git.kernel.org/pub/scm/linux/kernel/git/mark/linux.git/commit/?h=arm64/ftrace/per-callsite-ops&id=acab29d6ea2f20d8d156cdd301ad9790bd1d888f > Okay, you've fixed it. Thanks for pointing out. > > ... I'll post a v2 with that folded in once this has had a bit more time to gather comments. > > Thanks, > Mark. > > . > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B0091C54EBD for ; Fri, 13 Jan 2023 01:16:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:CC:To:Subject:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=rA5z7lxwu1uqyZl8y7J6IYfe6rsCFBuHi16FTbvfeb4=; b=qCRGMwEpieQCL4MeY1Q0MH9i/T t1aWBb4pyZt1NgRGXAw3TMnfyveB6zLUdLQhV3hv7A0m0GvSYAfocSc1O7lIjlBlnCK8cAHZZdzUi 6cAdHEMFEmQOzK9XdSms+zo66QCQV5vAzQatxJkf7DzmDxt1pFgEoBxBLdZPM0Af7LueUaOwH06nf uorczB6fVcOyYW9x/79RVXlPNsvHQZzlmWiPB2ClfwYruRe/0Usvd+mNXDSs65itGqx5wlL711gXU j/jey0mlf7ET4NCdduXiSIRCKQLiPL3SY+KdkDk89LQ7gBd9reZbe9sZus6RAzpOIBvWqZVSNvg2l KqekL0Xg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pG8fI-0003Vp-O9; Fri, 13 Jan 2023 01:15:29 +0000 Received: from szxga02-in.huawei.com ([45.249.212.188]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pG8fE-0003TO-SF for linux-arm-kernel@lists.infradead.org; Fri, 13 Jan 2023 01:15:27 +0000 Received: from kwepemm600010.china.huawei.com (unknown [172.30.72.56]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4NtNjM716gzJrJT; Fri, 13 Jan 2023 09:13:59 +0800 (CST) Received: from [10.67.110.237] (10.67.110.237) by kwepemm600010.china.huawei.com (7.193.23.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Fri, 13 Jan 2023 09:15:18 +0800 Subject: Re: [PATCH 4/8] ftrace: Add DYNAMIC_FTRACE_WITH_CALL_OPS To: Mark Rutland CC: , , , , , , , , , , , , , References: <20230109135828.879136-1-mark.rutland@arm.com> <20230109135828.879136-5-mark.rutland@arm.com> From: Li Huafei Message-ID: <95f421a3-383f-5d05-adaf-3d8188ae3a36@huawei.com> Date: Fri, 13 Jan 2023 09:15:18 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Originating-IP: [10.67.110.237] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To kwepemm600010.china.huawei.com (7.193.23.86) X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230112_171525_157847_B9AC8E5C X-CRM114-Status: GOOD ( 14.95 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org CgpPbiAyMDIzLzEvMTIgMTk6MDAsIE1hcmsgUnV0bGFuZCB3cm90ZToKPiBPbiBUaHUsIEphbiAx MiwgMjAyMyBhdCAwMjo0ODo0NVBNICswODAwLCBMaSBIdWFmZWkgd3JvdGU6Cj4+IE9uIDIwMjMv MS85IDIxOjU4LCBNYXJrIFJ1dGxhbmQgd3JvdGU6Cj4+Cj4+PiBkaWZmIC0tZ2l0IGEvaW5jbHVk ZS9saW51eC9mdHJhY2UuaCBiL2luY2x1ZGUvbGludXgvZnRyYWNlLmgKPj4+IGluZGV4IDk5ZjEx NDY2MTRjMDQuLjVlZWIyNzc2MTI0YzUgMTAwNjQ0Cj4+PiAtLS0gYS9pbmNsdWRlL2xpbnV4L2Z0 cmFjZS5oCj4+PiArKysgYi9pbmNsdWRlL2xpbnV4L2Z0cmFjZS5oCj4+PiBAQCAtNTcsNiArNTcs OSBAQCB2b2lkIGFyY2hfZnRyYWNlX29wc19saXN0X2Z1bmModW5zaWduZWQgbG9uZyBpcCwgdW5z aWduZWQgbG9uZyBwYXJlbnRfaXApOwo+Pj4gIHZvaWQgYXJjaF9mdHJhY2Vfb3BzX2xpc3RfZnVu Yyh1bnNpZ25lZCBsb25nIGlwLCB1bnNpZ25lZCBsb25nIHBhcmVudF9pcCwKPj4+ICAJCQkgICAg ICAgc3RydWN0IGZ0cmFjZV9vcHMgKm9wLCBzdHJ1Y3QgZnRyYWNlX3JlZ3MgKmZyZWdzKTsKPj4+ ICAjZW5kaWYKPj4+ICtleHRlcm4gY29uc3Qgc3RydWN0IGZ0cmFjZV9vcHMgZnRyYWNlX25vcF9v cHM7Cj4+PiArZXh0ZXJuIGNvbnN0IHN0cnVjdCBmdHJhY2Vfb3BzIGZ0cmFjZV9saXN0X29wczsK Pj4+ICtzdHJ1Y3QgZnRyYWNlX29wcyAqZnRyYWNlX2ZpbmRfdW5pcXVlX29wcyhzdHJ1Y3QgZHlu X2Z0cmFjZSAqcmVjKTsKPj4KPj4gSGkgTWFyaywKPiAKPiBIaSBIdWFmZWksCj4gCj4gVGhhbmtz IGZvciB0aGUgcmVwb3JydC4KPiAKPj4gVGhpcyBwYXRjaCBoYXMgYnVpbGQgaXNzdWVzIG9uIHg4 NjoKPj4KPj4gICAgIENDICAgICAgbW0vcmVhZGFoZWFkLm8KPj4gICBJbiBmaWxlIGluY2x1ZGVk IGZyb20gaW5jbHVkZS9saW51eC9wZXJmX2V2ZW50Lmg6NTI6MCwKPj4gICAgICAgICAgICAgICAg ICAgIGZyb20gYXJjaC94ODYvZXZlbnRzL2FtZC9sYnIuYzoyOgo+PiAgIGluY2x1ZGUvbGludXgv ZnRyYWNlLmg6NjI6NTA6IGVycm9yOiDigJhzdHJ1Y3QgZHluX2Z0cmFjZeKAmSBkZWNsYXJlZCBp bnNpZGUgcGFyYW1ldGVyIGxpc3Qgd2lsbCBub3QgYmUgdmlzaWJsZSBvdXRzaWRlIG9mIHRoaXMg ZGVmaW5pdGlvbiBvciBkZWNsYXJhdGlvbiBbLVdlcnJvcl0KPj4gICAgc3RydWN0IGZ0cmFjZV9v cHMgKmZ0cmFjZV9maW5kX3VuaXF1ZV9vcHMoc3RydWN0IGR5bl9mdHJhY2UgKnJlYyk7Cj4+Cj4+ IEhlcmUgd2Ugc2hvdWxkIG5lZWQgJ3N0cnVjdCBkeW5fZnRyYWNlJyBmb3J3YXJkIGRlY2xhcmF0 aW9uLgo+IAo+IFRoZSBidWlsZCByb2JvdCBzcG90dGVkIHRoaXMgYSBjb3VwbGUgb2YgZGF5cyBh Z28gKGZyb20gbXkgYnJhbmNoIHJhdGhlciB0aGFuCj4gdGhlIGxpc3QpLCBhbmQgSSBmaXhlZCBp dCB0aGVyZSBhIGNvdXBsZSBvZiBkYXlzIGFnby4gVGhlIHJlbGV2YW50IG1lc3NhZ2VzIHdlcmU6 Cj4gCj4gICBodHRwczovL2xvcmUua2VybmVsLm9yZy9vZS1rYnVpbGQtYWxsLzIwMjMwMTEwMDk0 NC5FMG1WM2tTTy1sa3BAaW50ZWwuY29tLwo+ICAgaHR0cHM6Ly9sb3JlLmtlcm5lbC5vcmcvb2Ut a2J1aWxkLWFsbC9ZNzJUSjNxUXV2eDNnSU9pQEZWRkY3N1MwUTA1Ti8jdAo+IAo+IC4uLiBhbmQg dGhlIHVwZGF0ZWQgY29tbWl0IGlzIGF0Ogo+IAo+ICAgaHR0cHM6Ly9naXQua2VybmVsLm9yZy9w dWIvc2NtL2xpbnV4L2tlcm5lbC9naXQvbWFyay9saW51eC5naXQvY29tbWl0Lz9oPWFybTY0L2Z0 cmFjZS9wZXItY2FsbHNpdGUtb3BzJmlkPWFjYWIyOWQ2ZWEyZjIwZDhkMTU2Y2RkMzAxYWQ5Nzkw YmQxZDg4OGYKPiAKCk9rYXksIHlvdSd2ZSBmaXhlZCBpdC4gVGhhbmtzIGZvciBwb2ludGluZyBv dXQuCgo+IAo+IC4uLiBJJ2xsIHBvc3QgYSB2MiB3aXRoIHRoYXQgZm9sZGVkIGluIG9uY2UgdGhp cyBoYXMgaGFkIGEgYml0IG1vcmUgdGltZSB0byBnYXRoZXIgY29tbWVudHMuCj4gCj4gVGhhbmtz LAkKPiBNYXJrLgo+IAo+IC4KPiAKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJu ZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFu L2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK