From: Govind Singh <govinds@codeaurora.org>
To: Stephen Boyd <sboyd@kernel.org>
Cc: andy.gross@linaro.org, bjorn.andersson@linaro.org,
david.brown@linaro.org, devicetree@vger.kernel.org,
linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org,
linux-soc@vger.kernel.org, sibis@codeaurora.org,
sricharan@codeaurora.org
Subject: Re: [PATCH v2 2/6] clk: qcom: Add WCSS gcc clock control for QCS404
Date: Sat, 15 Dec 2018 23:13:19 +0530 [thread overview]
Message-ID: <95fd78776f20701d82f1ed84bf476149@codeaurora.org> (raw)
In-Reply-To: <153965169170.5275.12866721145155274552@swboyd.mtv.corp.google.com>
Thanks Stephen for the review.
On 2018-10-16 06:31, Stephen Boyd wrote:
> Quoting Govind Singh (2018-10-12 02:40:40)
>> static const struct regmap_config gcc_qcs404_regmap_config = {
>> @@ -2669,7 +2699,7 @@ enum {
>> .fast_io = true,
>> };
>>
>> -static const struct qcom_cc_desc gcc_qcs404_desc = {
>> +static struct qcom_cc_desc gcc_qcs404_desc = {
>> .config = &gcc_qcs404_regmap_config,
>> .clks = gcc_qcs404_clocks,
>> .num_clks = ARRAY_SIZE(gcc_qcs404_clocks),
>> @@ -2702,6 +2732,11 @@ static int gcc_qcs404_probe(struct
>> platform_device *pdev)
>> clk_prepare_enable(apss_ahb_clk_src.clkr.hw.clk);
>> clk_prepare_enable(gpll0_ao_out_main.clkr.hw.clk);
>>
>> + if (of_property_read_bool(pdev->dev.of_node,
>> "qcom,wcss-protected")) {
>
> Is this documented? And shouldn't it be inverted? If it isn't protected
> then we do this?
>
I have moved this to #ifdef CONFIG_QCS_WCSSCC_404 similar to lpass clk
driver for sdm845 in v3.
>> + gcc_qcs404_clocks[GCC_WCSS_Q6_AHB_CBCR_CLK] =
>> &gcc_wdsp_q6ss_ahbs_clk.clkr;
>> + gcc_qcs404_clocks[GCC_WCSS_Q6_AXIM_CBCR_CLK] =
>> &gcc_wdsp_q6ss_axim_clk.clkr;
>> + }
>> +
>> return qcom_cc_really_probe(pdev, &gcc_qcs404_desc, regmap);
>> }
>>
BR,
Govind
next prev parent reply other threads:[~2018-12-15 17:43 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-12 9:40 [PATCH v2 0/6] Add non PAS wcss Q6 support for QCS404 Govind Singh
2018-10-12 9:40 ` [PATCH v2 1/6] dt-bindings: clock: qcom: Add QCOM WCSS GCC clock bindings Govind Singh
2018-10-17 20:02 ` Rob Herring
2018-10-12 9:40 ` [PATCH v2 2/6] clk: qcom: Add WCSS gcc clock control for QCS404 Govind Singh
2018-10-16 1:01 ` Stephen Boyd
2018-12-15 17:43 ` Govind Singh [this message]
2018-10-12 9:40 ` [PATCH v2 3/6] dt-bindings: clock: qcom: Introduce QCOM WCSS Q6DSP clock bindings Govind Singh
2018-10-17 20:05 ` Rob Herring
2018-10-12 9:40 ` [PATCH v2 4/6] clk: qcom: Add WCSS Q6DSP clock controller for QCS404 Govind Singh
2018-10-16 1:00 ` Stephen Boyd
2018-12-15 17:50 ` Govind Singh
2018-10-12 9:40 ` [PATCH v2 5/6] remoteproc: qcom: wcss: populate hardcoded param using driver data Govind Singh
2018-10-12 9:40 ` [PATCH v2 6/6] remoteproc: qcom: wcss: Add non pas wcss Q6 support for QCS404 Govind Singh
2018-10-17 20:08 ` Rob Herring
2018-12-06 16:48 ` Bjorn Andersson
2018-12-15 18:00 ` Govind Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=95fd78776f20701d82f1ed84bf476149@codeaurora.org \
--to=govinds@codeaurora.org \
--cc=andy.gross@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=david.brown@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=linux-soc@vger.kernel.org \
--cc=sboyd@kernel.org \
--cc=sibis@codeaurora.org \
--cc=sricharan@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.