From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2F7CC433EF for ; Thu, 16 Sep 2021 02:22:53 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AE854611CA for ; Thu, 16 Sep 2021 02:22:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org AE854611CA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3E1106EA92; Thu, 16 Sep 2021 02:22:52 +0000 (UTC) Received: from m43-7.mailgun.net (m43-7.mailgun.net [69.72.43.7]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7BF6D6EA92 for ; Thu, 16 Sep 2021 02:22:49 +0000 (UTC) DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1631758971; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=PEK9TEZywfdNw/09e0JsNMsCaTjkdxWwYJarz23KSOc=; b=UyOdYUbD3CNuuMcdpGY4RZnOSL/2NS+BWvem+AEoeCxFhtKaoxciXS7Q4oHjOUo/POapqvkD ES4sNaCi/7IAqmnTiVuEWUmMWyQH41LWqTn4x0w6YSNjweuLdv+A+qD8Di5pRuuZQh8JBy/8 ogZ/XiSDzqD0eeAs/j9awpCmCa8= X-Mailgun-Sending-Ip: 69.72.43.7 X-Mailgun-Sid: WyJkOTU5ZSIsICJkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n06.prod.us-west-2.postgun.com with SMTP id 6142aa62b585cc7d24d98b91 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Thu, 16 Sep 2021 02:22:26 GMT Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 59249C4360D; Thu, 16 Sep 2021 02:22:26 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: abhinavk) by smtp.codeaurora.org (Postfix) with ESMTPSA id C0266C4338F; Thu, 16 Sep 2021 02:22:25 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Wed, 15 Sep 2021 19:22:25 -0700 From: abhinavk@codeaurora.org To: Fabio Estevam Cc: robdclark@gmail.com, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, dmitry.baryshkov@linaro.org, stable@vger.kernel.org Subject: Re: [Freedreno] [PATCH] drm/msm: Do not run snapshot on non-DPU devices In-Reply-To: <20210914174831.2044420-1-festevam@gmail.com> References: <20210914174831.2044420-1-festevam@gmail.com> Message-ID: <96038e06b1141ad3348611a25544356e@codeaurora.org> X-Sender: abhinavk@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Fabio On 2021-09-14 10:48, Fabio Estevam wrote: > Since commit 98659487b845 ("drm/msm: add support to take dpu snapshot") > the following NULL pointer dereference is seen on i.MX53: > > [ 3.275493] msm msm: bound 30000000.gpu (ops a3xx_ops) > [ 3.287174] [drm] Initialized msm 1.8.0 20130625 for msm on minor 0 > [ 3.293915] 8<--- cut here --- > [ 3.297012] Unable to handle kernel NULL pointer dereference at > virtual address 00000028 > [ 3.305244] pgd = (ptrval) > [ 3.307989] [00000028] *pgd=00000000 > [ 3.311624] Internal error: Oops: 805 [#1] SMP ARM > [ 3.316430] Modules linked in: > [ 3.319503] CPU: 0 PID: 1 Comm: swapper/0 Not tainted > 5.14.0+g682d702b426b #1 > [ 3.326652] Hardware name: Freescale i.MX53 (Device Tree Support) > [ 3.332754] PC is at __mutex_init+0x14/0x54 > [ 3.336969] LR is at msm_disp_snapshot_init+0x24/0xa0 > > i.MX53 does not use the DPU controller. > > Fix the problem by only calling msm_disp_snapshot_init() on platforms > that > use the DPU controller. > > Cc: stable@vger.kernel.org > Fixes: 98659487b845 ("drm/msm: add support to take dpu snapshot") > Signed-off-by: Fabio Estevam > --- > drivers/gpu/drm/msm/msm_drv.c | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/msm/msm_drv.c > b/drivers/gpu/drm/msm/msm_drv.c > index 2e6fc185e54d..2aa2266454b7 100644 > --- a/drivers/gpu/drm/msm/msm_drv.c > +++ b/drivers/gpu/drm/msm/msm_drv.c > @@ -630,10 +630,11 @@ static int msm_drm_init(struct device *dev, > const struct drm_driver *drv) > if (ret) > goto err_msm_uninit; > > - ret = msm_disp_snapshot_init(ddev); > - if (ret) > - DRM_DEV_ERROR(dev, "msm_disp_snapshot_init failed ret = %d\n", ret); > - > + if (kms) { > + ret = msm_disp_snapshot_init(ddev); > + if (ret) > + DRM_DEV_ERROR(dev, "msm_disp_snapshot_init failed ret = %d\n", > ret); > + } Are you not using DPU or are you not using mdp4/mdp5 as well? Even if you are using any of mdps, kms should not be NULL. Hence wanted to check the test case. > drm_mode_config_reset(ddev); > > #ifdef CONFIG_DRM_FBDEV_EMULATION