From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C2BA2D68BCD for ; Fri, 15 Nov 2024 16:36:11 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3FA8410E2D9; Fri, 15 Nov 2024 16:36:11 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=arndb.de header.i=@arndb.de header.b="N1V/uaTI"; dkim=pass (2048-bit key; unprotected) header.d=messagingengine.com header.i=@messagingengine.com header.b="TuUuyXh8"; dkim-atps=neutral Received: from fout-b4-smtp.messagingengine.com (fout-b4-smtp.messagingengine.com [202.12.124.147]) by gabe.freedesktop.org (Postfix) with ESMTPS id 63F8A10E162 for ; Fri, 15 Nov 2024 16:36:09 +0000 (UTC) Received: from phl-compute-10.internal (phl-compute-10.phl.internal [10.202.2.50]) by mailfout.stl.internal (Postfix) with ESMTP id D8016114011A; Fri, 15 Nov 2024 11:36:08 -0500 (EST) Received: from phl-imap-11 ([10.202.2.101]) by phl-compute-10.internal (MEProxy); Fri, 15 Nov 2024 11:36:09 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm3; t=1731688568; x=1731774968; bh=Di/rS4M465PPBMn1lW76KE0FVONCxRZbbC1er82K2KA=; b= N1V/uaTIIinuZJbAPUA7QBWjnK7q33fI/3NpfhABhaLBbKLxLZXFDgjYTwrG5nQG yS9I9liMDeYpPoQpRjclQJ0L6vvsghTpfBlj5BA7OcuUV4N9n2ftvQMpD1UqmznK owtbqhxAYFwR2MMuh0JFX8xZtkiFxyl5teDRE9FWPG5ipDWUwNmcmZrkRENb60yN RTKKX34nMx/zLGa0d8YlFllkRWdidq5a2EEP2XPbjDSVSwjrIQQUvaacVML4mGup X/odWQpcAZ5HQYxuQKTi2TdptOPZZTxE0/X/XnEhY4bw+yPsyPZ8wnwdiea4iMLY diZQwZK3sFxc5qvY20y97Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1731688568; x= 1731774968; bh=Di/rS4M465PPBMn1lW76KE0FVONCxRZbbC1er82K2KA=; b=T uUuyXh8KkZvC28+YbhrXUZInLT048FHI70IYoFsRN32sR0wCsxud/ytRpWPPfJTY MY18sBTsFssnyv+6PKR3R4QipY48i40jUGr6snIn/n2kbWArDMWrwsdXIdqy6AiQ hidMJDq7yg004jj5gGk/BcMcQPptc7WxXQ37Zvd/qTnxgy6q3zmHT3iGHeOm93H1 W81Lv8XDePenJs+wOHoXEEHo07xYGL7+NEDzilaisYcoapMAXAimIbXxDqNwMt5l AmCbhvIouU2oE9+yPbk4xz60+G3M5bql1InqTmZncIPiS2bMvtzOrZN6yY3q0AJq b0hyCGnmV0d9ZqRTpB4Pw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefuddrvdeggdekkecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpggftfghnshhusghstghrihgsvgdpuffr tefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnth hsucdlqddutddtmdenucfjughrpefoggffhffvvefkjghfufgtgfesthejredtredttden ucfhrhhomhepfdetrhhnugcuuegvrhhgmhgrnhhnfdcuoegrrhhnugesrghrnhgusgdrug gvqeenucggtffrrghtthgvrhhnpefhtdfhvddtfeehudekteeggffghfejgeegteefgffg vedugeduveelvdekhfdvieenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmh grihhlfhhrohhmpegrrhhnugesrghrnhgusgdruggvpdhnsggprhgtphhtthhopedugedp mhhouggvpehsmhhtphhouhhtpdhrtghpthhtohephhgrrhhrhidrfigvnhhtlhgrnhguse grmhgurdgtohhmpdhrtghpthhtohepshhimhhonhgrsehffhiflhhlrdgthhdprhgtphht thhopehgvggvrhhtodhrvghnvghsrghssehglhhiuggvrhdrsggvpdhrtghpthhtoheprg hirhhlihgvugesghhmrghilhdrtghomhdprhgtphhtthhopehjrghnihdrnhhikhhulhgr sehinhhtvghlrdgtohhmpdhrtghpthhtohepjhhonhgrthhhrghnrdgtrghvihhtthesih hnthgvlhdrtghomhdprhgtphhtthhopegrrhhnugeskhgvrhhnvghlrdhorhhgpdhrtghp thhtohepmhgrshgrhhhirhhohieskhgvrhhnvghlrdhorhhgpdhrtghpthhtohepmhhrih hprghrugeskhgvrhhnvghlrdhorhhg X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.phl.internal (Postfix, from userid 501) id 2D0B72220071; Fri, 15 Nov 2024 11:36:08 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface MIME-Version: 1.0 Date: Fri, 15 Nov 2024 17:35:46 +0100 From: "Arnd Bergmann" To: "Thomas Zimmermann" , "Arnd Bergmann" Cc: "Maarten Lankhorst" , "Maxime Ripard" , "Dave Airlie" , "Simona Vetter" , "Jocelyn Falempe" , "Geert Uytterhoeven" , "Jani Nikula" , "Harry Wentland" , "Masahiro Yamada" , "Jonathan Cavitt" , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Message-Id: <96269b2e-2a0e-4c7e-9d47-a52e64d1ea0a@app.fastmail.com> In-Reply-To: References: <20241115152722.3537630-1-arnd@kernel.org> Subject: Re: [PATCH] drm: rework FB_CORE dependency Content-Type: text/plain Content-Transfer-Encoding: 7bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Fri, Nov 15, 2024, at 16:54, Thomas Zimmermann wrote: > Am 15.11.24 um 16:27 schrieb Arnd Bergmann: >> >> @@ -220,7 +221,6 @@ config DRM_CLIENT_LIB >> tristate >> depends on DRM >> select DRM_KMS_HELPER if DRM_FBDEV_EMULATION >> - select FB_CORE if DRM_FBDEV_EMULATION > > This should remain. More fbdev code will move into drm_fbdev_client.c > and that will require FB_CORE. Got it. >> help >> This option enables the DRM client library and selects all >> modules and components according to the enabled clients. >> @@ -372,6 +372,7 @@ config DRM_GEM_SHMEM_HELPER >> tristate >> depends on DRM && MMU >> select FB_SYSMEM_HELPERS_DEFERRED if DRM_FBDEV_EMULATION >> + select FB_CORE if DRM_FBDEV_EMULATION > > This select is also needed by DRM_GEM_DMA_HELPER and DRM_GEM_TTM_HELPER. > > Please sort these select statements alphabetically. Sent a v2 now. Arnd