From: Muchun Song <muchun.song@linux.dev>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Muchun Song <songmuchun@bytedance.com>,
glider@google.com, elver@google.com, dvyukov@google.com,
sjpark@amazon.de, jannh@google.com,
Roman Gushchin <roman.gushchin@linux.dev>,
kasan-dev@googlegroups.com,
Linux Memory Management List <linux-mm@kvack.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: kfence: fix PG_slab and memcg_data clearing
Date: Tue, 21 Mar 2023 11:03:41 +0800 [thread overview]
Message-ID: <962CB717-DF8B-490A-86A0-2ACE90209012@linux.dev> (raw)
In-Reply-To: <20230320142954.fd314c5e46c1d18887ccf8cc@linux-foundation.org>
> On Mar 21, 2023, at 05:29, Andrew Morton <akpm@linux-foundation.org> wrote:
>
> On Mon, 20 Mar 2023 11:00:59 +0800 Muchun Song <songmuchun@bytedance.com> wrote:
>
>> It does not reset PG_slab and memcg_data when KFENCE fails to initialize
>> kfence pool at runtime. It is reporting a "Bad page state" message when
>> kfence pool is freed to buddy. The checking of whether it is a compound
>> head page seems unnecessary sicne we already guarantee this when allocating
>> kfence pool, removing the check to simplify the code.
>>
>> Fixes: 0ce20dd84089 ("mm: add Kernel Electric-Fence infrastructure")
>> Fixes: 8f0b36497303 ("mm: kfence: fix objcgs vector allocation")
>> Signed-off-by: Muchun Song <songmuchun@bytedance.com>
>
> I'm not sure how the -stable maintainers are to handle two Fixes: tags.
> Can we narrow it down to one please? I assume 8f0b36497303 triggered
> the bad_page() warning?
>
Actually, 0ce20dd84089 triggered the PG_slab warning and 8f0b36497303
triggered the "page still charged to cgroup" warning. This patch fixes
both warnings. Moreover, 8f0b36497303 fixes 0ce20dd84089 as well. So I think
we can narrow it down to 0ce20dd84089.
Thanks.
next prev parent reply other threads:[~2023-03-21 3:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-20 3:00 [PATCH] mm: kfence: fix PG_slab and memcg_data clearing Muchun Song
2023-03-20 21:29 ` Andrew Morton
2023-03-21 3:03 ` Muchun Song [this message]
2023-03-21 4:14 ` Peng Zhang
2023-03-21 7:04 ` Muchun Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=962CB717-DF8B-490A-86A0-2ACE90209012@linux.dev \
--to=muchun.song@linux.dev \
--cc=akpm@linux-foundation.org \
--cc=dvyukov@google.com \
--cc=elver@google.com \
--cc=glider@google.com \
--cc=jannh@google.com \
--cc=kasan-dev@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=roman.gushchin@linux.dev \
--cc=sjpark@amazon.de \
--cc=songmuchun@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.