From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH 0/5 v3] adv7511 EDID probing improvements Date: Mon, 16 Jan 2017 17:57:02 +0200 Message-ID: <9649749.TAVrhOzo15@avalon> References: <1483472502-16403-1-git-send-email-john.stultz@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from galahad.ideasonboard.com (galahad.ideasonboard.com [IPv6:2001:4b98:dc2:45:216:3eff:febb:480d]) by gabe.freedesktop.org (Postfix) with ESMTPS id CF7E489C14 for ; Mon, 16 Jan 2017 15:56:47 +0000 (UTC) In-Reply-To: <1483472502-16403-1-git-send-email-john.stultz@linaro.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: dri-devel@lists.freedesktop.org Cc: Wolfram Sang , lkml List-Id: dri-devel@lists.freedesktop.org SGkgSm9obiwKClRoYW5rIHlvdSBmb3IgdGhlIHBhdGNoZXMuCgpPbiBUdWVzZGF5IDAzIEphbiAy MDE3IDExOjQxOjM3IEpvaG4gU3R1bHR6IHdyb3RlOgo+IEhvcGUgZXZlcnlvbmUgaGFkIGEgZ29v ZCBuZXd5ZWFycyEKPiAKPiBXYW50ZWQgdG8gcmUtc2VuZCBvdXQgdjMgb2YgdGhpcyBwYXRjaCBz ZXQgaW1wcm92aW5nIHRoZSBFRElECj4gcHJvYmluZyBvbiB0aGUgYWR2NzUxMSB1c2VkIG9uIEhp S2V5LCBmb3IgY29uc2lkZXJhdGlvbiBmb3IKPiBtZXJnaW5nIGZvciA0LjExCj4gCj4gVGhlIGZp cnN0IHRocmVlIHBhdGNoZXMgYXJlIGZpeHVwcyB0aGF0IGFyZSBob3BlZnVsbHkgc3RyYWlnaHQK PiBmb3J3YXJkLCBpbnRlZ3JhdGluZyBmZWVkYmFjayBJIGdvdCBmcm9tIExhdXJhbnQuCj4gCj4g VGhlIGxhc3QgdHdvIHBhdGNoZXMgdHJ5IHRvIGNsZWFuIHVwIGFuZCByZXN1ZSBjb2RlLCB3aGlj aCBhcwo+IGEgc2lkZSBlZmZlY3QgYXZvaWRzIGFuIGlzc3VlIEknbSBzZWVpbmcgd2hlcmUgc29t ZXRoaW5nIGlzCj4gZ29pbmcgd3Jvbmcgd2l0aCB0aGUgcmVnbWFwIGNhY2hlIHN0YXRlIGZvciB0 aGUKPiBBRFY3NTExX1JFR19FRElEX0kyQ19BRERSKDB4NDMpIHJlZ2lzdGVyIHdoaWNoIHJlc3Vs dHMgaW4KPiBpMmNfdHJhbnNmZXIgZXJyb3JzIGlmIHdlIGRvbid0IGRvIHRoZQo+IHJlZ2NhY2hl X3N5bmMvX21hcmtfZGlydHkoKSBjYWxscy4gSSBzdXNwZWN0IHRoZXJlIG1pZ2h0IGJlIGEKPiBi ZXR0ZXIgc29sdXRpb24gdGhlcmUsIGJ1dCBoYXZlIG5vdCBnb3R0ZW4gYW55IG90aGVyIHN1Z2dl c3Rpb25zCj4gc28gSSB3YW50ZWQgdG8gZ28gYWhlYWQgYW5kIHN1Ym1pdCB0aGVzZS4KPiAKPiBU aG91Z2h0cyBhbmQgZmVlZGJhY2sgd291bGQgYmUgYXBwcmVjaWF0ZWQhCgpGb3IgdGhlIHdob2xl IHNlcmllcywKClRlc3RlZC1ieTogTGF1cmVudCBQaW5jaGFydCA8bGF1cmVudC5waW5jaGFydEBp ZGVhc29uYm9hcmQuY29tPgoKPiBOZXcgaW4gdjM6Cj4gKiBBZGRyZXNzZWQgbmFtaW5nIGltcHJv dmVtZW50cyBhbmQgZHJtX2ttc19oZWxwZXJfaG90cGx1Z19ldmVudAo+ICAgdXNhZ2UgY29ycmVj dGlvbnMgYXMgc3VnZ2VzdGVkIGJ5IExhdXJlbnQuCj4gCj4gQ2M6IERhdmlkIEFpcmxpZSA8YWly bGllZEBsaW51eC5pZT4KPiBDYzogQXJjaGl0IFRhbmVqYSA8YXJjaGl0dEBjb2RlYXVyb3JhLm9y Zz4KPiBDYzogV29sZnJhbSBTYW5nIDx3c2ErcmVuZXNhc0BzYW5nLWVuZ2luZWVyaW5nLmNvbT4K PiBDYzogTGFycy1QZXRlciBDbGF1c2VuIDxsYXJzQG1ldGFmb28uZGU+Cj4gQ2M6IExhdXJlbnQg UGluY2hhcnQgPGxhdXJlbnQucGluY2hhcnRAaWRlYXNvbmJvYXJkLmNvbT4KPiBDYzogZHJpLWRl dmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+IAo+IEFyY2hpdCBUYW5lamEgKDEpOgo+ICAgZHJt L2JyaWRnZTogYWR2NzUxMTogRW5hYmxlIEhQRCBpbnRlcnJ1cHRzIHRvIHN1cHBvcnQgaG90cGx1 ZyBhbmQKPiAgICAgaW1wcm92ZSBtb25pdG9yIGRldGVjdGlvbgo+IAo+IEpvaG4gU3R1bHR6ICg0 KToKPiAgIGRybS9icmlkZ2U6IGFkdjc1MTE6IFVzZSB3b3JrX3N0cnVjdCB0byBkZWZlciBob3Rw bHVnIGhhbmRpbmcgdG8gb3V0Cj4gICAgIG9mIGlycSBjb250ZXh0Cj4gICBkcm0vYnJpZGdlOiBh ZHY3NTExOiBTd2l0Y2ggdG8gdXNpbmcgZHJtX2ttc19oZWxwZXJfaG90cGx1Z19ldmVudCgpCj4g ICBkcm0vYnJpZGdlOiBhZHY3NTExOiBSZXdvcmsgYWR2NzUxMV9wb3dlcl9vbi9vZmYoKSBzbyB0 aGV5IGNhbiBiZQo+ICAgICByZXVzZWQgaW50ZXJuYWxseQo+ICAgZHJtL2JyaWRnZTogYWR2NzUx MTogUmV1c2UgX19hZHY3NTExX3Bvd2VyX29uL29mZigpIHdoZW4gcHJvYmluZyBFRElECj4gCj4g IGRyaXZlcnMvZ3B1L2RybS9icmlkZ2UvYWR2NzUxMS9hZHY3NTExLmggICAgIHwgIDIgKwo+ICBk cml2ZXJzL2dwdS9kcm0vYnJpZGdlL2Fkdjc1MTEvYWR2NzUxMV9kcnYuYyB8IDYyCj4gKysrKysr KysrKysrKysrKysrKy0tLS0tLS0tLSAyIGZpbGVzIGNoYW5nZWQsIDQ0IGluc2VydGlvbnMoKyks IDIwCj4gZGVsZXRpb25zKC0pCgotLSAKUmVnYXJkcywKCkxhdXJlbnQgUGluY2hhcnQKCl9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWls aW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZy ZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751279AbdAPP4w (ORCPT ); Mon, 16 Jan 2017 10:56:52 -0500 Received: from galahad.ideasonboard.com ([185.26.127.97]:51144 "EHLO galahad.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751022AbdAPP4s (ORCPT ); Mon, 16 Jan 2017 10:56:48 -0500 From: Laurent Pinchart To: dri-devel@lists.freedesktop.org Cc: John Stultz , lkml , Wolfram Sang Subject: Re: [PATCH 0/5 v3] adv7511 EDID probing improvements Date: Mon, 16 Jan 2017 17:57:02 +0200 Message-ID: <9649749.TAVrhOzo15@avalon> User-Agent: KMail/4.14.10 (Linux/4.8.6-gentoo; KDE/4.14.24; x86_64; ; ) In-Reply-To: <1483472502-16403-1-git-send-email-john.stultz@linaro.org> References: <1483472502-16403-1-git-send-email-john.stultz@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi John, Thank you for the patches. On Tuesday 03 Jan 2017 11:41:37 John Stultz wrote: > Hope everyone had a good newyears! > > Wanted to re-send out v3 of this patch set improving the EDID > probing on the adv7511 used on HiKey, for consideration for > merging for 4.11 > > The first three patches are fixups that are hopefully straight > forward, integrating feedback I got from Laurant. > > The last two patches try to clean up and resue code, which as > a side effect avoids an issue I'm seeing where something is > going wrong with the regmap cache state for the > ADV7511_REG_EDID_I2C_ADDR(0x43) register which results in > i2c_transfer errors if we don't do the > regcache_sync/_mark_dirty() calls. I suspect there might be a > better solution there, but have not gotten any other suggestions > so I wanted to go ahead and submit these. > > Thoughts and feedback would be appreciated! For the whole series, Tested-by: Laurent Pinchart > New in v3: > * Addressed naming improvements and drm_kms_helper_hotplug_event > usage corrections as suggested by Laurent. > > Cc: David Airlie > Cc: Archit Taneja > Cc: Wolfram Sang > Cc: Lars-Peter Clausen > Cc: Laurent Pinchart > Cc: dri-devel@lists.freedesktop.org > > Archit Taneja (1): > drm/bridge: adv7511: Enable HPD interrupts to support hotplug and > improve monitor detection > > John Stultz (4): > drm/bridge: adv7511: Use work_struct to defer hotplug handing to out > of irq context > drm/bridge: adv7511: Switch to using drm_kms_helper_hotplug_event() > drm/bridge: adv7511: Rework adv7511_power_on/off() so they can be > reused internally > drm/bridge: adv7511: Reuse __adv7511_power_on/off() when probing EDID > > drivers/gpu/drm/bridge/adv7511/adv7511.h | 2 + > drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 62 > +++++++++++++++++++--------- 2 files changed, 44 insertions(+), 20 > deletions(-) -- Regards, Laurent Pinchart