From: David Howells <dhowells@redhat.com>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: dhowells@redhat.com, Alexander Beregalov <a.beregalov@gmail.com>,
arnd@arndb.de, linux-kernel@vger.kernel.org,
David Miller <davem@davemloft.net>
Subject: Re: [PATCH] BUG(): CONFIG_BUG=n version of BUG() should be unreachable()
Date: Tue, 05 Jan 2010 17:58:18 +0000 [thread overview]
Message-ID: <9664.1262714298@redhat.com> (raw)
In-Reply-To: <20091226184722.GA25275@merkur.ravnborg.org>
Sam Ravnborg <sam@ravnborg.org> wrote:
> +#define BUG() do { \
> + for (;;) \
> + /* endless loop*/; \
> + unreachable(); \
> +} while(0)
Can you not do:
#define BUG() do { \
unreachable(); \
} while(1)
instead? If the compiler is interpreting unreachable() to really mean that
what comes after will not be reached, then the condition/loop at the end of
the block should be optimised away.
David
next prev parent reply other threads:[~2010-01-05 17:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-23 1:17 [PATCH] BUG(): CONFIG_BUG=n version of BUG() should be unreachable() Alexander Beregalov
2009-12-23 1:26 ` David Daney
2009-12-23 1:37 ` David Daney
2009-12-30 19:12 ` Arnd Bergmann
2010-01-04 18:06 ` David Daney
2010-01-05 11:35 ` Arnd Bergmann
2009-12-26 18:47 ` Sam Ravnborg
2010-01-05 17:58 ` David Howells [this message]
2010-01-05 18:30 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9664.1262714298@redhat.com \
--to=dhowells@redhat.com \
--cc=a.beregalov@gmail.com \
--cc=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.