From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A31B0C7618E for ; Fri, 21 Apr 2023 07:21:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230077AbjDUHVU (ORCPT ); Fri, 21 Apr 2023 03:21:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60434 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229980AbjDUHVT (ORCPT ); Fri, 21 Apr 2023 03:21:19 -0400 Received: from mail-ej1-x633.google.com (mail-ej1-x633.google.com [IPv6:2a00:1450:4864:20::633]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 828EF102 for ; Fri, 21 Apr 2023 00:21:17 -0700 (PDT) Received: by mail-ej1-x633.google.com with SMTP id a640c23a62f3a-94a342f7c4cso209212866b.0 for ; Fri, 21 Apr 2023 00:21:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1682061675; x=1684653675; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=m5ELr7NOuHUY/ynanedA15kMHwV6wcIikVe8Is7rmn8=; b=AB8EOG1t+oft4jpC+v/284cWoHBR7USjcmk9UtO85zzyaEOBbNrioJUG8JViuQku84 /R9r3edytZo9ffXSblpIbqyGKrklK5QTzDVK3DQm606Dq8Kb2dXo5O27v4aHH1V0TK3b Yi3l2hZeCZrwUd5PgpnoJylM8yL0MdJQPCI9LSSpdEdhtEno161qJUMcW9iCogSK/3tY ORAZUWBAmpy+gzJ0PhvYmTEEbIpJz/QmJfXAEXzFZoTuBpaR5c3G57TgcUn+iCI+/Eb6 AIv7I8eRxU4MQF0DoRrOL94n2WebXBb+uJw2c1HeEVpe6ZUaGrrgWU6QZw0g3+pdheUe e4BQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682061675; x=1684653675; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=m5ELr7NOuHUY/ynanedA15kMHwV6wcIikVe8Is7rmn8=; b=act2WiskkyOSaDjSFf1kwesL8jRZuqh6Vb/OquciESHjDGNIiip5IYqPEMvz4WR3p/ T74vOtWlkrUsR413vR5/4Ss/BuZYh9bqEwLmTPZkQYPaWUaR3KSQyIK4tZJC2EtoutMq vsHx1sTjaAwA7TdRni3w24DibBy2WayPc4mBl/sRyQjVXMztA4oEnD4yqRkDmEXFDOs9 QuTv+7uLHFBo5EfKj1FqtARJuGLWSEEa+W7ZvqfZ11xVUgjj8ZMiuZszRiCffmtJezO/ sOyoum1ExUmGoj2xwuAocBp9uWkY8hNwmfMnFrxrJnW4S5j9fNJCCUwh2sSW3PjCwye0 fYHA== X-Gm-Message-State: AAQBX9cf0WF2lV88iYJjGv5GLLeEDqxNNJJmqzy6ywkNztu29BHJvW0g jt+gd+6Yrs1hHa+yNnAUFEG1WQ== X-Google-Smtp-Source: AKy350ZtOgORWSLsYISUnf4T9Rq2uCegqzIrNTgDf8dhtZSHGzR4IQvPxzVa1AlErkNKm+X32sL/ew== X-Received: by 2002:a17:906:c08c:b0:952:b51d:5086 with SMTP id f12-20020a170906c08c00b00952b51d5086mr1393877ejz.57.1682061675614; Fri, 21 Apr 2023 00:21:15 -0700 (PDT) Received: from ?IPV6:2a02:810d:15c0:828:668b:1e57:3caa:4d06? ([2a02:810d:15c0:828:668b:1e57:3caa:4d06]) by smtp.gmail.com with ESMTPSA id my34-20020a1709065a6200b0094f6f45b2c1sm1694801ejc.156.2023.04.21.00.21.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 21 Apr 2023 00:21:15 -0700 (PDT) Message-ID: <9664d548-f25f-a585-d655-8eb2e403fae4@linaro.org> Date: Fri, 21 Apr 2023 09:21:14 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v3 1/3] dt-bindings: iio: pressure: Support Honeywell mprls0025pa sensor Content-Language: en-US To: Andreas Klinger , linux-iio@vger.kernel.org, devicetree@vger.kernel.org Cc: Jonathan Cameron , Lars-Peter Clausen , Rob Herring , Krzysztof Kozlowski , Angel Iglesias , linux-kernel@vger.kernel.org References: From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On 20/04/2023 22:00, Andreas Klinger wrote: > Honeywell mpr is a pressure sensor series. There are many different models > with different pressure ranges, units and transfer functions. > > The range and transfer function need to be set up in the dt. Therefore new > properties honeywell,pmin-pascal, honeywell,pmax-pascal, > honeywell,transfer-function are introduced. > > Add dt-bindings. > > Signed-off-by: Andreas Klinger > --- > .../iio/pressure/honeywell,mprls0025pa.yaml | 98 +++++++++++++++++++ > 1 file changed, 98 insertions(+) > create mode 100644 Documentation/devicetree/bindings/iio/pressure/honeywell,mprls0025pa.yaml > > diff --git a/Documentation/devicetree/bindings/iio/pressure/honeywell,mprls0025pa.yaml b/Documentation/devicetree/bindings/iio/pressure/honeywell,mprls0025pa.yaml > new file mode 100644 > index 000000000000..80ab1beac7f6 > --- /dev/null > +++ b/Documentation/devicetree/bindings/iio/pressure/honeywell,mprls0025pa.yaml > @@ -0,0 +1,98 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/iio/pressure/honeywell,mprls0025pa.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Honeywell mpr series pressure sensor > + > +maintainers: > + - Andreas Klinger > + > +description: | > + Honeywell pressure sensor of model mprls0025pa. > + > + This sensor has an I2C and SPI interface. Only the I2C interface is implemented. > + > + There are many models with different pressure ranges available. The vendor calls them "mpr > + series". All of them have the identical programming model and differ in the pressure range, unit This is a friendly reminder during the review process. It seems my previous comments were not fully addressed. Maybe my feedback got lost between the quotes, maybe you just forgot to apply it. Please go back to the previous discussion and either implement all requested changes or keep discussing them. Thank you. Best regards, Krzysztof