From: Andrew Lunn <andrew@lunn.ch>
To: FUJITA Tomonori <fujita.tomonori@gmail.com>
Cc: netdev@vger.kernel.org, horms@kernel.org
Subject: Re: [PATCH net-next v2 1/6] net: tn40xx: add pci driver for Tehuti Networks TN40xx chips
Date: Thu, 25 Apr 2024 14:54:09 +0200 [thread overview]
Message-ID: <966aaf2a-a21c-4e8f-9ddd-a4541cfc94d2@lunn.ch> (raw)
In-Reply-To: <20240425010354.32605-2-fujita.tomonori@gmail.com>
> +#define TN40_DRV_VERSION "0.3.6.17.2"
A version is generally a bad idea. What does this version even mean,
given that you are re-writting the driver? You might as well call it
0.0.0.0.0.
We recommend that for ethtool, you leave the version field
untouched. The core will then fill it with the kernel version. That
version makes sense, since it gives you both the driver and the kernel
around it.
Andrew
next prev parent reply other threads:[~2024-04-25 12:54 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-25 1:03 [PATCH net-next v2 0/6] add ethernet driver for Tehuti Networks TN40xx chips FUJITA Tomonori
2024-04-25 1:03 ` [PATCH net-next v2 1/6] net: tn40xx: add pci " FUJITA Tomonori
2024-04-25 12:54 ` Andrew Lunn [this message]
2024-04-25 13:37 ` FUJITA Tomonori
2024-04-25 1:03 ` [PATCH net-next v2 2/6] net: tn40xx: add register defines FUJITA Tomonori
2024-04-25 1:03 ` [PATCH net-next v2 3/6] net: tn40xx: add basic Tx handling FUJITA Tomonori
2024-04-25 1:03 ` [PATCH net-next v2 4/6] net: tn40xx: add basic Rx handling FUJITA Tomonori
2024-04-25 1:03 ` [PATCH net-next v2 5/6] net: tn40xx: add mdio bus support FUJITA Tomonori
2024-04-25 1:03 ` [PATCH net-next v2 6/6] net: tn40xx: add PHYLIB support FUJITA Tomonori
2024-04-25 11:32 ` [PATCH net-next v2 0/6] add ethernet driver for Tehuti Networks TN40xx chips Jiri Pirko
2024-04-25 13:40 ` FUJITA Tomonori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=966aaf2a-a21c-4e8f-9ddd-a4541cfc94d2@lunn.ch \
--to=andrew@lunn.ch \
--cc=fujita.tomonori@gmail.com \
--cc=horms@kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.