From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F41C7C77B78 for ; Tue, 25 Apr 2023 07:27:09 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 61516859DE; Tue, 25 Apr 2023 09:27:04 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=ti.com header.i=@ti.com header.b="TwGkVyCk"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id BE5C880B98; Tue, 25 Apr 2023 09:27:01 +0200 (CEST) Received: from lelv0143.ext.ti.com (lelv0143.ext.ti.com [198.47.23.248]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 040D385D28 for ; Tue, 25 Apr 2023 09:26:56 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=n-francis@ti.com Received: from fllv0035.itg.ti.com ([10.64.41.0]) by lelv0143.ext.ti.com (8.15.2/8.15.2) with ESMTP id 33P7Qp0k052108; Tue, 25 Apr 2023 02:26:51 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1682407611; bh=0Oajw9Z9B4bOkHNsZ1HU0eGQHz6jfHhd1CnG0v1edKk=; h=Date:Subject:To:CC:References:From:In-Reply-To; b=TwGkVyCkb7gv8NeoyRUubx4IiFSnRUQYP8XwLxEiMCpo30s/QE6LPQL1XEEVzaxcE sa5KAJU98JMnvOMjjQkvBo1GtrqFs4a1iastKi4EUiflISKgTv0vnUAy0LGtmsxCFv 57xy3tyIkBUpyAIwMinP96zRX/LfANO0sDQMXgk0= Received: from DFLE113.ent.ti.com (dfle113.ent.ti.com [10.64.6.34]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 33P7QpWe057788 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 25 Apr 2023 02:26:51 -0500 Received: from DFLE115.ent.ti.com (10.64.6.36) by DFLE113.ent.ti.com (10.64.6.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.16; Tue, 25 Apr 2023 02:26:51 -0500 Received: from fllv0039.itg.ti.com (10.64.41.19) by DFLE115.ent.ti.com (10.64.6.36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.16 via Frontend Transport; Tue, 25 Apr 2023 02:26:50 -0500 Received: from [172.24.145.195] (ileaxei01-snat2.itg.ti.com [10.180.69.6]) by fllv0039.itg.ti.com (8.15.2/8.15.2) with ESMTP id 33P7QlV7065858; Tue, 25 Apr 2023 02:26:48 -0500 Message-ID: <966b3c41-a42b-6171-6276-cfbdf28dee79@ti.com> Date: Tue, 25 Apr 2023 12:56:47 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v3 09/19] am65: dts: binman: Package tiboot3.bin, sysfw.itb, tispl.bin, u-boot.img Content-Language: en-US To: Simon Glass CC: , , , , , , , , References: <20230421123203.1315330-1-n-francis@ti.com> <20230421123203.1315330-10-n-francis@ti.com> From: Neha Malcom Francis In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean Hi Simon, On 25/04/23 01:12, Simon Glass wrote: > Hi Neha, > > On Fri, 21 Apr 2023 at 06:32, Neha Malcom Francis wrote: >> >> Support added for HS and GP boot binaries for AM65x. >> >> tiboot3.bin, sysfw.itb, tispl.bin and u-boot.img: For HS devices >> tiboot3.bin_unsigned, sysfw.itb, tispl.bin_unsigned, >> u-boot.img_unsigned: For GP devices >> >> Note that the bootflow followed by AM65x requires: >> >> tiboot3.bin: >> * R5 SPL >> * R5 SPL dtbs >> sysfw.itb: >> * sysfw >> * board-cfg >> * pm-cfg >> * sec-cfg >> * rm-cfg >> >> tispl.bin: >> * ATF >> * OPTEE >> * A53 SPL >> * A53 SPL dtbs >> >> u-boot.img: >> * A53 U-Boot >> * A53 U-Boot dtbs >> >> Signed-off-by: Neha Malcom Francis >> --- >> arch/arm/dts/k3-am654-base-board-u-boot.dtsi | 1 + >> .../dts/k3-am654-r5-base-board-u-boot.dtsi | 1 + >> arch/arm/dts/k3-am65x-binman.dtsi | 551 ++++++++++++++++++ >> board/ti/am65x/Kconfig | 2 + >> 4 files changed, 555 insertions(+) >> create mode 100644 arch/arm/dts/k3-am65x-binman.dtsi > > Reviewed-by: Simon Glass > > Is there any way that these boards could share a .dtsi with just the > different bits in each board's dtsi? There seems to be a lot of > duplicate. > Maybe a common k3-binman.dtsi, but the common nodes (where the filenames of both the generated file as well as component files are all common) would be the ti-board-config ones... and if we change that as per last review comment to point to board/ti//config.bin then we'd have that particular to each device as well right? Or do you mean to say we use #defines for all? > Regards, > Simon -- Thanking You Neha Malcom Francis