From: "Christian König" <christian.koenig-5C7GfCeVMHo@public.gmane.org>
To: Huang Rui <ray.huang-5C7GfCeVMHo@public.gmane.org>,
amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org,
Alex Deucher <alexander.deucher-5C7GfCeVMHo@public.gmane.org>
Cc: Arindam Nath <Arindam.Nath-5C7GfCeVMHo@public.gmane.org>
Subject: Re: [PATCH 0/4] drm/amd/powerplay: introduce the cgs print helpers
Date: Thu, 8 Dec 2016 09:41:04 +0100 [thread overview]
Message-ID: <9672b4c9-a905-8fef-9fa4-cd0cbe94a67b@amd.com> (raw)
In-Reply-To: <1481174591-2187-1-git-send-email-ray.huang-5C7GfCeVMHo@public.gmane.org>
Sorry, but that just sounds like OS abstraction code which isn't allowed.
There is no benefit except routing all messages through CGS which makes
things much harder to follow.
Regards,
Christian.
Am 08.12.2016 um 06:23 schrieb Huang Rui:
> From: Huang Rui <Ray.Huang@amd.com>
>
> Hi all,
>
> These patch set adds the helpers of print in CGS. Powerplay will be
> used them instead of raw printk, and we can dynamic change the debug
> level with it.
>
> The prefix is like below:
>
> [ 310.200991] amdgpu 0000:01:00.0: [powerplay] ...
>
> Thanks,
> Rui
>
> Huang Rui (4):
> drm/amdgpu: introduce the cgs print helpers
> drm/amd/powerplay: update printk to cgs debug prints for smumgr
> drm/amd/powerplay: update printk to cgs debug prints for common part
> drm/amd/powerplay: update printk to cgs debug prints for hwmgr
>
> drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c | 26 +++++++++++-
> drivers/gpu/drm/amd/include/cgs_common.h | 24 +++++++++++
> drivers/gpu/drm/amd/powerplay/amd_powerplay.c | 49 +++++++++++-----------
> drivers/gpu/drm/amd/powerplay/eventmgr/eventinit.c | 2 +-
> drivers/gpu/drm/amd/powerplay/hwmgr/cz_hwmgr.c | 26 ++++++------
> .../gpu/drm/amd/powerplay/hwmgr/functiontables.c | 14 +++----
> drivers/gpu/drm/amd/powerplay/hwmgr/hwmgr.c | 8 ++--
> drivers/gpu/drm/amd/powerplay/hwmgr/ppatomctrl.c | 6 +--
> .../amd/powerplay/hwmgr/process_pptables_v1_0.c | 4 +-
> drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c | 26 ++++++------
> .../gpu/drm/amd/powerplay/hwmgr/smu7_powertune.c | 2 +-
> drivers/gpu/drm/amd/powerplay/inc/pp_debug.h | 14 +++----
> drivers/gpu/drm/amd/powerplay/smumgr/cz_smumgr.c | 28 ++++++-------
> drivers/gpu/drm/amd/powerplay/smumgr/fiji_smc.c | 4 +-
> drivers/gpu/drm/amd/powerplay/smumgr/fiji_smumgr.c | 8 ++--
> drivers/gpu/drm/amd/powerplay/smumgr/iceland_smc.c | 16 +++----
> .../gpu/drm/amd/powerplay/smumgr/iceland_smumgr.c | 2 +-
> .../gpu/drm/amd/powerplay/smumgr/polaris10_smc.c | 4 +-
> .../drm/amd/powerplay/smumgr/polaris10_smumgr.c | 8 ++--
> drivers/gpu/drm/amd/powerplay/smumgr/smu7_smumgr.c | 16 +++----
> drivers/gpu/drm/amd/powerplay/smumgr/tonga_smc.c | 14 +++----
> .../gpu/drm/amd/powerplay/smumgr/tonga_smumgr.c | 2 +-
> 22 files changed, 176 insertions(+), 127 deletions(-)
>
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
next prev parent reply other threads:[~2016-12-08 8:41 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-08 5:23 [PATCH 0/4] drm/amd/powerplay: introduce the cgs print helpers Huang Rui
[not found] ` <1481174591-2187-1-git-send-email-ray.huang-5C7GfCeVMHo@public.gmane.org>
2016-12-08 5:23 ` [PATCH 1/4] drm/amdgpu: " Huang Rui
2016-12-08 5:23 ` [PATCH 2/4] drm/amd/powerplay: update printk to cgs debug prints for smumgr Huang Rui
2016-12-08 5:23 ` [PATCH 3/4] drm/amd/powerplay: update printk to cgs debug prints for common part Huang Rui
2016-12-08 5:23 ` [PATCH 4/4] drm/amd/powerplay: update printk to cgs debug prints for hwmgr Huang Rui
2016-12-08 8:41 ` Christian König [this message]
[not found] ` <9672b4c9-a905-8fef-9fa4-cd0cbe94a67b-5C7GfCeVMHo@public.gmane.org>
2016-12-08 9:02 ` [PATCH 0/4] drm/amd/powerplay: introduce the cgs print helpers Huang Rui
2016-12-08 9:27 ` Christian König
[not found] ` <752e5cbf-0bcb-d42f-8542-6f7a788d9299-ANTagKRnAhcb1SvskN2V4Q@public.gmane.org>
2016-12-08 9:50 ` Huang Rui
2016-12-08 13:04 ` Grazvydas Ignotas
[not found] ` <CANOLnOOqGWKw5XdR-d=3GRrqWQ45KT_NJymWQW39kb0RtfK5Qw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-12-09 2:29 ` Huang Rui
2016-12-22 10:52 ` Huang Rui
2016-12-23 2:38 ` Huang Rui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9672b4c9-a905-8fef-9fa4-cd0cbe94a67b@amd.com \
--to=christian.koenig-5c7gfcevmho@public.gmane.org \
--cc=Arindam.Nath-5C7GfCeVMHo@public.gmane.org \
--cc=alexander.deucher-5C7GfCeVMHo@public.gmane.org \
--cc=amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
--cc=ray.huang-5C7GfCeVMHo@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.