Re: [PATCH v3 5/5] arm: bcmbca: make reset_cpu function weak

[Philippe REYNES <philippe.reynes@softathome.com>]

Hi William


Le 22/08/2022 à 20:19, William Zhang a écrit :
> BCM63158 carries the CONFIG_SYSRESET from the original configuration. It
> provide reset_cpu function already so need to define weak version of the
> dummy reset_cpu for other BCMBCA SoCs to avoid linking error.
>
> Signed-off-by: William Zhang <william.zhang@broadcom.com>


Reviewed-by: Philippe Reynes <philippe.reynes@softathome.com>


>
> ---
>
> Changes in v3:
> -Fix reset_cpu function prototype.
>
>   board/broadcom/bcmbca/board.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/board/broadcom/bcmbca/board.c b/board/broadcom/bcmbca/board.c
> index 4aa1d659d5c7..bcecb4d78392 100644
> --- a/board/broadcom/bcmbca/board.c
> +++ b/board/broadcom/bcmbca/board.c
> @@ -30,6 +30,6 @@ int print_cpuinfo(void)
>   	return 0;
>   }
>   
> -void reset_cpu(ulong addr)
> +__weak void reset_cpu(void)
>   {
>   }