From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Olaf Hering <olaf@aepfle.de>
Cc: <xen-devel@lists.xenproject.org>
Subject: Re: XEN_SYSCTL_cpu_policy_hvm_default truncates leaf count
Date: Thu, 1 Jul 2021 17:28:25 +0100 [thread overview]
Message-ID: <967b6463-c1bd-6ced-bec6-bafe02310e09@citrix.com> (raw)
In-Reply-To: <20210701182303.53756e1e.olaf@aepfle.de>
On 01/07/2021 17:23, Olaf Hering wrote:
> Am Thu, 1 Jul 2021 16:25:10 +0100
> schrieb Andrew Cooper <andrew.cooper3@citrix.com>:
>
>> - p->extd.max_leaf = min(p->extd.max_leaf, 0x1cu);
>> + p->extd.max_leaf = 0x80000000 | min(p->extd.max_leaf & 0xffff,
>> 0x1cu);
> Yes, this fixes it for me. Thanks.
Fantastic. I'll try and do a proper patch in due course.
On further thought, I think I'm going to go with the slightly simpler
p->extd.max_leaf = min(p->extd.max_leaf, 0x8000001c);
This is a policy obtained directly from Xen, which means it is running
on a 64bit capable system, which means that 0x80000008 is the lowest
number which can possibly exist in extd.max_leaf.
~Andrew
next prev parent reply other threads:[~2021-07-01 16:28 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-01 10:56 XEN_SYSCTL_cpu_policy_hvm_default truncates leaf count Olaf Hering
2021-07-01 11:19 ` Andrew Cooper
2021-07-01 11:36 ` Olaf Hering
2021-07-01 12:35 ` Andrew Cooper
2021-07-01 13:15 ` Olaf Hering
2021-07-01 15:00 ` Olaf Hering
2021-07-01 15:13 ` Andrew Cooper
2021-07-01 15:18 ` Olaf Hering
2021-07-01 15:25 ` Andrew Cooper
2021-07-01 16:23 ` Olaf Hering
2021-07-01 16:28 ` Andrew Cooper [this message]
2021-07-01 16:32 ` Olaf Hering
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=967b6463-c1bd-6ced-bec6-bafe02310e09@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=olaf@aepfle.de \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.