From: Xin Xie <xiexinet@gmail.com>
To: netdev-bot+sashiko@kernel.org
Cc: netdev@vger.kernel.org, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org, davem@davemloft.net,
edumazet@kernel.org, kuba@kernel.org, pabeni@redhat.com,
horms@kernel.org, andrew+netdev@lunn.ch, shuah@kernel.org,
kees@kernel.org, petr.wozniak@gmail.com, qingfang.deng@linux.dev,
fmaurer@redhat.com, luka.gejak@linux.dev, bigeasy@linutronix.de,
xiaoliang.yang_1@nxp.com, skhawaja@google.com,
liuhangbin@gmail.com, stable@vger.kernel.org,
sdf.kernel@gmail.com, lukma@denx.de, fmancera@suse.de,
danishanwar@ti.com
Subject: Re: [PATCH net v10 1/4] net: hsr: keep GRO disabled on HSR/PRP ports
Date: Fri, 20 Nov 2026 22:28:04 +0100 [thread overview]
Message-ID: <967fd174-41f5-4ff8-834c-19483dcb342e@gmail.com> (raw)
In-Reply-To: <179514132000.3136.2415655157145361596@kernel.org>
On 20/11/2026 03:22, netdev-bot+sashiko@kernel.org wrote:
> So the SET reply says GRO is wanted but not active. A later
> ETHTOOL_MSG_FEATURES_GET then reads dev->wanted_features in
> features_prepare_data() and shows GRO as not wanted.
This is intended, and the commit message says so: a GRO request on a
member is dropped, not kept pending. While GRO stays off,
ETHTOOL_SFEATURES returns no ETHTOOL_F_WISH and the netlink SET reply
shows the bit as not applied. A later GET reads the stored request,
which no longer has GRO; a SET reply and a GET can already differ in
the same way for a bit outside hw_features.
> Could the request stay in wanted_features, with only the computed
> features masked here?
Masking only the computed features is what v7 did, and it breaks veth,
which adds and deletes its NAPI instances according to wanted_features;
the commit message names the two failures. Changing veth is a separate
matter and not part of this fix.
--
Xin
next prev parent reply other threads:[~2026-11-20 21:28 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-17 14:19 [PATCH net v10 0/4] net: hsr: fix super-packet forwarding Xin Xie
2026-11-17 14:19 ` [PATCH net v10 1/4] net: hsr: keep GRO disabled on HSR/PRP ports Xin Xie
2026-11-20 2:22 ` netdev-bot+sashiko
2026-11-20 21:28 ` Xin Xie [this message]
2026-11-17 14:19 ` [PATCH net v10 2/4] net: hsr: refuse forwarding devices as " Xin Xie
2026-11-20 2:22 ` netdev-bot+sashiko
2026-11-20 21:30 ` Xin Xie
2026-11-17 14:19 ` [PATCH net v10 3/4] net: hsr: segment GSO before per-frame forwarding Xin Xie
2026-11-20 2:22 ` netdev-bot+sashiko
2026-11-20 21:32 ` Xin Xie
2026-11-17 14:19 ` [PATCH net v10 4/4] selftests: net: hsr: verify GRO policy and ordered forwarding Xin Xie
2026-11-20 2:22 ` netdev-bot+sashiko
2026-11-20 21:33 ` Xin Xie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=967fd174-41f5-4ff8-834c-19483dcb342e@gmail.com \
--to=xiexinet@gmail.com \
--cc=andrew+netdev@lunn.ch \
--cc=bigeasy@linutronix.de \
--cc=danishanwar@ti.com \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=fmancera@suse.de \
--cc=fmaurer@redhat.com \
--cc=horms@kernel.org \
--cc=kees@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=liuhangbin@gmail.com \
--cc=luka.gejak@linux.dev \
--cc=lukma@denx.de \
--cc=netdev-bot+sashiko@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=petr.wozniak@gmail.com \
--cc=qingfang.deng@linux.dev \
--cc=sdf.kernel@gmail.com \
--cc=shuah@kernel.org \
--cc=skhawaja@google.com \
--cc=stable@vger.kernel.org \
--cc=xiaoliang.yang_1@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.