From: David Ahern <dsahern@kernel.org>
To: Zhu Yanjun <yanjun.zhu@linux.dev>, Kuniyuki Iwashima <kuniyu@google.com>
Cc: Zhu Yanjun <zyjzyj2000@gmail.com>, Jason Gunthorpe <jgg@ziepe.ca>,
Leon Romanovsky <leon@kernel.org>,
Kuniyuki Iwashima <kuni1840@gmail.com>,
linux-rdma@vger.kernel.org,
syzbot+d8f76778263ab65c2b21@syzkaller.appspotmail.com
Subject: Re: [PATCH v2 1/2] RDMA/rxe: Fix null-ptr-deref in kernel_sock_shutdown().
Date: Mon, 27 Apr 2026 08:38:35 -0600 [thread overview]
Message-ID: <9681c9e2-79a9-4d72-b1ad-229ba6d7aab7@kernel.org> (raw)
In-Reply-To: <e2e1406f-8d9d-4a96-949d-e75096446d1a@linux.dev>
On 4/26/26 9:53 PM, Zhu Yanjun wrote:
>> That said, I don't have a strong preference, so up to you
>> maintainers. Simple lockless solution vs per-newlink/dellink
>> locking.
> To be honest, I do not have a strong preference here, though
>
> I lean slightly toward the per-newlink/dellink locking approach.
>
> Both the simple lockless solution and the locking approach seem
>
> reasonable, depending on whether we prioritize simplicity or
>
> explicit synchronization and lifecycle clarity.
>
> It would be helpful to get feedback from David Ahern, Leon,
>
> and Jason to converge on a final direction.
Going in circles. I have said from the beginning of network namespace
support for rxe do not open the port until first rxe device create and
once opened leave it open. Simple design that limits socket churn to
users wanting to leverage rxe in a network namespace. Zhu Yanjun, if you
are going to be a maintainer of a feature you need to have a consistent
stance on the architecture and code design.
next prev parent reply other threads:[~2026-04-27 14:38 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-25 6:04 [PATCH v2 0/2] RDMA/rxe: Fix per-netns UDP tunnel issues Kuniyuki Iwashima
2026-04-25 6:04 ` [PATCH v2 1/2] RDMA/rxe: Fix null-ptr-deref in kernel_sock_shutdown() Kuniyuki Iwashima
2026-04-25 15:47 ` David Ahern
2026-04-25 20:55 ` Kuniyuki Iwashima
2026-04-26 16:40 ` David Ahern
2026-04-25 21:25 ` Zhu Yanjun
2026-04-26 16:42 ` David Ahern
2026-04-27 2:57 ` Zhu Yanjun
2026-04-27 3:10 ` Kuniyuki Iwashima
2026-04-27 3:53 ` Zhu Yanjun
2026-04-27 14:38 ` David Ahern [this message]
2026-04-27 20:20 ` yanjun.zhu
2026-04-28 0:52 ` Kuniyuki Iwashima
2026-04-28 0:58 ` David Ahern
2026-04-28 2:15 ` Zhu Yanjun
2026-04-28 5:12 ` Zhu Yanjun
2026-04-28 5:22 ` Kuniyuki Iwashima
2026-04-28 6:30 ` Zhu Yanjun
2026-04-28 6:39 ` Kuniyuki Iwashima
2026-04-28 16:56 ` yanjun.zhu
2026-04-25 6:04 ` [PATCH v2 2/2] RDMA/rxe: Fix up RCU usage for rxe_ns_pernet_sk6() Kuniyuki Iwashima
2026-04-25 21:26 ` Zhu Yanjun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9681c9e2-79a9-4d72-b1ad-229ba6d7aab7@kernel.org \
--to=dsahern@kernel.org \
--cc=jgg@ziepe.ca \
--cc=kuni1840@gmail.com \
--cc=kuniyu@google.com \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=syzbot+d8f76778263ab65c2b21@syzkaller.appspotmail.com \
--cc=yanjun.zhu@linux.dev \
--cc=zyjzyj2000@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.