From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B05F4CD37AC for ; Thu, 14 May 2026 02:50:51 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 1686884676; Thu, 14 May 2026 04:50:50 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=reject dis=none) header.from=nabladev.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=nabladev.com header.i=@nabladev.com header.b="HYOl8Clc"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 3F6B98467F; Thu, 14 May 2026 04:50:48 +0200 (CEST) Received: from mx.nabladev.com (mx.nabladev.com [IPv6:2a00:f820:417:0:178:251:229:89]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 5B5F68056B for ; Thu, 14 May 2026 04:50:46 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=reject dis=none) header.from=nabladev.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=hs@nabladev.com Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 00E2810D14B; Thu, 14 May 2026 04:50:41 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nabladev.com; s=dkim; t=1778727045; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:content-language:in-reply-to:references; bh=YG30P02Uk/NdDdiLEvBNhCZS5L3YQdSRwSbGgMokdFs=; b=HYOl8Clcse64AR2OSrJmdtOTogCPIO/0aA5WagdzRqsjJ6PPLQyWxAi/x7LI3zJGi6+m+t ihzHewJPV5JE/4XtUrXqPdu7raiayHoldUjPNWt/gQ9nafN86WhwFeLhHKY2Ud2BOE8EiT THXwYA4BUgqsknn/Xh4xyEvVoKozyWzokWuXDamjCQTnEc4ijWeoig3mgQ6Jznfr+h80RM RWVl4FxcB5X12KGJxWdWHzXOEDXp/c0RCMVsRc64hZV57JOGaeLE9rhqEpuqjqTPkKsRtq 8bs0O6/u9Fck9C8RLQLP7NLGzP8GThBm+Bpx1Bj6QfCz2UCLvx/bdaUV04DWYQ== Message-ID: <96868c0e-277e-ff6b-8cab-985ec0b91dcb@nabladev.com> Date: Thu, 14 May 2026 04:50:15 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 Subject: Re: [PATCH] fs: ubifs: remove dead code Content-Language: en-US To: Peter Collingbourne , Tom Rini Cc: Andrew Goodbody , Patrice Chotard , Peng Fan , Yao Zi , u-boot@lists.denx.de, Kyungmin Park References: <20260512055008.9357-1-peter@pcc.me.uk> From: Heiko Schocher In-Reply-To: <20260512055008.9357-1-peter@pcc.me.uk> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Last-TLS-Session-Version: TLSv1.3 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean Hello Peter, On 12.05.26 07:50, Peter Collingbourne wrote: > This code is dead because it appears after an infinite loop; remove it. > > Fixes: 4c4477c77008 ("fs: ubifs: fix bugs involving symlinks in ubifs_findfile") Wrong commit ID? I find in current HEAD: """ commit d5888d509cc43942ec98d993f2d129f5c8ddc432 Author: Peter Collingbourne Date: Tue May 5 03:38:16 2026 -0700 fs: ubifs: fix bugs involving symlinks in ubifs_findfile """ > Signed-off-by: Peter Collingbourne > --- > fs/ubifs/ubifs.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/fs/ubifs/ubifs.c b/fs/ubifs/ubifs.c > index aafbd01a028..3f2e2037745 100644 > --- a/fs/ubifs/ubifs.c > +++ b/fs/ubifs/ubifs.c > @@ -608,9 +608,6 @@ static unsigned long ubifs_findfile(struct super_block *sb, char *filename) > root_inum = inum; > name = next; > } > - > - kfree(buf); > - return 0; May we need to stay with "return 0;" at the end of the function, as some source code checking tool will claim if there is none? Beside of the nitpick: Reviewed-by: Heiko Schocher If you find time to send a v2 with updated commit ID I would be happy, else I can fix it when picking up the patch, if okay for you. Thanks! bye, Heiko -- Nabla Software Engineering HRB 40522 Augsburg Phone: +49 821 45592596 E-Mail: office@nabladev.com Geschäftsführer : Stefano Babic