All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bart Van Assche <bvanassche@acm.org>
To: peter.wang@mediatek.com, stanley.chu@mediatek.com,
	linux-scsi@vger.kernel.org, martin.petersen@oracle.com,
	avri.altman@wdc.com, alim.akhtar@samsung.com, jejb@linux.ibm.com
Cc: wsd_upstream@mediatek.com, linux-mediatek@lists.infradead.org,
	chun-hung.wu@mediatek.com, alice.chao@mediatek.com,
	cc.chou@mediatek.com, chaotian.jing@mediatek.com,
	jiajie.hao@mediatek.com, powen.kao@mediatek.com,
	qilin.tan@mediatek.com, lin.gui@mediatek.com
Subject: Re: [PATCH v1 0/2] ufs: allow vendor disable wb toggle in clock scaling
Date: Thu, 28 Jul 2022 14:09:03 -0700	[thread overview]
Message-ID: <968f5255-f7b9-e011-2bd3-aa711bdd142a@acm.org> (raw)
In-Reply-To: <20220728071637.22364-1-peter.wang@mediatek.com>

On 7/28/22 00:16, peter.wang@mediatek.com wrote:
> Mediatek ufs do not want to toggle write booster when clock scaling.
> This patch set allow vendor disable wb toggle in clock scaling.

I don't like this approach. Whether or not to toggle the write booster 
when scaling the clock is not dependent on the host controller and hence 
should not depend on the host controller driver.

Has it been considered to add a sysfs attribute in the UFS driver core 
to control this behavior?

Thanks,

Bart.


  parent reply	other threads:[~2022-07-28 21:09 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-28  7:16 [PATCH v1 0/2] ufs: allow vendor disable wb toggle in clock scaling peter.wang
2022-07-28  7:16 ` [PATCH v1 1/2] ufs: core: interduce a choice of " peter.wang
2022-07-28 21:41   ` Bean Huo
2022-08-01 14:31     ` Peter Wang
2022-07-28  7:16 ` [PATCH v1 2/2] ufs: host: support wb toggle with " peter.wang
2022-07-28 21:57   ` Bean Huo
2022-08-01 14:32     ` Peter Wang
2022-07-28 20:43 ` [PATCH v1 0/2] ufs: allow vendor disable wb toggle in " Avri Altman
2022-08-01 14:28   ` Peter Wang
2022-07-28 21:09 ` Bart Van Assche [this message]
2022-07-28 21:26   ` Bean Huo
2022-08-01  2:11     ` Stanley Chu
2022-08-01 14:30   ` Peter Wang
2022-08-01 16:43     ` Bart Van Assche
2022-08-01 17:58       ` Asutosh Das (asd)
2022-08-01 17:57 ` Christoph Hellwig
2022-08-01 18:12   ` Bart Van Assche
2022-08-01 18:14     ` Christoph Hellwig
2022-08-02  3:25       ` Peter Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=968f5255-f7b9-e011-2bd3-aa711bdd142a@acm.org \
    --to=bvanassche@acm.org \
    --cc=alice.chao@mediatek.com \
    --cc=alim.akhtar@samsung.com \
    --cc=avri.altman@wdc.com \
    --cc=cc.chou@mediatek.com \
    --cc=chaotian.jing@mediatek.com \
    --cc=chun-hung.wu@mediatek.com \
    --cc=jejb@linux.ibm.com \
    --cc=jiajie.hao@mediatek.com \
    --cc=lin.gui@mediatek.com \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=peter.wang@mediatek.com \
    --cc=powen.kao@mediatek.com \
    --cc=qilin.tan@mediatek.com \
    --cc=stanley.chu@mediatek.com \
    --cc=wsd_upstream@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.