From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: dev@dpdk.org
Subject: Re: [PATCH] lib: remove "extern" keyword for functions from header files
Date: Wed, 27 Jan 2016 19:05:52 +0100 [thread overview]
Message-ID: <96929867.upEFuzBccp@xps13> (raw)
In-Reply-To: <1453716075-28150-1-git-send-email-ferruh.yigit@intel.com>
2016-01-25 10:01, Ferruh Yigit:
> Remove "extern" keywords in header files, the ones for function
> prototypes
I've seen a lot of other extern keywords. Why not removing all?
> -extern int rte_eth_dev_configure(uint8_t port_id,
> - uint16_t nb_rx_queue,
> - uint16_t nb_tx_queue,
> - const struct rte_eth_conf *eth_conf);
> +int rte_eth_dev_configure(uint8_t port_id, uint16_t nb_rx_queue,
> + uint16_t nb_tx_queue,
> + const struct rte_eth_conf *eth_conf);
The indent is weird.
Why not follow the guideline with 2 tabs?
http://dpdk.org/doc/guides-2.2/contributing/coding_style.html#c-indentation
next prev parent reply other threads:[~2016-01-27 18:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-25 10:01 [PATCH] lib: remove "extern" keyword for functions from header files Ferruh Yigit
2016-01-27 18:05 ` Thomas Monjalon [this message]
2016-01-28 10:11 ` Ferruh Yigit
2016-01-28 13:39 ` Thomas Monjalon
2016-01-28 14:31 ` [PATCH v2] " Ferruh Yigit
2016-01-28 17:04 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=96929867.upEFuzBccp@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.