All of lore.kernel.org
 help / color / mirror / Atom feed
From: Xiaoyao Li <xiaoyao.li@intel.com>
To: "Daniel P. Berrangé" <berrange@redhat.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Philippe Mathieu-Daudé" <philmd@linaro.org>,
	qemu-devel@nongnu.org
Subject: Re: [PATCH 3/5] qemu-options: Change memory-encryption to confidential-guest-support in the example
Date: Mon, 15 Sep 2025 16:34:51 +0800	[thread overview]
Message-ID: <969ecc08-0ffe-4390-9847-c94fcbed70c1@intel.com> (raw)
In-Reply-To: <aMPYkUsytGxLPIM7@redhat.com>

On 9/12/2025 4:23 PM, Daniel P. Berrangé wrote:
> On Fri, Sep 12, 2025 at 09:17:35AM +0100, Daniel P. Berrangé wrote:
>> On Mon, Jul 14, 2025 at 05:19:51PM +0800, Xiaoyao Li wrote:
>>> "confidential-guest-support" is the recommended property instead of
>>> "memory-encryption". Switch to "confidential-guest-support" in the
>>> example of sev-guest.
>>>
>>> Signed-off-by: Xiaoyao Li <xiaoyao.li@intel.com>
>>> ---
>>>   qemu-options.hx | 2 +-
>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
> 
> Incidentally, how about adding another patch that declares 'memory-encryption'
> as deprecated (print a warning to stderr if used, and add note to
> docs/about/deprecated.rst).
> 
> We've had 'confidential-guest-support' for long enough that no one should
> be using 'memory-encryption' anymore, so it is time to start the clock
> for its removal.

Sure, I will add an additional patch to deprecate "memory-encryption".

And thanks for reviewing the series!

> 
> With regards,
> Daniel



  reply	other threads:[~2025-09-15  8:36 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-14  9:19 [PATCH 0/5] qemu-optios: Fix, cleanup and add description of tdx-guest Xiaoyao Li
2025-07-14  9:19 ` [PATCH 1/5] qemu-options: Move sgx-epc options from "M" to "machine" Xiaoyao Li
2025-09-12  8:16   ` Daniel P. Berrangé
2025-07-14  9:19 ` [PATCH 2/5] i386/sev: Remove the example that references memory-encryption Xiaoyao Li
2025-09-12  8:16   ` Daniel P. Berrangé
2025-07-14  9:19 ` [PATCH 3/5] qemu-options: Change memory-encryption to confidential-guest-support in the example Xiaoyao Li
2025-09-12  8:17   ` Daniel P. Berrangé
2025-09-12  8:23     ` Daniel P. Berrangé
2025-09-15  8:34       ` Xiaoyao Li [this message]
2025-07-14  9:19 ` [PATCH 4/5] qemu-options: Add confidential-guest-support to machine options Xiaoyao Li
2025-09-12  8:19   ` Daniel P. Berrangé
2025-07-14  9:19 ` [PATCH 5/5] qemu-options: Add description of tdx-guest object Xiaoyao Li
2025-09-12  8:22   ` Daniel P. Berrangé
2025-07-14  9:31 ` [PATCH 0/5] qemu-optios: Fix, cleanup and add description of tdx-guest Xiaoyao Li
2025-09-12  5:57 ` Xiaoyao Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=969ecc08-0ffe-4390-9847-c94fcbed70c1@intel.com \
    --to=xiaoyao.li@intel.com \
    --cc=berrange@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=philmd@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.