All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Mi, Dapeng" <dapeng1.mi@linux.intel.com>
To: Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>,
	Arnaldo Carvalho de Melo <acme@kernel.org>,
	Namhyung Kim <namhyung@kernel.org>,
	Ian Rogers <irogers@google.com>,
	Adrian Hunter <adrian.hunter@intel.com>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Andi Kleen <ak@linux.intel.com>,
	Eranian Stephane <eranian@google.com>
Cc: linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
	Dapeng Mi <dapeng1.mi@intel.com>, Zide Chen <zide.chen@intel.com>,
	Falcon Thomas <thomas.falcon@intel.com>,
	Xudong Hao <xudong.hao@intel.com>
Subject: Re: [PATCH 0/2] Fix 2 bugs for Intel auto counter reload (ACR)
Date: Mon, 13 Apr 2026 09:19:47 +0800	[thread overview]
Message-ID: <96a7f3f9-77cd-46f9-b16f-54b4ce9c7ec8@linux.intel.com> (raw)
In-Reply-To: <20260413010157.535990-1-dapeng1.mi@linux.intel.com>


On 4/13/2026 9:01 AM, Dapeng Mi wrote:
> This small patch-set fixes 2 issues in auto counter reload support.
> - The stale ACR mask is not cleared before setting a new one. Patch 1/2
>   fixes this issue.
> - PMI is enabled by default for self-reloaded ACR events which causes
>   suspicious NMI warning. Patch 2/2 fixes this issue.
>
> Besides an ACR unit test is added into perf tests which would be posted
> in a separate session.

The unit test patch:
https://lore.kernel.org/all/20260413010920.546501-1-dapeng1.mi@linux.intel.com/

Thanks.


>
> Tests:
>
> Run below ACR sampling commands on CWF and NVL (hybrid platform), no
> issues are found.
>
> a. Non-PEBS ACR sampling
>
> perf record -e '{instructions/period=20000,acr_mask=0x2/u,cycles/period=40000,acr_mask=0x3/u}' ~/test
>
> b. PEBS ACR sampling
>
> perf record -e '{instructions/period=20000,acr_mask=0x2/pu,cycles/period=40000,acr_mask=0x3/u}' ~/test
>
>
> Dapeng Mi (2):
>   perf/x86/intel: Clear stale ACR mask before updating new mask
>   perf/x86/intel: Disable PMI for self-reloaded ACR events
>
>  arch/x86/events/intel/core.c | 20 ++++++++++++++++----
>  arch/x86/events/perf_event.h | 10 ++++++++++
>  2 files changed, 26 insertions(+), 4 deletions(-)
>
>
> base-commit: 9805ed3c91478b08a586861b874bd8b6a2fed648

      parent reply	other threads:[~2026-04-13  1:19 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-13  1:01 [PATCH 0/2] Fix 2 bugs for Intel auto counter reload (ACR) Dapeng Mi
2026-04-13  1:01 ` [PATCH 1/2] perf/x86/intel: Clear stale ACR mask before updating new mask Dapeng Mi
2026-04-13  1:35   ` sashiko-bot
2026-04-14  2:57     ` Mi, Dapeng
2026-04-13  1:01 ` [PATCH 2/2] perf/x86/intel: Disable PMI for self-reloaded ACR events Dapeng Mi
2026-04-13  1:19 ` Mi, Dapeng [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=96a7f3f9-77cd-46f9-b16f-54b4ce9c7ec8@linux.intel.com \
    --to=dapeng1.mi@linux.intel.com \
    --cc=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=ak@linux.intel.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=dapeng1.mi@intel.com \
    --cc=eranian@google.com \
    --cc=irogers@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    --cc=thomas.falcon@intel.com \
    --cc=xudong.hao@intel.com \
    --cc=zide.chen@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.