RE: [PATCH 5/9] wifi: rtw88: Add rtw8703b.c

[Ping-Ke Shih <pkshih@realtek.com>]

> -----Original Message-----
> From: Ping-Ke Shih <pkshih@realtek.com>
> Sent: Tuesday, February 6, 2024 9:38 AM
> To: Fiona Klute <fiona.klute@gmx.de>; linux-wireless@vger.kernel.org
> Cc: Kalle Valo <kvalo@kernel.org>; Ulf Hansson <ulf.hansson@linaro.org>; linux-mmc@vger.kernel.org; Pavel
> Machek <pavel@ucw.cz>; Ondřej Jirman <megi@xff.cz>
> Subject: RE: [PATCH 5/9] wifi: rtw88: Add rtw8703b.c
> 
> 
> 
> > -----Original Message-----
> > From: Fiona Klute <fiona.klute@gmx.de>
> > Sent: Tuesday, February 6, 2024 3:06 AM
> > To: Ping-Ke Shih <pkshih@realtek.com>; linux-wireless@vger.kernel.org
> > Cc: Kalle Valo <kvalo@kernel.org>; Ulf Hansson <ulf.hansson@linaro.org>; linux-mmc@vger.kernel.org;
> Pavel
> > Machek <pavel@ucw.cz>; Ondřej Jirman <megi@xff.cz>
> > Subject: Re: [PATCH 5/9] wifi: rtw88: Add rtw8703b.c
> >
> > >> +
> > >> +       if (ret != 0)
> > >> +               return ret;
> > >> +
> > >> +#ifdef CONFIG_OF
> > >> +       /* Prefer MAC from DT, if available. On some devices like the
> > >> +        * Pinephone that might be the only way to get a valid MAC.
> > >> +        */
> > >> +       struct device_node *node = rtwdev->dev->of_node;
> > >
> > > Should move this statement to topmost of this function? no compiler warning?
> > >
> > > Or, make an individual function to read mac addr from DT?
> >
> > I can move that to a separate function if you prefer, see below for the
> > compiler warning.
> 
> Because this is CONFIG_OF chunk, it will look like below if you move declaration upward:
> 
> #ifdef CONFIG_OF
> 	struct device_node *node = rtwdev->dev->of_node;
> #endif
> 	// other declaration ...
> 
> 	// other code
> #ifdef CONFIG_OF
> 	if (node) {
> 		...
> 	}
> #endif
> 
> It seems like too much #ifdef. With a separate function, it can be single #ifdef.
> That is my point.
> 

If CONFIG_OF isn't defined, compiler will select a static inline function that
just returns -ENODEV [1], so I think you don't need a #ifdef chunk here. 

[1] https://elixir.bootlin.com/linux/latest/source/include/linux/of_net.h#L27