From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0CD2C433F5 for ; Wed, 13 Apr 2022 08:06:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233407AbiDMIJP (ORCPT ); Wed, 13 Apr 2022 04:09:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59672 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230280AbiDMIJN (ORCPT ); Wed, 13 Apr 2022 04:09:13 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 0A1FE23BCB for ; Wed, 13 Apr 2022 01:06:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1649837212; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3oVDDbPJyK3HgpM5oKcpbE9J9tBIr9ChlAXnnhFjPGo=; b=Rq0q8++Xi27HcGMM6eqZPq/o/KxjUDCaRcJ9trsqEXRF9Y94Ll5SjwnocNTk+SW3GwVeor pg0ZsmNJxFX8PJJb9/w/3ZPbTvc+B8YRs9rQBExCnAjMuK7GdNJWj2GMVoVHbfNZOzJFDq PFvN9yzRIo2qjLC2FgKOxVHo+1vFxeI= Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-338-r4WOd62zO6CP0tHkY1RTuA-1; Wed, 13 Apr 2022 04:06:51 -0400 X-MC-Unique: r4WOd62zO6CP0tHkY1RTuA-1 Received: by mail-pj1-f69.google.com with SMTP id e12-20020a17090a7c4c00b001cb1b3274c9so842341pjl.4 for ; Wed, 13 Apr 2022 01:06:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=3oVDDbPJyK3HgpM5oKcpbE9J9tBIr9ChlAXnnhFjPGo=; b=D6/Ju0cKTBYB2tlU0ySKawjl98bDTbE1w3puMQRy5pjX002s6KdaLusbh1Y7rgfzsj RQfiE6sjQH85FmejdYnO3Z24NEZEofN+wQQ9sV9Qd6Tu9rEGgbzbdsFXzs9yq+7XBSIL GcokYeQo/zVIdGLpEEqHMXCfJT2u9AnaCOHbRJfRDZW9POX+Z0eZ2yqsro6JA9UHGTnB r3VMfN355VoKF9e4XuHBM6bbWHXYz5LzM82aC/EtLzTIITxpQcua/7ERqZyXUvtE28et O5cOLJICLPQiZ1mcMsMBuTbUAKw6VaUhJOTVvl4qBiscyyxyvG2mN+WoRSM2r1wWHa/j yCEQ== X-Gm-Message-State: AOAM532k0+V3fuhN4Z2BsyXpJ/+fSDWyS255kTOAiQhrtkVC0KL/5cAr x/tZPvvgHaYlL0O81uoIir+sVj2d6HpybBLo6bwof9e7XiT3M0k8yStSiyQs5zEA0DMi/YN3HSj FGMEQrwDRIa7A X-Received: by 2002:a17:90b:1e06:b0:1cb:b742:ba0d with SMTP id pg6-20020a17090b1e0600b001cbb742ba0dmr9526911pjb.24.1649837209894; Wed, 13 Apr 2022 01:06:49 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxA8440BQVqz6KdwXBOHrMtT4WnGyMxsQffyGtbEDMm0ObQF/C2qu9IScvqE/FloA/61fylAQ== X-Received: by 2002:a17:90b:1e06:b0:1cb:b742:ba0d with SMTP id pg6-20020a17090b1e0600b001cbb742ba0dmr9526892pjb.24.1649837209610; Wed, 13 Apr 2022 01:06:49 -0700 (PDT) Received: from [10.72.13.223] ([209.132.188.80]) by smtp.gmail.com with ESMTPSA id p10-20020a17090a680a00b001c7bf7d32f9sm1982517pjj.55.2022.04.13.01.06.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 13 Apr 2022 01:06:49 -0700 (PDT) Message-ID: <96d1fe97-2e8a-ae8a-a35f-bba2ce0f44b4@redhat.com> Date: Wed, 13 Apr 2022 16:06:33 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH v9 32/32] virtio_net: support set_ringparam Content-Language: en-US To: Xuan Zhuo , virtualization@lists.linux-foundation.org Cc: Jeff Dike , Richard Weinberger , Anton Ivanov , "Michael S. Tsirkin" , "David S. Miller" , Jakub Kicinski , Hans de Goede , Mark Gross , Vadim Pasternak , Bjorn Andersson , Mathieu Poirier , Cornelia Huck , Halil Pasic , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , Alexander Gordeev , Sven Schnelle , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , Johannes Berg , Vincent Whitchurch , linux-um@lists.infradead.org, netdev@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org, kvm@vger.kernel.org, bpf@vger.kernel.org References: <20220406034346.74409-1-xuanzhuo@linux.alibaba.com> <20220406034346.74409-33-xuanzhuo@linux.alibaba.com> From: Jason Wang In-Reply-To: <20220406034346.74409-33-xuanzhuo@linux.alibaba.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org 在 2022/4/6 上午11:43, Xuan Zhuo 写道: > Support set_ringparam based on virtio queue reset. > > Users can use ethtool -G eth0 to modify the ring size of > virtio-net. > > Signed-off-by: Xuan Zhuo Acked-by: Jason Wang (One thing that I see is that, when resize fails, the param reported via get_ringparam might be wrong, this is a corner case but might worth to fix in the future). > --- > drivers/net/virtio_net.c | 47 ++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 47 insertions(+) > > diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c > index ba6859f305f7..37e4e27f1e4e 100644 > --- a/drivers/net/virtio_net.c > +++ b/drivers/net/virtio_net.c > @@ -2264,6 +2264,52 @@ static void virtnet_get_ringparam(struct net_device *dev, > ring->tx_pending = virtqueue_get_vring_size(vi->sq[0].vq); > } > > +static int virtnet_set_ringparam(struct net_device *dev, > + struct ethtool_ringparam *ring, > + struct kernel_ethtool_ringparam *kernel_ring, > + struct netlink_ext_ack *extack) > +{ > + struct virtnet_info *vi = netdev_priv(dev); > + u32 rx_pending, tx_pending; > + struct receive_queue *rq; > + struct send_queue *sq; > + int i, err; > + > + if (ring->rx_mini_pending || ring->rx_jumbo_pending) > + return -EINVAL; > + > + rx_pending = virtqueue_get_vring_size(vi->rq[0].vq); > + tx_pending = virtqueue_get_vring_size(vi->sq[0].vq); > + > + if (ring->rx_pending == rx_pending && > + ring->tx_pending == tx_pending) > + return 0; > + > + if (ring->rx_pending > virtqueue_get_vring_max_size(vi->rq[0].vq)) > + return -EINVAL; > + > + if (ring->tx_pending > virtqueue_get_vring_max_size(vi->sq[0].vq)) > + return -EINVAL; > + > + for (i = 0; i < vi->max_queue_pairs; i++) { > + rq = vi->rq + i; > + sq = vi->sq + i; > + > + if (ring->tx_pending != tx_pending) { > + err = virtnet_tx_resize(vi, sq, ring->tx_pending); > + if (err) > + return err; > + } > + > + if (ring->rx_pending != rx_pending) { > + err = virtnet_rx_resize(vi, rq, ring->rx_pending); > + if (err) > + return err; > + } > + } > + > + return 0; > +} > > static void virtnet_get_drvinfo(struct net_device *dev, > struct ethtool_drvinfo *info) > @@ -2497,6 +2543,7 @@ static const struct ethtool_ops virtnet_ethtool_ops = { > .get_drvinfo = virtnet_get_drvinfo, > .get_link = ethtool_op_get_link, > .get_ringparam = virtnet_get_ringparam, > + .set_ringparam = virtnet_set_ringparam, > .get_strings = virtnet_get_strings, > .get_sset_count = virtnet_get_sset_count, > .get_ethtool_stats = virtnet_get_ethtool_stats, From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1neY1f-00HXja-MQ for linux-um@lists.infradead.org; Wed, 13 Apr 2022 08:06:59 +0000 Received: by mail-pg1-f199.google.com with SMTP id 199-20020a6307d0000000b0039d99823fafso725321pgh.8 for ; Wed, 13 Apr 2022 01:06:50 -0700 (PDT) Message-ID: <96d1fe97-2e8a-ae8a-a35f-bba2ce0f44b4@redhat.com> Date: Wed, 13 Apr 2022 16:06:33 +0800 MIME-Version: 1.0 Subject: Re: [PATCH v9 32/32] virtio_net: support set_ringparam References: <20220406034346.74409-1-xuanzhuo@linux.alibaba.com> <20220406034346.74409-33-xuanzhuo@linux.alibaba.com> From: Jason Wang In-Reply-To: <20220406034346.74409-33-xuanzhuo@linux.alibaba.com> Content-Language: en-US List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-um" Errors-To: linux-um-bounces+geert=linux-m68k.org@lists.infradead.org To: Xuan Zhuo , virtualization@lists.linux-foundation.org Cc: Jeff Dike , Richard Weinberger , Anton Ivanov , "Michael S. Tsirkin" , "David S. Miller" , Jakub Kicinski , Hans de Goede , Mark Gross , Vadim Pasternak , Bjorn Andersson , Mathieu Poirier , Cornelia Huck , Halil Pasic , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , Alexander Gordeev , Sven Schnelle , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , Johannes Berg , Vincent Whitchurch , linux-um@lists.infradead.org, netdev@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org, kvm@vger.kernel.org, bpf@vger.kernel.org CuWcqCAyMDIyLzQvNiDkuIrljYgxMTo0MywgWHVhbiBaaHVvIOWGmemBkzoKPiBTdXBwb3J0IHNl dF9yaW5ncGFyYW0gYmFzZWQgb24gdmlydGlvIHF1ZXVlIHJlc2V0Lgo+Cj4gVXNlcnMgY2FuIHVz ZSBldGh0b29sIC1HIGV0aDAgPHJpbmdfbnVtPiB0byBtb2RpZnkgdGhlIHJpbmcgc2l6ZSBvZgo+ IHZpcnRpby1uZXQuCj4KPiBTaWduZWQtb2ZmLWJ5OiBYdWFuIFpodW8gPHh1YW56aHVvQGxpbnV4 LmFsaWJhYmEuY29tPgoKCkFja2VkLWJ5OiBKYXNvbiBXYW5nIDxqYXNvd2FuZ0ByZWRoYXQuY29t PgoKKE9uZSB0aGluZyB0aGF0IEkgc2VlIGlzIHRoYXQsIHdoZW4gcmVzaXplIGZhaWxzLCB0aGUg cGFyYW0gcmVwb3J0ZWQgdmlhIApnZXRfcmluZ3BhcmFtIG1pZ2h0IGJlIHdyb25nLCB0aGlzIGlz IGEgY29ybmVyIGNhc2UgYnV0IG1pZ2h0IHdvcnRoIHRvIApmaXggaW4gdGhlIGZ1dHVyZSkuCgoK PiAtLS0KPiAgIGRyaXZlcnMvbmV0L3ZpcnRpb19uZXQuYyB8IDQ3ICsrKysrKysrKysrKysrKysr KysrKysrKysrKysrKysrKysrKysrKysKPiAgIDEgZmlsZSBjaGFuZ2VkLCA0NyBpbnNlcnRpb25z KCspCj4KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9uZXQvdmlydGlvX25ldC5jIGIvZHJpdmVycy9u ZXQvdmlydGlvX25ldC5jCj4gaW5kZXggYmE2ODU5ZjMwNWY3Li4zN2U0ZTI3ZjFlNGUgMTAwNjQ0 Cj4gLS0tIGEvZHJpdmVycy9uZXQvdmlydGlvX25ldC5jCj4gKysrIGIvZHJpdmVycy9uZXQvdmly dGlvX25ldC5jCj4gQEAgLTIyNjQsNiArMjI2NCw1MiBAQCBzdGF0aWMgdm9pZCB2aXJ0bmV0X2dl dF9yaW5ncGFyYW0oc3RydWN0IG5ldF9kZXZpY2UgKmRldiwKPiAgIAlyaW5nLT50eF9wZW5kaW5n ID0gdmlydHF1ZXVlX2dldF92cmluZ19zaXplKHZpLT5zcVswXS52cSk7Cj4gICB9Cj4gICAKPiAr c3RhdGljIGludCB2aXJ0bmV0X3NldF9yaW5ncGFyYW0oc3RydWN0IG5ldF9kZXZpY2UgKmRldiwK PiArCQkJCSBzdHJ1Y3QgZXRodG9vbF9yaW5ncGFyYW0gKnJpbmcsCj4gKwkJCQkgc3RydWN0IGtl cm5lbF9ldGh0b29sX3JpbmdwYXJhbSAqa2VybmVsX3JpbmcsCj4gKwkJCQkgc3RydWN0IG5ldGxp bmtfZXh0X2FjayAqZXh0YWNrKQo+ICt7Cj4gKwlzdHJ1Y3QgdmlydG5ldF9pbmZvICp2aSA9IG5l dGRldl9wcml2KGRldik7Cj4gKwl1MzIgcnhfcGVuZGluZywgdHhfcGVuZGluZzsKPiArCXN0cnVj dCByZWNlaXZlX3F1ZXVlICpycTsKPiArCXN0cnVjdCBzZW5kX3F1ZXVlICpzcTsKPiArCWludCBp LCBlcnI7Cj4gKwo+ICsJaWYgKHJpbmctPnJ4X21pbmlfcGVuZGluZyB8fCByaW5nLT5yeF9qdW1i b19wZW5kaW5nKQo+ICsJCXJldHVybiAtRUlOVkFMOwo+ICsKPiArCXJ4X3BlbmRpbmcgPSB2aXJ0 cXVldWVfZ2V0X3ZyaW5nX3NpemUodmktPnJxWzBdLnZxKTsKPiArCXR4X3BlbmRpbmcgPSB2aXJ0 cXVldWVfZ2V0X3ZyaW5nX3NpemUodmktPnNxWzBdLnZxKTsKPiArCj4gKwlpZiAocmluZy0+cnhf cGVuZGluZyA9PSByeF9wZW5kaW5nICYmCj4gKwkgICAgcmluZy0+dHhfcGVuZGluZyA9PSB0eF9w ZW5kaW5nKQo+ICsJCXJldHVybiAwOwo+ICsKPiArCWlmIChyaW5nLT5yeF9wZW5kaW5nID4gdmly dHF1ZXVlX2dldF92cmluZ19tYXhfc2l6ZSh2aS0+cnFbMF0udnEpKQo+ICsJCXJldHVybiAtRUlO VkFMOwo+ICsKPiArCWlmIChyaW5nLT50eF9wZW5kaW5nID4gdmlydHF1ZXVlX2dldF92cmluZ19t YXhfc2l6ZSh2aS0+c3FbMF0udnEpKQo+ICsJCXJldHVybiAtRUlOVkFMOwo+ICsKPiArCWZvciAo aSA9IDA7IGkgPCB2aS0+bWF4X3F1ZXVlX3BhaXJzOyBpKyspIHsKPiArCQlycSA9IHZpLT5ycSAr IGk7Cj4gKwkJc3EgPSB2aS0+c3EgKyBpOwo+ICsKPiArCQlpZiAocmluZy0+dHhfcGVuZGluZyAh PSB0eF9wZW5kaW5nKSB7Cj4gKwkJCWVyciA9IHZpcnRuZXRfdHhfcmVzaXplKHZpLCBzcSwgcmlu Zy0+dHhfcGVuZGluZyk7Cj4gKwkJCWlmIChlcnIpCj4gKwkJCQlyZXR1cm4gZXJyOwo+ICsJCX0K PiArCj4gKwkJaWYgKHJpbmctPnJ4X3BlbmRpbmcgIT0gcnhfcGVuZGluZykgewo+ICsJCQllcnIg PSB2aXJ0bmV0X3J4X3Jlc2l6ZSh2aSwgcnEsIHJpbmctPnJ4X3BlbmRpbmcpOwo+ICsJCQlpZiAo ZXJyKQo+ICsJCQkJcmV0dXJuIGVycjsKPiArCQl9Cj4gKwl9Cj4gKwo+ICsJcmV0dXJuIDA7Cj4g K30KPiAgIAo+ICAgc3RhdGljIHZvaWQgdmlydG5ldF9nZXRfZHJ2aW5mbyhzdHJ1Y3QgbmV0X2Rl dmljZSAqZGV2LAo+ICAgCQkJCXN0cnVjdCBldGh0b29sX2RydmluZm8gKmluZm8pCj4gQEAgLTI0 OTcsNiArMjU0Myw3IEBAIHN0YXRpYyBjb25zdCBzdHJ1Y3QgZXRodG9vbF9vcHMgdmlydG5ldF9l dGh0b29sX29wcyA9IHsKPiAgIAkuZ2V0X2RydmluZm8gPSB2aXJ0bmV0X2dldF9kcnZpbmZvLAo+ ICAgCS5nZXRfbGluayA9IGV0aHRvb2xfb3BfZ2V0X2xpbmssCj4gICAJLmdldF9yaW5ncGFyYW0g PSB2aXJ0bmV0X2dldF9yaW5ncGFyYW0sCj4gKwkuc2V0X3JpbmdwYXJhbSA9IHZpcnRuZXRfc2V0 X3JpbmdwYXJhbSwKPiAgIAkuZ2V0X3N0cmluZ3MgPSB2aXJ0bmV0X2dldF9zdHJpbmdzLAo+ICAg CS5nZXRfc3NldF9jb3VudCA9IHZpcnRuZXRfZ2V0X3NzZXRfY291bnQsCj4gICAJLmdldF9ldGh0 b29sX3N0YXRzID0gdmlydG5ldF9nZXRfZXRodG9vbF9zdGF0cywKCgpfX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC11bSBtYWlsaW5nIGxpc3QKbGlu dXgtdW1AbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWls bWFuL2xpc3RpbmZvL2xpbnV4LXVtCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8DAACC433FE for ; Wed, 13 Apr 2022 08:07:00 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 35200827FB; Wed, 13 Apr 2022 08:07:00 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 90VsV3QSW00U; Wed, 13 Apr 2022 08:06:59 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [IPv6:2605:bc80:3010:104::8cd3:938]) by smtp1.osuosl.org (Postfix) with ESMTPS id B1B158246F; Wed, 13 Apr 2022 08:06:58 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 9219FC0083; Wed, 13 Apr 2022 08:06:58 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by lists.linuxfoundation.org (Postfix) with ESMTP id 77297C002C for ; Wed, 13 Apr 2022 08:06:56 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 55E3E8246F for ; Wed, 13 Apr 2022 08:06:56 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Ep2FNB0zZDBJ for ; Wed, 13 Apr 2022 08:06:55 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by smtp1.osuosl.org (Postfix) with ESMTPS id 0FA14827FB for ; Wed, 13 Apr 2022 08:06:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1649837214; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3oVDDbPJyK3HgpM5oKcpbE9J9tBIr9ChlAXnnhFjPGo=; b=VJekOwGbLy7d1Uvdnd974Z1VOkxCkal8E4PikuOfzh54STCpjdgSs3prB2WhIbccHCZ9c3 TfdsvZG54Elk6DqOXHJKUcpdYGFLFIy3Wc5W4PYCBxpS8rh71rSMB4UoM2fnGmMOwMfIby ZhNkoxIvSYLJmfjrZDZ+iYrNg0NAJuI= Received: from mail-pg1-f199.google.com (mail-pg1-f199.google.com [209.85.215.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-186-9dveI33WPCuKx-96qIlZIw-1; Wed, 13 Apr 2022 04:06:50 -0400 X-MC-Unique: 9dveI33WPCuKx-96qIlZIw-1 Received: by mail-pg1-f199.google.com with SMTP id w3-20020a639343000000b003821fb4a367so706031pgm.21 for ; Wed, 13 Apr 2022 01:06:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=3oVDDbPJyK3HgpM5oKcpbE9J9tBIr9ChlAXnnhFjPGo=; b=1BTMBgNkx2RBmMP8Sf2T4Gla/aep26YXnq43EGG2F3fbocAJ8Im7B/uWaAs3xSBVHS DW7xsfS/sxz10AYx1qmYkmQ9p7knYLa0Ulk0/CIYE4G3NnZipODFQmMwYugrSW610izb H1tyBP4SxqrQh21SfKpsx6JqyhipIkAj0doWrDnnELrzfcfETCmfalAA2NKquvCG2HWu v9sLLM83MdB0tuuMEC9Rw8WC7HEZqD41oEqS29SK190xjBVSYTD5ExcWKy8FIYawFmMy ovrPJIv21j5Yvw3Vq7GRr/LECqX/I7hYtjuPm4ibiEuZLJllDRDBdTxb5O557gx0q0Y1 CpIQ== X-Gm-Message-State: AOAM5321V9RcbABZh7hhvLITj3Z3I9vsrsmZz7S/9fDQ/pRcIIJDdEQL VNyyx3ZqKt4Oi/opHHX7sn9+l8aIxiWQXH//X5PilJ5KTXEe9s+Ic/HjfXUvv/orSHr43ZL8NO5 J4mxQHqOzIANsNT4rfgYozIPbzFRZmjs8aaEU3q/0HQ== X-Received: by 2002:a17:90b:1e06:b0:1cb:b742:ba0d with SMTP id pg6-20020a17090b1e0600b001cbb742ba0dmr9526933pjb.24.1649837209917; Wed, 13 Apr 2022 01:06:49 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxA8440BQVqz6KdwXBOHrMtT4WnGyMxsQffyGtbEDMm0ObQF/C2qu9IScvqE/FloA/61fylAQ== X-Received: by 2002:a17:90b:1e06:b0:1cb:b742:ba0d with SMTP id pg6-20020a17090b1e0600b001cbb742ba0dmr9526892pjb.24.1649837209610; Wed, 13 Apr 2022 01:06:49 -0700 (PDT) Received: from [10.72.13.223] ([209.132.188.80]) by smtp.gmail.com with ESMTPSA id p10-20020a17090a680a00b001c7bf7d32f9sm1982517pjj.55.2022.04.13.01.06.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 13 Apr 2022 01:06:49 -0700 (PDT) Message-ID: <96d1fe97-2e8a-ae8a-a35f-bba2ce0f44b4@redhat.com> Date: Wed, 13 Apr 2022 16:06:33 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH v9 32/32] virtio_net: support set_ringparam To: Xuan Zhuo , virtualization@lists.linux-foundation.org References: <20220406034346.74409-1-xuanzhuo@linux.alibaba.com> <20220406034346.74409-33-xuanzhuo@linux.alibaba.com> From: Jason Wang In-Reply-To: <20220406034346.74409-33-xuanzhuo@linux.alibaba.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=jasowang@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Cc: Vadim Pasternak , "Michael S. Tsirkin" , linux-remoteproc@vger.kernel.org, Alexei Starovoitov , Bjorn Andersson , Alexander Gordeev , Anton Ivanov , linux-s390@vger.kernel.org, Johannes Berg , Daniel Borkmann , Richard Weinberger , Vincent Whitchurch , John Fastabend , Halil Pasic , Jakub Kicinski , Heiko Carstens , Jesper Dangaard Brouer , Vasily Gorbik , Jeff Dike , linux-um@lists.infradead.org, Mark Gross , Hans de Goede , kvm@vger.kernel.org, platform-driver-x86@vger.kernel.org, Mathieu Poirier , netdev@vger.kernel.org, Cornelia Huck , Sven Schnelle , bpf@vger.kernel.org, "David S. Miller" X-BeenThere: virtualization@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux virtualization List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: virtualization-bounces@lists.linux-foundation.org Sender: "Virtualization" CuWcqCAyMDIyLzQvNiDkuIrljYgxMTo0MywgWHVhbiBaaHVvIOWGmemBkzoKPiBTdXBwb3J0IHNl dF9yaW5ncGFyYW0gYmFzZWQgb24gdmlydGlvIHF1ZXVlIHJlc2V0Lgo+Cj4gVXNlcnMgY2FuIHVz ZSBldGh0b29sIC1HIGV0aDAgPHJpbmdfbnVtPiB0byBtb2RpZnkgdGhlIHJpbmcgc2l6ZSBvZgo+ IHZpcnRpby1uZXQuCj4KPiBTaWduZWQtb2ZmLWJ5OiBYdWFuIFpodW8gPHh1YW56aHVvQGxpbnV4 LmFsaWJhYmEuY29tPgoKCkFja2VkLWJ5OiBKYXNvbiBXYW5nIDxqYXNvd2FuZ0ByZWRoYXQuY29t PgoKKE9uZSB0aGluZyB0aGF0IEkgc2VlIGlzIHRoYXQsIHdoZW4gcmVzaXplIGZhaWxzLCB0aGUg cGFyYW0gcmVwb3J0ZWQgdmlhIApnZXRfcmluZ3BhcmFtIG1pZ2h0IGJlIHdyb25nLCB0aGlzIGlz IGEgY29ybmVyIGNhc2UgYnV0IG1pZ2h0IHdvcnRoIHRvIApmaXggaW4gdGhlIGZ1dHVyZSkuCgoK PiAtLS0KPiAgIGRyaXZlcnMvbmV0L3ZpcnRpb19uZXQuYyB8IDQ3ICsrKysrKysrKysrKysrKysr KysrKysrKysrKysrKysrKysrKysrKysKPiAgIDEgZmlsZSBjaGFuZ2VkLCA0NyBpbnNlcnRpb25z KCspCj4KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9uZXQvdmlydGlvX25ldC5jIGIvZHJpdmVycy9u ZXQvdmlydGlvX25ldC5jCj4gaW5kZXggYmE2ODU5ZjMwNWY3Li4zN2U0ZTI3ZjFlNGUgMTAwNjQ0 Cj4gLS0tIGEvZHJpdmVycy9uZXQvdmlydGlvX25ldC5jCj4gKysrIGIvZHJpdmVycy9uZXQvdmly dGlvX25ldC5jCj4gQEAgLTIyNjQsNiArMjI2NCw1MiBAQCBzdGF0aWMgdm9pZCB2aXJ0bmV0X2dl dF9yaW5ncGFyYW0oc3RydWN0IG5ldF9kZXZpY2UgKmRldiwKPiAgIAlyaW5nLT50eF9wZW5kaW5n ID0gdmlydHF1ZXVlX2dldF92cmluZ19zaXplKHZpLT5zcVswXS52cSk7Cj4gICB9Cj4gICAKPiAr c3RhdGljIGludCB2aXJ0bmV0X3NldF9yaW5ncGFyYW0oc3RydWN0IG5ldF9kZXZpY2UgKmRldiwK PiArCQkJCSBzdHJ1Y3QgZXRodG9vbF9yaW5ncGFyYW0gKnJpbmcsCj4gKwkJCQkgc3RydWN0IGtl cm5lbF9ldGh0b29sX3JpbmdwYXJhbSAqa2VybmVsX3JpbmcsCj4gKwkJCQkgc3RydWN0IG5ldGxp bmtfZXh0X2FjayAqZXh0YWNrKQo+ICt7Cj4gKwlzdHJ1Y3QgdmlydG5ldF9pbmZvICp2aSA9IG5l dGRldl9wcml2KGRldik7Cj4gKwl1MzIgcnhfcGVuZGluZywgdHhfcGVuZGluZzsKPiArCXN0cnVj dCByZWNlaXZlX3F1ZXVlICpycTsKPiArCXN0cnVjdCBzZW5kX3F1ZXVlICpzcTsKPiArCWludCBp LCBlcnI7Cj4gKwo+ICsJaWYgKHJpbmctPnJ4X21pbmlfcGVuZGluZyB8fCByaW5nLT5yeF9qdW1i b19wZW5kaW5nKQo+ICsJCXJldHVybiAtRUlOVkFMOwo+ICsKPiArCXJ4X3BlbmRpbmcgPSB2aXJ0 cXVldWVfZ2V0X3ZyaW5nX3NpemUodmktPnJxWzBdLnZxKTsKPiArCXR4X3BlbmRpbmcgPSB2aXJ0 cXVldWVfZ2V0X3ZyaW5nX3NpemUodmktPnNxWzBdLnZxKTsKPiArCj4gKwlpZiAocmluZy0+cnhf cGVuZGluZyA9PSByeF9wZW5kaW5nICYmCj4gKwkgICAgcmluZy0+dHhfcGVuZGluZyA9PSB0eF9w ZW5kaW5nKQo+ICsJCXJldHVybiAwOwo+ICsKPiArCWlmIChyaW5nLT5yeF9wZW5kaW5nID4gdmly dHF1ZXVlX2dldF92cmluZ19tYXhfc2l6ZSh2aS0+cnFbMF0udnEpKQo+ICsJCXJldHVybiAtRUlO VkFMOwo+ICsKPiArCWlmIChyaW5nLT50eF9wZW5kaW5nID4gdmlydHF1ZXVlX2dldF92cmluZ19t YXhfc2l6ZSh2aS0+c3FbMF0udnEpKQo+ICsJCXJldHVybiAtRUlOVkFMOwo+ICsKPiArCWZvciAo aSA9IDA7IGkgPCB2aS0+bWF4X3F1ZXVlX3BhaXJzOyBpKyspIHsKPiArCQlycSA9IHZpLT5ycSAr IGk7Cj4gKwkJc3EgPSB2aS0+c3EgKyBpOwo+ICsKPiArCQlpZiAocmluZy0+dHhfcGVuZGluZyAh PSB0eF9wZW5kaW5nKSB7Cj4gKwkJCWVyciA9IHZpcnRuZXRfdHhfcmVzaXplKHZpLCBzcSwgcmlu Zy0+dHhfcGVuZGluZyk7Cj4gKwkJCWlmIChlcnIpCj4gKwkJCQlyZXR1cm4gZXJyOwo+ICsJCX0K PiArCj4gKwkJaWYgKHJpbmctPnJ4X3BlbmRpbmcgIT0gcnhfcGVuZGluZykgewo+ICsJCQllcnIg PSB2aXJ0bmV0X3J4X3Jlc2l6ZSh2aSwgcnEsIHJpbmctPnJ4X3BlbmRpbmcpOwo+ICsJCQlpZiAo ZXJyKQo+ICsJCQkJcmV0dXJuIGVycjsKPiArCQl9Cj4gKwl9Cj4gKwo+ICsJcmV0dXJuIDA7Cj4g K30KPiAgIAo+ICAgc3RhdGljIHZvaWQgdmlydG5ldF9nZXRfZHJ2aW5mbyhzdHJ1Y3QgbmV0X2Rl dmljZSAqZGV2LAo+ICAgCQkJCXN0cnVjdCBldGh0b29sX2RydmluZm8gKmluZm8pCj4gQEAgLTI0 OTcsNiArMjU0Myw3IEBAIHN0YXRpYyBjb25zdCBzdHJ1Y3QgZXRodG9vbF9vcHMgdmlydG5ldF9l dGh0b29sX29wcyA9IHsKPiAgIAkuZ2V0X2RydmluZm8gPSB2aXJ0bmV0X2dldF9kcnZpbmZvLAo+ ICAgCS5nZXRfbGluayA9IGV0aHRvb2xfb3BfZ2V0X2xpbmssCj4gICAJLmdldF9yaW5ncGFyYW0g PSB2aXJ0bmV0X2dldF9yaW5ncGFyYW0sCj4gKwkuc2V0X3JpbmdwYXJhbSA9IHZpcnRuZXRfc2V0 X3JpbmdwYXJhbSwKPiAgIAkuZ2V0X3N0cmluZ3MgPSB2aXJ0bmV0X2dldF9zdHJpbmdzLAo+ICAg CS5nZXRfc3NldF9jb3VudCA9IHZpcnRuZXRfZ2V0X3NzZXRfY291bnQsCj4gICAJLmdldF9ldGh0 b29sX3N0YXRzID0gdmlydG5ldF9nZXRfZXRodG9vbF9zdGF0cywKCl9fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fClZpcnR1YWxpemF0aW9uIG1haWxpbmcgbGlz dApWaXJ0dWFsaXphdGlvbkBsaXN0cy5saW51eC1mb3VuZGF0aW9uLm9yZwpodHRwczovL2xpc3Rz LmxpbnV4Zm91bmRhdGlvbi5vcmcvbWFpbG1hbi9saXN0aW5mby92aXJ0dWFsaXphdGlvbg==